[Bug 65610] app crash trying very long title search and hitting go

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65610

Dan Garry dga...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Dan Garry dga...@wikimedia.org ---
Unable to reproduce this, so I'm marking it as fixed now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66448] Warning: trim() expects parameter 1 to be string, array given in OggHandler.php on line 116

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66448

--- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 140641 had a related patch set uploaded by Brian Wolff:
Handle double tags properly (fix php warning about trim())

https://gerrit.wikimedia.org/r/140641

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66448] Warning: trim() expects parameter 1 to be string, array given in OggHandler.php on line 116

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66448

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66801] Warning: Invalid argument supplied for foreach() in MediaHandler.php on line 509

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66801

--- Comment #1 from Bawolff (Brian Wolff) bawolff...@gmail.com ---
Any information on what page this warning was triggered from?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66823] New: Core patches still block account creation when extension is not enabled

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66823

Bug ID: 66823
   Summary: Core patches still block account creation when
extension is not enabled
   Product: MediaWiki extensions
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: MediaWikiAuth
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: zhoris...@gmail.com
CC: j...@countervandalism.net,
legoktm.wikipe...@gmail.com, skizz...@gmail.com,
zhoris...@gmail.com
   Web browser: ---
   Mobile Platform: ---

MediaWikiAuth blocks normal account creation for an account when it can be
imported, because otherwise the account could be taken over by a troll, the
contributions could get lost and weird, and/or possibly other things.
Unfortunately this is done via a horrible hack in the specialloginform or some
such, and if the horrible hack is present, it still activates even when the
extension itself is not enabled.

Immediate fix would be to make the speciallogin hack less stupid, but really
the base problem is because it needs a core hack in the first place. The
hack/patch exists, apparently, because there is/was no hook or something in the
file in order to block account creation or enable it or something along those
lines.

Jack Phoenix, please say more about this or something. You would actually know
what you're talking about BUT THIS IS IMPORTANT DAMMIT AND I ALREADY COMPLETELY
FORGOT ABOUT IT ONCE.

Er.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66801] Warning: Invalid argument supplied for foreach() in MediaHandler.php on line 509

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66801

--- Comment #2 from Bawolff (Brian Wolff) bawolff...@gmail.com ---
(In reply to Bawolff (Brian Wolff) from comment #1)
 Any information on what page this warning was triggered from?

Nevermind, I figured out what was happening. Its a silly mistake I made in one
of my commits.

(For reference, example file:
http://localhost/w/git/index.php/File:CVO-Universit%C3%A4t-Oldenburg-Steffi.ogg
)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66823] Core patches still block account creation when extension is not enabled

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66823

--- Comment #1 from Jack Phoenix j...@countervandalism.net ---
There are at least two sorta-but-not-quite-separate issues here:
* the don't allow account creation if such an account existed on the remote
wiki feature; this should be an optional setting that can be turned on or off;
right now it's on and the only way to get around that is to mess with the code
* MediaWikiAuth requires a core patch (hack) and there might not be such a
patch available for the latest version(s) of MediaWiki, because people are lazy
(trust me, I'm an expert on this field!)

When we upgraded ShoutWiki to 1.23, I applied the 1.21 patch, but two hunks
failed, so I had to do those manually, and frankly, I'm not sure if I got it
correct at all (this is r2545 on the ShoutWiki SVN). In any case, this whole
patching scenario is just outright awful and something we should fix.

The biggest code portion -- new static function checkImportableUser(), which
happens to be the thing that oughta be hidden behind a global -- can be moved
to MediaWikiAuth as-is, probably.
LoginForm::checkImportableUser() is called in
LoginForm::addNewAccountInternal(), right after the is this an invalid
domain? check, at the very beginning of the function. Much later in the same
function we have the AbortNewAccount hook (and also the
ExemptFromAccountCreationThrottle hook, though that's of no relevance to us for
this issue); this is way too late for our use case, hence the core patch.
Should be solvable by slapping a new hook at the beginning of
LoginForm::checkImportableUser() and calling it a day.

Then there's the weird error message support patch for
LoginForm::attemptAutoCreate(); a $wgAuth-authenticate() call normally called
with two params is given a third one (which is null by default) *and* to
display a possible error message set by the AuthPlugin, a call to
$this-mainLoginForm() is made right before returning the status code
(self::WRONG_PLUGIN_PASS). This is very messy and needs some serious
rethinking.

The above-described mess has a little cousin, too, which is the patch to
LoginForm::processLogin(). The actual logic of case self::WRONG_PLUGIN_PASS is
commented out as it's implemented above, in attemptAutoCreate().

My explanation probably made no sense, but once you look at the available patch
files, it should be somewhat clearer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66801] Warning: Invalid argument supplied for foreach() in MediaHandler.php on line 509

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66801

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66802] Warning: Invalid argument supplied for foreach() in FormatMetadata.php on line 104

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66802

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66802] Warning: Invalid argument supplied for foreach() in FormatMetadata.php on line 104

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66802

--- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 140643 had a related patch set uploaded by Brian Wolff:
Fix issue where getCommonMetaArray returned false instead of array()

https://gerrit.wikimedia.org/r/140643

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66801] Warning: Invalid argument supplied for foreach() in MediaHandler.php on line 509

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66801

--- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 140643 had a related patch set uploaded by Brian Wolff:
Fix issue where getCommonMetaArray returned false instead of array()

https://gerrit.wikimedia.org/r/140643

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54906] VisualEditor: Append references list to bottom of pages when first reference is added

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54906

Erik Moeller e...@wikimedia.org changed:

   What|Removed |Added

 CC||e...@wikimedia.org

--- Comment #16 from Erik Moeller e...@wikimedia.org ---
Why not treat references like the TOC and always have MediaWiki output them at
the bottom of the page (or section when in preview mode in wikitext) unless a
references/ tag is present?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66824] New: Tabbing broken in the citation window

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66824

Bug ID: 66824
   Summary: Tabbing broken in the citation window
   Product: VisualEditor
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Editing Tools
  Assignee: jforrester+veteambztick...@wikimedia.org
  Reporter: mflasc...@wikimedia.org
CC: jforres...@wikimedia.org, rm...@wikimedia.org,
ryasm...@wikimedia.org, tpars...@wikimedia.org
   Web browser: ---
   Mobile Platform: ---

On English Wikipedia, tabbing in the citation dialog is broken.  To reproduce:

1. Edit an article with VE.
2. Choose 'News' from the Cite menu.
3. Click the first field.
4. Tab to try to get to the next field.

Focus goes to a help icon, and even tabbing repeatedly will not get it to leave
that icon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 66825] New: LqtHooks::customiseSearchProfiles triggers Notice: Undefined index: help

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=66825

Bug ID: 66825
   Summary: LqtHooks::customiseSearchProfiles triggers  Notice:
Undefined index: help
   Product: MediaWiki extensions
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: LiquidThreads
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: bawolff...@gmail.com
CC: agarr...@wikimedia.org, dh...@wikimedia.org,
pandiculat...@gmail.com
   Web browser: ---
   Mobile Platform: ---

Getting a bunch of notices locally when searching:

Notice: Undefined index: help in /var/www/w/git/includes/GlobalFunctions.php on
line 289

Seems to come from  LqtHooks::customiseSearchProfiles(array)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


<    1   2   3   4   5   6