[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #37 from Nemo --- (In reply to comment #36) > Well, it's more an ugly hack to work around bug 48956 and this one, not > really > a solution. Yep, the solution is fixing the bug. :D Once it's fixed, it needs to be properly documented and communicated. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #36 from MF-Warburg --- (In reply to comment #35) > Multilingual wikis are also getting used to copying their customisations to > language subpages since a few months ago per the plan above, e.g. > [[m:Special:PrefixIndex/MediaWiki:sp-contributions-footer]] (though it's > definitely not widespread yet). Well, it's more an ugly hack to work around bug 48956 and this one, not really a solution. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #35 from Nemo --- Multilingual wikis are also getting used to copying their customisations to language subpages since a few months ago per the plan above, e.g. [[m:Special:PrefixIndex/MediaWiki:sp-contributions-footer]] (though it's definitely not widespread yet). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #34 from Liangent --- (In reply to comment #33) > (In reply to comment #32) > > For clarity, the current plan is Niklas' option 1 as per bug 46579 comment > > 17. > > Using [[MediaWiki:Foo]] for changes which are specific to the English > language > and [[MediaWiki:Foo/en]] for language-independent customizations seems > totally > counterintuitive to me. Huh I didn't follow these bugs closely but this is exactly what's being used somewhere: on zhwiki [[MediaWiki:Foo]] is for changes specific to zh and [[MediaWiki:Foo/zh]] is for zh and all its variants (a bot synchronizes message pages). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Tisza Gergő changed: What|Removed |Added CC||gti...@wikimedia.org --- Comment #33 from Tisza Gergő --- (In reply to comment #32) > For clarity, the current plan is Niklas' option 1 as per bug 46579 comment > 17. Using [[MediaWiki:Foo]] for changes which are specific to the English language and [[MediaWiki:Foo/en]] for language-independent customizations seems totally counterintuitive to me. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Nemo changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=55473 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #32 from Nemo --- For clarity, the current plan is Niklas' option 1 as per bug 46579 comment 17. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Siebrand Mazeland changed: What|Removed |Added Blocks||48956 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Nemo changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=38662 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Nemo changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=11267 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Andre Klapper changed: What|Removed |Added Keywords|patch-in-gerrit | Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #31 from Gerrit Notification Bot --- Change 72867 had a related patch set uploaded by Parent5446: Complete usage of message fallback chain https://gerrit.wikimedia.org/r/72867 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Bug 1495 depends on bug 46579, which changed state. Bug 46579 Summary: Localization failure on edit tabs, article history, and contribution history for English Wikipedia https://bugzilla.wikimedia.org/show_bug.cgi?id=46579 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Nemo changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=48956 --- Comment #30 from Nemo --- https://gerrit.wikimedia.org/r/#/c/57518/ was merged -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #29 from Gerrit Notification Bot --- https://gerrit.wikimedia.org/r/63365 (Gerrit Change I5ea8af299a14e052b265ebf9f21914ab0a4eb922) | change APPROVED and MERGED [by jenkins-bot] -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #28 from Gerrit Notification Bot --- Related URL: https://gerrit.wikimedia.org/r/63365 (Gerrit Change I5ea8af299a14e052b265ebf9f21914ab0a4eb922) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #27 from Tyler Romeo --- (In reply to comment #26) > (In reply to comment #25) > > If we change the process to: > > > > * Check the DB and then the Language object for each language in the > > fallback > > > > Then the precedence becomes proper again. > > It's not that simple. Some times the wiki version (or translations of it) > should take precedence of stock translations, sometimes not. > > Another issue is that you cannot loop through l10n cache (what you call > language object) per language. In the caches the whole fallback chain has > been > merged already, and you have no information of what language is returned. > Fixing that is a project of its own. How so? The current implementation right now is that there is no fallback chain. The issue with the gerrit change was that it inserted stuff midway in the process. I'm saying have the fallback chain actually be a fallback chain, i.e., it only uses it if it actually needs to fall back. FWIW, here's what I got: https://gerrit.wikimedia.org/r/57518 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #26 from Niklas Laxström --- (In reply to comment #25) > If we change the process to: > > * Check the DB and then the Language object for each language in the fallback > > Then the precedence becomes proper again. It's not that simple. Some times the wiki version (or translations of it) should take precedence of stock translations, sometimes not. Another issue is that you cannot loop through l10n cache (what you call language object) per language. In the caches the whole fallback chain has been merged already, and you have no information of what language is returned. Fixing that is a project of its own. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #25 from Tyler Romeo --- Well if you look at the patch, the issue was that it executed the following process: * Check the DB for every language in the fallback * Check the actual Language object It was because of this that customized messages in fallback languages were taking precedence over default messages in the requested language object, thus leading to localization issues. If we change the process to: * Check the DB and then the Language object for each language in the fallback Then the precedence becomes proper again. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Chad H. changed: What|Removed |Added CC|innocentkil...@gmail.com| -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #24 from MF-Warburg --- Of course, why would someone not want it? :) Can you explain in which way the problem with bug 46579 would be solved then? -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #23 from Tyler Romeo --- The issue with bug 46579 can be fixed by including the Language object check, i.e., $requestedLangObj->getMessage() inside the fallback chain check. If people want, I can pull the reverted patch, rework it to try and fix both bugs, and then re-push it. Should I do this? -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #22 from MF-Warburg --- Mmmpfff. They should challenge enwiki customizations on enwiki then. Could the solution be to enable an option to not show any custom messages? (that way even the people who need to suffer under the evilness of en's customization who prefer en as their interface language can be helped!) Sorry for the polemic, but it makes me facepalm that a bug fix that comes 8 years after the bug opening is reverted because some people disagree with enwiki MediaWiki: edits. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #21 from Nemo --- (In reply to comment #20) > I don't understand the whining at bug 46579. You answered yourself on why: you're speaking of Meta and Incubator, while en.wiki has an extended habit of customising things that probably shouldn't be customised (or at least should not according to those who complain). -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #20 from MF-Warburg --- Is there any chance to get this again? I must say I was quite enchanted by the chance which finally allowed me to see useful interface customizations (I'm mainly on meta & incubator) while having the rest of the interface in my native language. I don't understand the whining at bug 46579. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 MF-Warburg changed: What|Removed |Added CC||mfwarb...@googlemail.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Bug 1495 depends on bug 46579, which changed state. Bug 46579 Summary: Localization failure on edit tabs, article history, and contribution history for English Wikipedia https://bugzilla.wikimedia.org/show_bug.cgi?id=46579 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Tyler Romeo changed: What|Removed |Added Status|RESOLVED|REOPENED CC||tylerro...@gmail.com Resolution|FIXED |--- --- Comment #19 from Tyler Romeo --- Reopening since the change was reverted. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #18 from Siebrand --- Bug 46579 comment 19 explains why the current solution should be reverted now, and readded in an updated way once the needed rework is done. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 --- Comment #17 from Siebrand --- This causes bug 46579. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Siebrand changed: What|Removed |Added Depends on||46579 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Mormegil changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #16 from Mormegil --- Merged in commit 0f3d17edd4ef967930b31149123fabaef8276b59 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Mormegil changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #15 from Mormegil --- The change has one small problem (well, more, but let’s keep it simple for start): It does not include the site language itself in the fallback chain. Obviously, the problem appears only when the site language is not English, because English is included always as the fallback language of last resort. But for non-English sites, we need to add it explicitly (Language::getFallbacksFor does not return it in the list), otherwise we do not see the modified messages in the local language at all. Pushed to Gerrit as Ib607a446d3499a3c042dce408db5cbaf12fa9e3d -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Siebrand changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #14 from Siebrand --- Gerrit 44224 being merged. Thanks for popping up 8 years after the bug was created, Matt! -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 James Alexander changed: What|Removed |Added CC||jalexan...@wikimedia.org -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Nemo changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=8960 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Matt Walker changed: What|Removed |Added CC||bugzilla.wikime...@publi.pu ||rodha.net --- Comment #13 from Matt Walker --- *** Bug 31305 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Matt Walker changed: What|Removed |Added Keywords||patch-in-gerrit Status|NEW |ASSIGNED CC||mwal...@wikimedia.org Assignee|wikibugs-l@lists.wikimedia. |mwal...@wikimedia.org |org | --- Comment #12 from Matt Walker --- Well, I started an initial attempt here. It has some performance issues still. https://gerrit.wikimedia.org/r/#/c/44224/1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Liangent changed: What|Removed |Added CC||zog...@gmail.com --- Comment #11 from Liangent 2012-11-17 17:00:00 UTC --- *** Bug 37949 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1495] Improve message source fallback flow
https://bugzilla.wikimedia.org/show_bug.cgi?id=1495 Liangent changed: What|Removed |Added Summary|Undefined messages in user |Improve message source |language don't fall back to |fallback flow |MediaWiki: customizations | --- Comment #10 from Liangent 2012-08-14 18:50:57 UTC --- The current is (see MessageCache::get, if I read correctly): * (if database is used:) Use page MediaWiki:/ or MediaWiki: if $wgLanguageCode === * Message from requested language object, which is: from PHP files in requested language and its fallbacks * (if the message key contains a slash which is used to specify an alternative language code:) Message from the alternative language object, see above * (if database is used and $wgLanguageCode !== ) Use page MediaWiki: There can be an extra source: * (if database is used:) Use page MediaWiki:/ But where should we put it? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
