[Bug 15659] cache problem: old revisions are shown

2009-01-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15659


P.Copp  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
  Component|General/Unknown |FlaggedRevs
Product|MediaWiki   |MediaWiki extensions
 Resolution|DUPLICATE   |
Version|unspecified |any




--- Comment #28 from P.Copp   2009-01-10 
04:53:18 UTC ---
Reopening, as this still occurs on dewiki every couple of days[1].

The pattern is always the same: current revision is sighted, anons see the
current revision, but logged-in users see a very old revision from parser
cache. After purging the page, the problem disappears.

I finally managed to reproduce this on my local install. Try the following
steps:
* Login as an editor
* Pick a random article in mainspace and sight the current revision
* Select a diff between an old (unsighted) revision and the current one
* add '&diffonly=1&action=purge' to the url
Now when you ylick on the tab to view the article normally, you should notice,
that the old revision is shown (assuming that parser cache is enabled).

I'm not totally certain, what the cause for this is, but my guess would be
FlaggedRevs::stableVersionIsSynced(), line 512:
Seems like Article::getContent pulls the oldid parameter from the request
object, so what is saved in the parser cache afterwards will be the parsed old
revision, not the current one under certain circumstances.


[1]
http://de.wikipedia.org/w/index.php?title=Wikipedia:Fragen_zur_Wikipedia&oldid=55139574#Explorer-Brian-Kuriosum


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15659] cache problem: old revisions are shown

2009-01-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15659


Melancholie  changed:

   What|Removed |Added

 CC||wiki.melancho...@web.de




--- Comment #29 from Melancholie   2009-01-10 05:06:50 
UTC ---
Is FlaggedRevs really the correct component for this bug?
Such cache bugs occur on *all* Wikimedia wikis (I know for sure), regardless
whether FlaggedRevs is installed or not.
This cache problem is years old actually, and it most often occurs when our
server are struggling (like currently, while much hardware is moved from A to
B).

Hasn't there been another bug report for "old rev shown", actually?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15659] cache problem: old revisions are shown

2009-01-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15659





--- Comment #30 from P.Copp   2009-01-10 
05:14:36 UTC ---
Have you tried to reproduce this bug like I described above, on one wiki with
FlaggedRevs and one without? 


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15659] cache problem: old revisions are shown

2009-01-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15659





--- Comment #31 from Melancholie   2009-01-10 05:37:53 
UTC ---
I do not know whether your bug report is quite the same as the initial one ;-)
But both are cache issues.
Just wanted to point out that this may (also) be a core issue, maybe.
Maybe it just becomes more apparent in combination with FlaggedRevs, as this is
a cache based extension.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15659] cache problem: old revisions are shown

2009-01-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15659





--- Comment #32 from P.Copp   2009-01-10 
05:52:05 UTC ---
Sorry, I just don't get your point. This bug is about a very specific problem
with the parser cache handling in FlaggedRevs. It is easily reproducible as I
described and can certainly be tracked down with a bit of debugging.

If you know of other parser cache related issues in wikis without FlaggedRevs,
fine. Feel free to file a bug about it or append to an existing one, but these
thing are probably not related at all to this specifig bug.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15659] cache problem: old revisions are shown

2009-01-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15659





--- Comment #33 from Melancholie   2009-01-10 06:02:04 
UTC ---
I do not see that in the initial post.
Just wanted to emphasize the considerations of Aaron, see comment #20, sorry
(just meant that this might *not just* be a FlaggedRevs issue).


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 15659] cache problem: old revisions are shown

2009-01-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=15659


Aaron Schulz  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Comment #34 from Aaron Schulz   2009-01-10 13:21:46 
UTC ---
Fixed in r45633. Was indeed due to unexpected behavior of getContent().


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l