[Bug 16414] Upload form should prevent submission of filename with disallowed extension

2011-05-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=16414

Bryan Tong Minh  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 CC||bryan.tongm...@gmail.com
 Resolution||FIXED

--- Comment #8 from Bryan Tong Minh  2011-05-15 
11:58:41 UTC ---
Was fixed somewhere along the way.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 16414] Upload form should prevent submission of filename with disallowed extension

2009-05-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=16414





--- Comment #6 from Michael Dale   2009-05-27 15:40:41 UTC ---
the fix to this bug has been re-factored into uploadPage.js as part of the js2
code refactoring. It integrates better with the firefogg support and has been
committed to the new-upload branch


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 16414] Upload form should prevent submission of filename with disallowed extension

2009-04-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=16414


Michael Dale  changed:

   What|Removed |Added

 AssignedTo|aboost...@wikimedia.org |d...@ucsc.edu
 Status|NEW |ASSIGNED




--- Comment #5 from Michael Dale   2009-04-14 17:20:11 UTC ---
Created an attachment (id=6026)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6026)
patch for skin.php and upload.js

... it does not appear that we where putting the whitelisted extensions into
the UI after all... (added to skin.php for upload pages) 

Addds the js for the extension check to the fillDestFilename function. This
patch has also been committed to the upload branch in r49470

 
Life will be easier once jQuery is supported by default.. such a pain to write
javascript without that library :( I think the next patch will be the script
loader and it will add in jQuery by default. 



-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 16414] Upload form should prevent submission of filename with disallowed extension

2009-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=16414





--- Comment #4 from Brion Vibber   2009-03-06 19:27:27 UTC 
---
*nod* We're already putting the whitelisted extensions into UI, so it should be
straightforward to put out the whitelisted & blacklisted extensions to JS. :)


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 16414] Upload form should prevent submission of filename with disallowed extension

2009-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=16414





--- Comment #3 from Michael Dale   2009-03-06 19:07:44 UTC ---
I believe the _extended_ commons upload js already checks for that sort of
thing.  See: setFileExtensions() & checkFileExtension() in
http://commons.wikimedia.org/w/index.php?title=MediaWiki:UploadForm.js&action=raw&ctype=text/javascript

But it would be much cleaner to pull those values from the server. Perhaps in
conjunction with the destination file check ajax request. (if
$wgAjaxUploadDestCheck is true as  Siebrand as points out)


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 16414] Upload form should prevent submission of filename with disallowed extension

2009-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=16414


Brion Vibber  changed:

   What|Removed |Added

 CC||d...@ucsc.edu,
   ||br...@wikimedia.org
 AssignedTo|wikibugs-   |aboost...@wikimedia.org
   |l...@lists.wikimedia.org   |




--- Comment #2 from Brion Vibber   2009-03-06 01:42:38 UTC 
---
Another nice little one for the usability team to cut their teeth on. :)

(Note there are bigger changes to upload coming in a branch; CC'ing Michael
Dale for reference.)


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 16414] Upload form should prevent submission of filename with disallowed extension

2008-11-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=16414


Platonides <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 16414] Upload form should prevent submission of filename with disallowed extension

2008-11-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=16414


Siebrand <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #1 from Siebrand <[EMAIL PROTECTED]>  2008-11-21 17:38:31 UTC ---
Could also be implemented server side when "$wgAjaxUploadDestCheck = true;", I
guess.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l