[Bug 16459] user native getElementsByClassName
https://bugzilla.wikimedia.org/show_bug.cgi?id=16459
--- Comment #10 from Roan Kattouw 2010-08-04 11:30:00
UTC ---
(In reply to comment #9)
> (In reply to comment #8)
> > This should all be moot once we have jQuery on every page and people can
> > just
> > use $('.classname')
>
> How is anyone supposed to know to do that without some documentation?
We could change getElementsByClassName() to wrap around $('.classname') somehow
and deprecate the former.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16459] user native getElementsByClassName
https://bugzilla.wikimedia.org/show_bug.cgi?id=16459
--- Comment #9 from Mike.lifeguard 2010-08-03
22:33:36 UTC ---
(In reply to comment #8)
> This should all be moot once we have jQuery on every page and people can just
> use $('.classname')
How is anyone supposed to know to do that without some documentation?
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16459] user native getElementsByClassName
https://bugzilla.wikimedia.org/show_bug.cgi?id=16459
Roan Kattouw changed:
What|Removed |Added
CC||roan.katt...@gmail.com
--- Comment #8 from Roan Kattouw 2010-08-03 20:14:17
UTC ---
This should all be moot once we have jQuery on every page and people can just
use $('.classname')
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16459] user native getElementsByClassName
https://bugzilla.wikimedia.org/show_bug.cgi?id=16459 entli...@gmx-topmail.de changed: What|Removed |Added CC||entli...@gmx-topmail.de --- Comment #7 from entli...@gmx-topmail.de 2010-07-27 03:43:42 UTC --- Another inconsistency: The original implementation returns an array. The native implementation returns a live NodeList. The wrapper function returns that as-is if strTagName is the wildcard, but converts it to an array if strTagName is a specific tag name. That can be really confusing. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16459] user native getElementsByClassName
https://bugzilla.wikimedia.org/show_bug.cgi?id=16459 --- Comment #6 from Derk-Jan Hartman 2009-01-14 15:47:14 UTC --- Hmm, I totally missed that in the original code. Well, the original author did write a new version of this class back in May. http://www.robertnyman.com/2008/05/27/the-ultimate-getelementsbyclassname-anno-2008/ However, i'm not that big a fan. It seems like a gigantic amount of code to saddle upon all our clients, for just the smallest amount of usecases. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16459] user native getElementsByClassName
https://bugzilla.wikimedia.org/show_bug.cgi?id=16459 Lupo changed: What|Removed |Added CC||lupo.bugzi...@gmail.com Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #5 from Lupo 2009-01-06 20:56:38 UTC --- Sorry, but this change http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/wikibits.js?r1=44192&r2=44774 breaks the interface of function getElementsByClassName. In the original implementation, oClassNames could be a regular expression such as 'wp\\S*', or a list of strings! In the native implementation in Firefox 3, the parameter can only be a single string, see https://developer.mozilla.org/En/DOM/document.getElementsByClassName As a result, a call like getElementsByClassName (elem, '*', 'wp\\S*'); now returns an empty array, whereas it previously returned all child elements of elem having a class that started with "wp". This change breaks some functionality in the upload form on the Commons. Calls like getElementsByClassName (elem, '*', ['class1', 'class2']); also won't work anymore. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16459] user native getElementsByClassName
https://bugzilla.wikimedia.org/show_bug.cgi?id=16459 Aryeh Gregor changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #4 from Aryeh Gregor 2008-12-18 18:16:35 UTC --- Committed in r44774 with whitespace tweaks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16459] user native getElementsByClassName
https://bugzilla.wikimedia.org/show_bug.cgi?id=16459 --- Comment #3 from Derk-Jan Hartman <[EMAIL PROTECTED]> 2008-12-01 17:12:39 UTC --- Tested and works on IE6 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16459] user native getElementsByClassName
https://bugzilla.wikimedia.org/show_bug.cgi?id=16459 --- Comment #2 from Derk-Jan Hartman <[EMAIL PROTECTED]> 2008-11-26 14:07:13 UTC --- I have created testcases here: http://test.wikipedia.org/wiki/User:TheDJ/monobook.js Which i tested with this page: http://test.wikipedia.org/wiki/Transwiki:Wikiversity-School_of_Computer_Science/IntroProgramingJava Safari 2, 3, Opera 9.5, FF 2 and FF 3, all returned identical numbers. IE is not tested, but i assume it understands typeof. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16459] user native getElementsByClassName
https://bugzilla.wikimedia.org/show_bug.cgi?id=16459 Aryeh Gregor <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] ||m --- Comment #1 from Aryeh Gregor <[EMAIL PROTECTED]> 2008-11-25 23:15:20 UTC --- Have you tested that this causes no regressions in any browsers (e.g., sortable tables still work)? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
