[Bug 17080] #time parserfunction parses dates in the PHP default timezone before converting to UTC
https://bugzilla.wikimedia.org/show_bug.cgi?id=17080 Max Semenik changed: What|Removed |Added Keywords|patch-need-review | Status|NEW |RESOLVED CC||maxsem.w...@gmail.com Resolution||FIXED --- Comment #10 from Max Semenik 2012-04-26 19:39:51 UTC --- (In reply to comment #9) > (In reply to comment #8) > > PHP 5.1 has pretty much fallen out of support for us. > > Removing the pre-5.2 code path entirely would be an acceptable fix as far as > I'm concerned. This was done some time ago, closing the bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17080] #time parserfunction parses dates in the PHP default timezone before converting to UTC
https://bugzilla.wikimedia.org/show_bug.cgi?id=17080 --- Comment #9 from Brad Jorsch 2012-04-13 13:19:59 UTC --- (In reply to comment #8) > PHP 5.1 has pretty much fallen out of support for us. Removing the pre-5.2 code path entirely would be an acceptable fix as far as I'm concerned. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17080] #time parserfunction parses dates in the PHP default timezone before converting to UTC
https://bugzilla.wikimedia.org/show_bug.cgi?id=17080 Aaron Schulz changed: What|Removed |Added CC||aschulz4...@gmail.com --- Comment #8 from Aaron Schulz 2012-04-13 03:54:00 UTC --- PHP 5.1 has pretty much fallen out of support for us. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17080] #time parserfunction parses dates in the PHP default timezone before converting to UTC
https://bugzilla.wikimedia.org/show_bug.cgi?id=17080 Sumana Harihareswara changed: What|Removed |Added Keywords||need-review CC||suma...@panix.com --- Comment #7 from Sumana Harihareswara 2011-11-14 16:44:57 UTC --- Sorry for the wait, Brad. Marking this bug with "need-review" to make sure developers see that your patch awaits review. Thanks for the contribution. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17080] #time parserfunction parses dates in the PHP default timezone before converting to UTC
https://bugzilla.wikimedia.org/show_bug.cgi?id=17080
Brad Jorsch changed:
What|Removed |Added
Attachment #5704|0 |1
is obsolete||
--- Comment #6 from Brad Jorsch 2011-02-20
20:37:42 UTC ---
Created attachment 8183
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8183
Patch to fix {{#time}} for systems without the DateTime class.
A patch almost identical to the first section of my patch was applied in r50506
and r60826 to fix a different bug, so this is half-fixed now.
The bug still exists on systems without the PHP DateTime class (e.g. PHP before
5.2), and in fact is even more broken since r60825 effectively disabled use of
the TZ environment variable. If we don't care about 5.1 anymore I suppose this
bug can be closed (and the non-DateTime codepath removed), otherwise I've
attached an updated patch.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17080] #time parserfunction parses dates in the PHP default timezone before converting to UTC
https://bugzilla.wikimedia.org/show_bug.cgi?id=17080
Brad Jorsch changed:
What|Removed |Added
CC||b-jor...@northwestern.edu
Severity|critical|normal
Keywords||patch
Summary|Dates are a day behind |#time parserfunction parses
||dates in the PHP default
||timezone before converting
||to UTC
--- Comment #5 from Brad Jorsch 2009-01-19
17:59:27 UTC ---
The issue is that #time parses dates without an explicitly specified timezone
in the PHP default timezone and then converts that to UTC. If the PHP default
timezone happens to be UTC, all is good. If the PHP default is east of UTC, we
get this obvious problem, and if it is west of UTC we get problems in less
obvious cases.
For example, {{#time:Y-m-d|2009-01-01}} parses the date at midnight in the PHP
default timezone, which might result in DateTime object containing the time
"2009-01-01T00:00:00+01:00". #time then converts this to UTC, resulting in
"2008-12-31T23:00:00+00:00", giving "2008-12-31" rather than the expected
"2009-01-01" as the output.
It would probably make more sense to have #time use UTC as the default, and
#timel the $wgLocaltimezone time. This can be done easily by specifying the
second parameter to DateTime::__construct for the modern PHP case, and setting
TZ before the strtotime() (instead of only for the date() call) should suffice
for the fallback case.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
