[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 James Forrester changed: What|Removed |Added CC||jforres...@wikimedia.org --- Comment #12 from James Forrester --- (In reply to wikimedia-gaijin42 from comment #11) > This bug appears to still be happening quite regularly on en.wikipedia > > https://en.wikipedia.org/wiki/Wikipedia: > Village_pump_(technical)#some_sort_of_mediawiki_error_is_happening That was a new issue caused by a problem with the Cite extension that we reverted and shouldn't happen again. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 wikimedia-gaiji...@sneakemail.com changed: What|Removed |Added CC||wikimedia-gaijin42@sneakema ||il.com --- Comment #11 from wikimedia-gaiji...@sneakemail.com --- This bug appears to still be happening quite regularly on en.wikipedia https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#some_sort_of_mediawiki_error_is_happening -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 --- Comment #10 from Andre Klapper --- Paul / Tim Starling: > What's the state of this? Has the functionality of the patch been included > in core, or is this a WONTFIX? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 --- Comment #9 from Andre Klapper --- Paul / Tim Starling: > What's the state of this? Has the functionality of the patch been included > in core, or is this a WONTFIX? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 Tim Landscheidt changed: What|Removed |Added CC||t...@tim-landscheidt.de --- Comment #8 from Tim Landscheidt --- What's the state of this? Has the functionality of the patch been included in core, or is this a WONTFIX? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 --- Comment #7 from Platonides 2011-11-06 22:00:43 UTC --- I think this was fixed along the way. MessageCache uses a clone of the parser, and MessageCache::parse is itself not reentrant since r86304, which also mage wfMsgExt() no longer use $wgOut->parse() (bug 28532). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 Sumana Harihareswara changed: What|Removed |Added Keywords|need-review |newparser, reviewed CC||suma...@panix.com --- Comment #6 from Sumana Harihareswara 2011-11-06 14:51:27 UTC --- Thank you for your patch, P.Copp. Since Tim reviewed it, I'm changing the "need-review" keyword to "reviewed." I'm also adding the "newparser" keyword since this seems like the kind of thing Gabriel Wicke & Brion Vibber will want to address in their current parser rewrite. You might also want to subscribe to https://lists.wikimedia.org/mailman/listinfo/wikitext-l to learn about the parser rewrite and suggest this kind of fix. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 Platonides changed: What|Removed |Added CC||platoni...@gmail.com --- Comment #5 from Platonides 2010-10-13 22:10:34 UTC --- What about replacing uses of $wgParser with a new method Parser:newParser() ? Instead of using the global parser and hoping it is available, you just request a new parser (initialised to the defaults) each time. Then that function could reuse the same parser object if it is safe to do. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 --- Comment #4 from Vitaliy Filippov 2009-12-15 23:17:37 UTC --- Hi! Why not simply pass clearState=false to wgParser->parse()? Strip state markers are "globally unique" so what's wrong with this approach? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 Alexandre Emsenhuber [IAlex] changed: What|Removed |Added CC||vita...@yourcmc.ru --- Comment #3 from Alexandre Emsenhuber [IAlex] 2009-12-15 18:54:29 UTC --- *** Bug 21855 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 Tim Starling changed: What|Removed |Added CC||tstarl...@wikimedia.org --- Comment #2 from Tim Starling 2009-04-30 04:02:35 UTC --- The problem is that $wgParser->parse() is not re-entrant. It could be made to be re-entrant, by splitting the Parser class into a configuration class and a context class. So $wgParser would be the configuration object, and it would create a fresh context object, with a new set of strip markers, at each call to $wgParser->parse(). This would mean that callback hooks would need to get the context object rather than the configuration object, which could cause large-scale b/c breakage if not done carefully. I think juggling a whole lot of parser object, storing them in unlikely places like $wgMessageCache, and requiring the user to guess which one to use, would just be a recipe for more errors. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 Raimond Spekking changed: What|Removed |Added Keywords||need-review, patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17329] Message handling in parser
https://bugzilla.wikimedia.org/show_bug.cgi?id=17329 --- Comment #1 from P.Copp 2009-02-02 23:53:40 UTC --- Created an attachment (id=5772) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=5772) Proposed patch: Use $wgMessageCache->mParser in $wgOut->parse This patch basically does three things: *Add ->mParsing to the Parser to keep track, if this parser is currently in use. *Make MessageCache's parser publicly usable *Add a check to OutputPage::parse to switch to MessageCache's parser in case that $wgParser is in use. I've tested it locally and it seems that it fixes the four bugs mentioned above. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
