[Bug 17563] Backlinks output format changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=17563 Roan Kattouw roan.katt...@home.nl changed: What|Removed |Added CC||roan.katt...@home.nl Status|NEW |RESOLVED Resolution||FIXED --- Comment #5 from Roan Kattouw roan.katt...@home.nl 2009-02-19 21:55:57 UTC --- (In reply to comment #1) Created an attachment (id=5830) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=5830) [details] Patch against r47478 to fix the issue Applied verbatim in r47514. (In reply to comment #2) It's considered good form to separate whitespace/code formatting and actual code changes when constructing patches. If the whitespace changes are completely unrelated, that's definitely true. This case, where an if() is added and the statements inside it are indented and changed is kind of a corner case. I decided to commit the whole thing in one go, but having a patch without whitespace changes certainly made review clearer. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17563] Backlinks output format changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=17563 Brad Jorsch b-jor...@northwestern.edu changed: What|Removed |Added CC||b-jor...@northwestern.edu Keywords||patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17563] Backlinks output format changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=17563 --- Comment #2 from Edward Z. Yang edwardzy...@thewritingpot.com 2009-02-19 03:03:17 UTC --- It's considered good form to separate whitespace/code formatting and actual code changes when constructing patches. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17563] Backlinks output format changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=17563 --- Comment #3 from Brad Jorsch b-jor...@northwestern.edu 2009-02-19 03:05:57 UTC --- Created an attachment (id=5831) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=5831) The requested patch with b0rken indentation Well, if you really want a patch that has b0rken indentation just so a followup can fix it... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17563] Backlinks output format changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=17563 --- Comment #4 from Brad Jorsch b-jor...@northwestern.edu 2009-02-19 03:08:45 UTC --- Created an attachment (id=5832) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=5832) The requested patch to fix the whitespace from the previous patch And here's the followup to fix the b0rken indentation. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
