[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 Rob Lanphier changed: What|Removed |Added Keywords||performance CC||aschulz4...@gmail.com, ||ro...@wikimedia.org AssignedTo|tstarl...@wikimedia.org |wikibugs-l@lists.wikimedia. ||org --- Comment #22 from Rob Lanphier 2012-11-01 00:41:04 UTC --- Adding performance keyword, and removing Tim since he's not specifically looking at this. Aaron Schulz may have an idea or two about where we should go with this. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #21 from Sergey Chernyshev 2012-03-02 07:26:22 UTC --- Actually, I'm looking at render times and not on load events. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #20 from Bawolff 2012-03-02 01:47:57 UTC --- (In reply to comment #19) > It's been 3 years already, but Hillary is still very slow: > http://www.webpagetest.org/result/120302_AS_8bd3281d5ad4e661f4a2ad91d0a006b9/ > > Second run is not significantly more efficient then firs one: > http://www.webpagetest.org/video/compare.php?tests=120302_AS_8bd3281d5ad4e661f4a2ad91d0a006b9-r:1-c:0,120302_AS_8bd3281d5ad4e661f4a2ad91d0a006b9-r:1-c:1 Well second run being almost same speed is mostly due to counting ajax from the banner load. If you discount the ajax, it'd be roughly 6.2 seconds vs 5.5 seconds. If you don't count one image that took insanely long to return a 304 (which could just be a rare occurrence. Or it could be common place, I don't really know), the comparision becomes 6.2 seconds vs 3.6 seconds. Hence the speedup by fixing this bug might not be as much as that test would lead you to believe (It is still probably something that is fairy significant though, assuming it can be done effectively) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #19 from Sergey Chernyshev 2012-03-02 00:24:58 UTC --- It's been 3 years already, but Hillary is still very slow: http://www.webpagetest.org/result/120302_AS_8bd3281d5ad4e661f4a2ad91d0a006b9/ Second run is not significantly more efficient then firs one: http://www.webpagetest.org/video/compare.php?tests=120302_AS_8bd3281d5ad4e661f4a2ad91d0a006b9-r:1-c:0,120302_AS_8bd3281d5ad4e661f4a2ad91d0a006b9-r:1-c:1 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #18 from Sergey Chernyshev 2011-12-22 15:52:50 UTC --- Glad you guys are on it - I don't think I can dig into the guts of MW again to get it working right, but Tim is correct, it's not much code, just simple stuff. Still, if you can use real or pseudo-folders for file names, that would be even better (query strings might not be as good in terms of caches like your Squids and external caches too). BTW, old way and new way can co-exists if there are worries about some instances not being able to support remote repos - all you need to do is set up infinite expires only on versioned URLs and keep regular URLs intact. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #17 from Tim Starling 2011-12-22 10:24:33 UTC --- It doesn't make any difference to me whether or not the patch is updated. There's not a significant amount of code review here, it's mostly about the idea. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 Sumana Harihareswara changed: What|Removed |Added Keywords|need-review |reviewed --- Comment #16 from Sumana Harihareswara 2011-12-22 05:50:06 UTC --- Sergey, I'm sorry, but because so much time has passed since you submitted your patch, trunk has changed and your patch no longer applies cleanly. If the problem's still happening, would you mind updating it and then letting me know? I'll then get a reviewer for it. Thanks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 Sumana Harihareswara changed: What|Removed |Added Keywords||need-review CC||suma...@panix.com --- Comment #15 from Sumana Harihareswara 2011-11-10 06:57:33 UTC --- Adding the need-review keyword to indicate that this patch still needs to be reviewed. Thanks for the patch and sorry for the wait, Sergey. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #14 from Sergey Chernyshev 2011-02-26 18:58:01 UTC --- Basically, there are a few ways to get versions: - from asset itself - ideally crc32/md5 of content (it's actually pretty fast) - or modification time (which is not very good) - from meta-data (in case of MW, it's file revision number) Ideally, it should be part of the file name, e.g. http://upload.wikimedia.org/wikipedia/commons/thumb/e/e0/Hillary_Rodham_Clinton_Signature.svg/rev125/128px-Hillary_Rodham_Clinton_Signature.svg.png Notice "rev125" between last two slashes. It can be a real folder if you prefer to keep old files or just pseudo-folder which can only be used for cache busting. Cache busting is a must as we have assets infinitely stored in all possible caches, not only in SQuid. Don't know if you need to tell SQuid to clean old URLs or they'll be just LRU-ed later. BTW, all this goes for skin files as well - it should probably be done differently though - as build script or post-commit hook or something like SVN-Assets tool that checks repository revision or hash of the file and generates file names accordingly. Sergey -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 Platonides changed: What|Removed |Added CC||russnel...@gmail.com --- Comment #13 from Platonides 2011-02-26 18:05:28 UTC --- No, it's not a problem for wikimedia since it is -for now- nfs mounted. It is a problem for people using us as a remote repository. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #12 from Sergey Chernyshev 2011-02-25 19:47:29 UTC --- I think last time this was discussed there was another issue - that you guys have remote repository with static assets (uploads.wikimedia.org) while smaller MW installs can use local system to determine the version number. In any case, it's worth implementing in both cases. Sergey -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #11 from Aryeh Gregor 2011-02-25 18:55:56 UTC --- This needs to be reviewed by someone who understands our Squid setup, like Tim or Brion. I don't think it needs a config option, it should just always be enabled, but we need to make sure the right Squid URLs are purged for it to work on Wikimedia. You're right that the status quo is unreasonable. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #10 from Sergey Chernyshev 2011-02-25 18:49:31 UTC --- It's been 2 years since I provided initial patch, but Hillary Clinton still sends 304s for static assets: http://www.webpagetest.org/result/110225_EY_5e420956c8cf54450c47902cc4e82be0/1/details/cached/ You're loosing user experience and traffic. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #9 from Sergey Chernyshev 2009-12-10 15:46:02 UTC --- Just to illustrate results, here's the test for TechPresentations with this patch applied (it uses local repository): http://www.webpagetest.org/result/091210_3H74/ -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #8 from Sergey Chernyshev 2009-05-15 22:27:44 UTC --- Not related to the solution but useful to measure future performance optimizations: http://www.showslow.com/details/?url=http%3A%2F%2Fen.wikipedia.org%2Fwiki%2FHillary_Clinton -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #7 from Sergey Chernyshev 2009-04-10 16:20:54 UTC --- So what do we do with this? Can this patch be localized so that stores that can benefit from this could utilize this feature? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #6 from ^demon 2009-02-20 17:13:06 UTC --- (In reply to comment #5) > > Are pages using images on remote-repos correctly purged on image reupload? > > Nope, which is an issue to consider. There's not currently any registry of > remote use, so the wiki doesn't know who to send purges to. (This would not be > too hard to implement internally for DB-based repos so Commons could update > the > other Wikimedia sites, but would be much trickier for third-party sites using > us via an API repo). > Which unless we had a dedicated action=repo or similar, the API has no way of distinguishing between normal API requests and a request to act as a repo. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #5 from Brion Vibber 2009-02-20 00:09:28 UTC --- > Does Squid currently get purged on image reupload? Currently the plain page view URL does get purged from local Squids, however any *client* that has cached the image doesn't get any such notification. So, either the browser has to go back to hit the server every time it shows it to check if it's changed (slow!), or it speculatively caches it for some amount of time with the risk of showing an outdated version. You can see this effect when you upload a new version of an image and see the old one sitting there on the File: page until you refresh. Changing the URL with a timestamp would mean that any page which has been updated will use the updated URL, giving you the updated image version when you view it. > Are pages using images on remote-repos correctly purged on image reupload? Nope, which is an issue to consider. There's not currently any registry of remote use, so the wiki doesn't know who to send purges to. (This would not be too hard to implement internally for DB-based repos so Commons could update the other Wikimedia sites, but would be much trickier for third-party sites using us via an API repo). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 Platonides changed: What|Removed |Added CC||platoni...@gmail.com --- Comment #4 from Platonides 2009-02-20 00:01:21 UTC --- Will squids purge File:Foo.jpg?timestamp=1970010100 entry when Foo.jpg is reuploaded? Are pages using images on remote-repos correctly purged on image reupload? (I think the problems of bug 1394 complicate it) Infinite expiry images plus squids serving pages pointing to old images... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 Aryeh Gregor changed: What|Removed |Added CC||simetrical+wikib...@gmail.co ||m --- Comment #3 from Aryeh Gregor 2009-02-19 23:23:18 UTC --- Does Squid currently get purged on image reupload? I suppose it must, to deal with image links that have no size specified. I had always assumed Squid is why we didn't change image URLs, but on reflection, it seems unlikely to be a big deal to do such purges occasionally. If this works with Squid and file cache, it should probably be on by default. (Why doesn't file cache hook into Squid's purge mechanism?) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 Brion Vibber changed: What|Removed |Added CC||br...@wikimedia.org AssignedTo|wikibugs- |tstarl...@wikimedia.org |l...@lists.wikimedia.org | --- Comment #2 from Brion Vibber 2009-02-19 22:51:22 UTC --- Spiffy! Offhand looks good, though would want to double-check there's no conflicts with remote repos and the on-demand thumbnailing. Tim, can you take a peek at this today and see if there's any issues there? Thanks! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17577] Images can't have far future expires
https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 --- Comment #1 from Sergey Chernyshev 2009-02-19 22:48:58 UTC --- Yep, patch doesn't include web server configuration for expiration headers. Simple .htaccess like can be put into images/ folder (if Apache has AllowOverride Indexes for it): ExpiresActive on ExpiresDefault A2592 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
