[Bug 17617] HTML tweaks / Clean up ImagePage.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=17617 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Attachment #5967 is|0 |1 obsolete|| --- Comment #7 from Umherirrender umherirrender_de...@web.de 2009-03-28 13:51:57 UTC --- Created an attachment (id=5973) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=5973) new patch for HTML tweaks on ImagePage.php I have download the php-Script from http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/ImagePage.php?revision=48951view=markuppathrev=48957 Open with [[WinMerge]], make the change and create a unified patch and attached them I do not know it was a good idee but you can find the source on my sandbox under http://de.wikipedia.org/w/index.php?action=editoldid=58412452uselang=en (diff: http://de.wikipedia.org/w/index.php?diff=58412452oldid=58412402uselang=en) I hope you can work with that. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17617] HTML tweaks / Clean up ImagePage.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=17617 ^demon innocentkil...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #8 from ^demon innocentkil...@gmail.com 2009-03-28 16:41:16 UTC --- Awesome. Done in r48967. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17617] HTML tweaks / Clean up ImagePage.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=17617 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Attachment #5854 is|0 |1 obsolete|| --- Comment #4 from Umherirrender umherirrender_de...@web.de 2009-03-27 18:37:20 UTC --- Created an attachment (id=5967) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=5967) new patch with using quots for atts I hope the new patch is better and can used in the way you want used it. I had not work with patch before. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17617] HTML tweaks / Clean up ImagePage.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=17617 Patrick W. p...@borntolaugh.de changed: What|Removed |Added CC||p...@borntolaugh.de --- Comment #5 from Patrick W. p...@borntolaugh.de 2009-03-27 18:45:37 UTC --- Sorry, but I don't like your patch. You don't need to use always the same quote-style. You can mix them and by that save a lot escapes, which makes the code a lot more readable. Example (and that is completely fine): $wgOut-addHTML( 'div id=shared-image-desc' . $this-mExtraDescription . /div\n ); -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17617] HTML tweaks / Clean up ImagePage.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=17617 --- Comment #6 from ^demon innocentkil...@gmail.com 2009-03-27 19:26:18 UTC --- Agree with Patrick. Also, I'm still getting the mis-matched chunks error. Are you diff'ing against trunk? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17617] HTML tweaks / Clean up ImagePage.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=17617 ^demon innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com --- Comment #3 from ^demon innocentkil...@gmail.com 2009-03-19 18:32:03 UTC --- Please resubmit without changing tag attr= to tag attr=''. We generally use the former and changing these is useless. Also, patch does not apply, I get a mis-smatched chunks error. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17617] HTML tweaks / Clean up ImagePage.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=17617 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Summary|Clean up imagePage.php |HTML tweaks / Clean up ||ImagePage.php -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
