[Bug 20040] output of categorytree generates secure paths in rare cases.

2010-10-17 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=20040

--- Comment #10 from Platonides  2010-10-17 17:29:17 UTC 
---
Thanks. Done in r74903.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20040] output of categorytree generates secure paths in rare cases.

2010-10-17 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=20040

--- Comment #9 from Derk-Jan Hartman  2010-10-17 14:51:31 
UTC ---
I guess $wgContLang->getExtraHashOptions (for variant) and $wgRenderHashAppend
(for secure) combined should do the trick. If you think that is better, then
you should go right ahead.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20040] output of categorytree generates secure paths in rare cases.

2010-10-17 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=20040

--- Comment #8 from Platonides  2010-10-17 14:21:12 UTC 
---
$wgContLang->getExtraHashOptions() contain the preferred language variant.

I'm not sure which CR would be appropiate for that. It was right back then.
Now, I am trying to deprecate getPageRenderingHash() per r70783#c9984.

I think I will change it.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20040] output of categorytree generates secure paths in rare cases.

2010-10-17 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=20040

--- Comment #7 from Derk-Jan Hartman  2010-10-17 11:27:00 
UTC ---
Variant options means zh-tw vs. zh-hs etc. Tim told me to use
getPageRenderingHash() back then. I'm not sure if $wgRenderHashAppend takes
user variants into account. Perhaps you should raise this in code comments if
you really want it to be reviewed again ?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20040] output of categorytree generates secure paths in rare cases.

2010-10-10 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=20040

--- Comment #6 from Platonides  2010-10-10 14:18:26 UTC 
---
$wgContLang->getExtraHashOptions() . $wgRenderHashAppend would be enough,
right?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20040] output of categorytree generates secure paths in rare cases.

2010-10-10 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=20040

Platonides  changed:

   What|Removed |Added

 CC||platoni...@gmail.com

--- Comment #5 from Platonides  2010-10-10 14:12:59 UTC 
---
What do you mean with 'variant options'? $wgLang->getCode() ?

For secure, just $wgRenderHashAppend would be enough.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20040] output of categorytree generates secure paths in rare cases.

2010-04-06 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=20040

Daniel Kinzler  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||brightb...@gmail.com
 Resolution||FIXED

--- Comment #4 from Daniel Kinzler  2010-04-06 21:47:15 
UTC ---
fixed in r64672. thanks Derk-Jan.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20040] output of categorytree generates secure paths in rare cases.

2010-03-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=20040

Derk-Jan Hartman  changed:

   What|Removed |Added

   Keywords||need-review, patch

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20040] output of categorytree generates secure paths in rare cases.

2010-03-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=20040

--- Comment #3 from Derk-Jan Hartman  2010-03-13 01:53:46 
CET ---
Created an attachment (id=7194)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7194)
expand the memcached key with variant/http values with getPageRenderingHash

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20040] output of categorytree generates secure paths in rare cases.

2010-03-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=20040

--- Comment #2 from Derk-Jan Hartman  2010-03-13 01:06:17 
CET ---
In function ajax() of CategoryTree/CategoryTreeFunctions.php 

# Retrieve page_touched for the category
$dbkey = $title->getDBkey();

$mckey = "$wgDBname:categorytree(" . $this->getOptionsAsCacheKey( $depth ) .
"):$dbkey";

Since the ajax results differ in secure vs. non-secure (localURL layout
differs), the memcached is incorrectly shared between these ajax results, thus
causing this problem

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20040] output of categorytree generates secure paths in rare cases.

2009-08-02 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=20040


Chad H.  changed:

   What|Removed |Added

 CC||innocentkil...@gmail.com




--- Comment #1 from Chad H.   2009-08-02 14:42:51 UTC 
---
Confirmed in Monobook with Chrome 2.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l