[Bug 21991] Move common query parameter (uc, rc) validation to ApiBase/Similar

2010-01-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=21991





--- Comment #1 from Reedy s...@reedyboy.net  2010-01-03 13:52:59 UTC ---
Oh Roan, I should've really asked.. Which way do we want to move to?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 21991] Move common query parameter (uc, rc) validation to ApiBase/Similar

2010-01-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=21991


Roan Kattouw roan.katt...@gmail.com changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com




--- Comment #2 from Roan Kattouw roan.katt...@gmail.com  2010-01-03 16:40:16 
UTC ---
(In reply to comment #1)
 Oh Roan, I should've really asked.. Which way do we want to move to?
 

Ideally, the 'user' parameter type would trigger validation code in ApiBase
that is relatively relaxed and validates rc-style (allow IPs, throw error on
invalid stuff, don't mess with namespace prefixes so rcuser=Talk:Foo means
User:Talk:Foo and rcuser=User:Foo means User:User:Foo ; the latter is
presumably invalid). Logevents can then enforce the user-must-exist criterion
by just checking $user-isLoggedIn() and throwing an error if that returns
false.

Disclaimer: I don't know offhand which validation function does this. I think
it's User::getCanonicalName() or a related function; see
http://svn.wikimedia.org/doc/classUser.html


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l