[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584 Tyler Romeo tylerro...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com, ||matma@gmail.com Component|Vector |Vector Product|MediaWiki extensions|MediaWiki skins -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584 Dmitriy Sintsov c...@uniyar.ac.ru changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added CC||s.mazel...@xs4all.nl --- Comment #9 from Siebrand s.mazel...@xs4all.nl 2011-08-03 06:46:45 UTC --- Is this still relevant, or Oh so fixed? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584 Krinkle krinklem...@gmail.com changed: What|Removed |Added Component|Javascript |Vector Version|unspecified |any AssignedTo|d...@ucsc.edu |tpars...@wikimedia.org Product|MediaWiki |MediaWiki extensions -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584
Roan Kattouw roan.katt...@gmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
CC||roan.katt...@gmail.com
Resolution||WORKSFORME
--- Comment #1 from Roan Kattouw roan.katt...@gmail.com 2010-02-19 11:59:21
UTC ---
Works for me with phase3 and UsabilityInitiative (both at r62695):
function blah() { die(blah); }
require_once($IP/../extensions/ParserFunctions/ParserFunctions.php);
require_once($IP/../extensions/UsabilityInitiative/Vector/Vector.php);
require_once($IP/../extensions/UsabilityInitiative/WikiEditor/WikiEditor.php);
require_once($IP/../extensions/UsabilityInitiative/OptIn/OptIn.php);
require_once($IP/../extensions/UsabilityInitiative/ClickTracking/ClickTracking.php);
$wgHooks['BeforePageDisplay'][] = 'blah';
Outputs blah
This could be a bug in js2-work, or simply a bug in your BeforePageDisplay hook
function (sure you got the name right? Did you try adding die(blah) at the
beginning?)
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584 Dmitriy c...@uniyar.ac.ru changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME | --- Comment #2 from Dmitriy c...@uniyar.ac.ru 2010-02-19 15:06:29 UTC --- Roan, could you try with js2-work, please? Or, perhaps your area of development is unrelated to js2-work, then, perhaps someone else can try it? My extension works at two different installations (win,linux) with 1.15.1, so that should not be a simple typo. Also, the extension works when I comment out the Vector enhancement line. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584 --- Comment #3 from Dmitriy c...@uniyar.ac.ru 2010-02-19 15:14:06 UTC --- Here is the link to my unreleased extension: http://mediawiki.narod.ru/EditConflict_0.4.1.tgz there is no typo in hook call, indeed it works for long time. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584 --- Comment #4 from Dmitriy c...@uniyar.ac.ru 2010-02-19 15:23:43 UTC --- There is no hook $wgHooks['EditPageMergeChanges'][] = 'EditConflict::doEditConflict'; currently defined in MediaWiki core, but that is unrelated, because that hook is only optional (via the simple patch of EditPage.php) and the extension works without patching of core. (The core patching is only an enhancement, not an requirement to run my extension). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584 --- Comment #5 from Dmitriy c...@uniyar.ac.ru 2010-02-19 17:05:00 UTC --- Even, http://mediawiki.narod.ru/EditConflict_0.4.2.tgz fixed some small bugs. Although, it was working with MediaWiki 1.15.1 and a clean js2-work r62695 without UsabilityInitiative + Vector enhancement, too (I've turned on most of another enhancements according to UsabilityInitiative installation instructions, but it was the Vector enhancement which prevented 'BeforePageDisplay' to be called). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||tpars...@wikimedia.org Component|Vector Skin |Javascript AssignedTo|tpars...@wikimedia.org |d...@ucsc.edu --- Comment #6 from Roan Kattouw roan.katt...@gmail.com 2010-02-19 20:42:48 UTC --- Could you try with trunk instead of js2-work? If the very same thing works in trunk but is broken in js2-work, it's definitely not Vector's fault. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584 --- Comment #7 from Michael Dale d...@ucsc.edu 2010-02-19 21:18:58 UTC --- I have not merged updates from trunk into js2-work for sometime. Dmitriy why are you using js2-work branch? ( that branch is under development with only really only the /js part being maintained ) You should use trunk and wait until the updated javascript api stuff makes its way into trunk before worrying about future proofing your extension. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22584] 'BeforePageDisplay' hook is not being called in Extension:UsabilityInitiative r62695 with Vector enhancements turned on
https://bugzilla.wikimedia.org/show_bug.cgi?id=22584 --- Comment #8 from Dmitriy c...@uniyar.ac.ru 2010-02-20 02:02:29 UTC --- Allright, I'll try the trunk. I've thought that more visual enhancements will be available with js2-work (such as AJAX uploads and so on). I haven't studied last year changes in detail, but certainly that is a bigger than usual step between the core versions (when moving from 1.15.1). Michael, if you are going to merge changes someday, you may close this bug. I wonder if some kind of automatical test (phpunit?) especially for hooks can be made. Perhaps, a test extension which would make sure that no hook calls are missed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
