[Bug 22905] Parser.php doMagicLinks() mishandle abbr tag

2010-07-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22905

S. McCandlish smccandl...@gmail.com changed:

   What|Removed |Added

 CC||smccandl...@gmail.com
 Blocks|671 |

--- Comment #6 from S. McCandlish smccandl...@gmail.com 2010-07-24 18:22:41 
UTC ---
Since this is fixed, removing Bug #617 as a blocks dependency.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22905] Parser.php doMagicLinks() mishandle abbr tag

2010-07-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22905

--- Comment #7 from S. McCandlish smccandl...@gmail.com 2010-07-24 18:23:52 
UTC ---
Woops, typo. Corrected: Since this is fixed, removing Bug #671 as a blocks
dependency.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22905] Parser.php doMagicLinks() mishandle abbr tag

2010-03-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22905

Aryeh Gregor simetrical+wikib...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #4 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-03-24 
13:44:13 UTC ---
Committed a modified version in r64113.  I went with (a[ \t\r\n].*?/a) in
the end, matching the HTML5 spec as far as I'm reading it:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tokenization.html#before-attribute-name-state
 Thanks for the patch!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22905] Parser.php doMagicLinks() mishandle abbr tag

2010-03-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22905

--- Comment #5 from Solitarius mediaw...@soli.ca 2010-03-25 05:27:38 UTC ---
Thanks you Aryeh. Merci!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22905] Parser.php doMagicLinks() mishandle abbr tag

2010-03-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22905

Solitarius mediaw...@soli.ca changed:

   What|Removed |Added

 Blocks||671

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22905] Parser.php doMagicLinks() mishandle abbr tag

2010-03-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22905

Aryeh Gregor simetrical+wikib...@gmail.com changed:

   What|Removed |Added

 CC||simetrical+wikib...@gmail.c
   ||om

--- Comment #2 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-03-23 
16:41:01 UTC ---
1) Do you have a test case that demonstrates the problem?  I.e., what's some
markup that parses incorrectly because of this bug?

2) Your change doesn't seem quite right -- whitespace other than a simple space
would be valid HTML here (although I haven't looked closely enough to see if it
would actually be possible at this stage in the parsing).  I would suggest
(a[^a-z0-9].*?/a).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22905] Parser.php doMagicLinks() mishandle abbr tag

2010-03-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22905

--- Comment #3 from Solitarius mediaw...@soli.ca 2010-03-24 04:17:26 UTC ---

1) The wiki markup bellow get incorrectly parsed. You can also check
[[User:GuillaumeBeaudoin]] for more example.

abbr(fr)/abbr ISBN 2753300917 [http://bit.ly/bZAjtg La méthode Google]

The abbr tag is extensively used on the French wikipedia and the issue have
been first found on [[fr:Wikipedia]] by [[fr:User:Manu1400]].

2) You're right, a tab or any whitespace other than a simple space would not
make good on my regular expression. We could use \s for any whitespaces (option
A). The one likes what you've proposed (option B).

Option A - a[\w].*?/a
Option B - a[^a-zA-Z0-9].*?/a
Option C - a[^[:alnum:]].*?/a

Altough, I'm not sure what capital letters would do.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22905] Parser.php doMagicLinks() mishandle abbr tag

2010-03-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22905

Solitarius mediaw...@soli.ca changed:

   What|Removed |Added

URL||http://en.wikipedia.org/wik
   ||i/User:GuillaumeBeaudoin

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22905] Parser.php doMagicLinks() mishandle abbr tag

2010-03-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22905

--- Comment #1 from Solitarius mediaw...@soli.ca 2010-03-20 05:13:01 UTC ---
Created an attachment (id=7235)
 -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7235)
regular expression modification

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22905] Parser.php doMagicLinks() mishandle abbr tag

2010-03-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22905

Solitarius mediaw...@soli.ca changed:

   What|Removed |Added

   Keywords||patch

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22905] Parser.php doMagicLinks() mishandle abbr tag

2010-03-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22905

p858snake p858sn...@yahoo.com.au changed:

   What|Removed |Added

   Keywords||need-review
 CC||p858sn...@yahoo.com.au

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l