[Bug 22922] Aborting a block using BlockIp hook shows hookaborted on the block form
https://bugzilla.wikimedia.org/show_bug.cgi?id=22922 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Blocks||35331 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22922] Aborting a block using BlockIp hook shows hookaborted on the block form
https://bugzilla.wikimedia.org/show_bug.cgi?id=22922 --- Comment #2 from nx.devn...@gmail.com 2011-10-13 18:10:16 UTC --- It's slightly better in that it displays the message The modification you tried to make was aborted by an extension hook. instead of hookabort, but it still doesn't allow the extension to customize that message, instead the extension's error message is outputted at the top and the title of the page changes to internal error. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22922] Aborting a block using BlockIp hook shows hookaborted on the block form
https://bugzilla.wikimedia.org/show_bug.cgi?id=22922 --- Comment #3 from nx.devn...@gmail.com 2011-10-13 18:15:51 UTC --- Created attachment 9228 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9228 Quick and dirty hack Here's a patch to show you a rough idea of what I'd like. Instead of returning a string, the extension can set the third parameter of the blockip hook and return false. The problem with this patch though is that it requires error to be a message key. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22922] Aborting a block using BlockIp hook shows hookaborted on the block form
https://bugzilla.wikimedia.org/show_bug.cgi?id=22922
--- Comment #4 from nx.devn...@gmail.com 2011-10-13 18:17:01 UTC ---
And the extension to test this:
?php
if ( !defined( 'MEDIAWIKI' ) ) {
exit;
}
$wgHooks['BlockIp'][] = 'BlockIpTest';
$wgExtensionMessagesFiles['PageList'] = dirname( __FILE__ ) .
'/blocktest.i18n.php';
function BlockIpTest( $ban, $user, $error ) {
$error = 'test-abort';
return false;
}
and blocktest.i18n.php is:
?php
$messages = array();
$messages['en'] = array(
'test-abort' = 'Testing block abort',
);
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22922] Aborting a block using BlockIp hook shows hookaborted on the block form
https://bugzilla.wikimedia.org/show_bug.cgi?id=22922 --- Comment #1 from Happy-melon happy.melon.w...@gmail.com 2011-06-27 23:00:04 UTC --- Can you confirm whether this still occurs in trunk? The blocking system has been completely rewritten since 1.15. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22922] Aborting a block using BlockIp hook shows hookaborted on the block form
https://bugzilla.wikimedia.org/show_bug.cgi?id=22922 Reedy s...@reedyboy.net changed: What|Removed |Added Blocks||14261 Depends on|14261 | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22922] Aborting a block using BlockIp hook shows hookaborted on the block form
https://bugzilla.wikimedia.org/show_bug.cgi?id=22922 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added CC||m...@everybody.org Depends on||14261 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22922] Aborting a block using BlockIp hook shows hookaborted on the block form
https://bugzilla.wikimedia.org/show_bug.cgi?id=22922 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Version|1.15.1 |1.15.x -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
