[Bug 23075] Media transform default width in gallery is incorrect

2010-04-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=23075

Derk-Jan Hartman  changed:

   What|Removed |Added

   Keywords||need-review, patch

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 23075] Media transform default width in gallery is incorrect

2010-04-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=23075

--- Comment #2 from Derk-Jan Hartman  2010-04-07 02:04:43 
CEST ---
Created an attachment (id=7273)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7273)
Proposed changes to MediaTransformError

This patch changes the minimum size of a MediaTransformError to 120px, which
makes sure it will at least fit galleries. Any smaller and likely it would
become unreadable, so keep the ugly in those cases.

The patch also changes the message from a table to a div, because there is no
real need to use a table here. I have added "display:inline-block" to the css
to make it behave almost exactly as an img or table element would (This might
be important for [[File:image.gif|180px]], where no other framing is provided.)

I have no strong opinion on the usage of inline-block, I'll leave it up for
debate.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 23075] Media transform default width in gallery is incorrect

2010-04-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=23075

--- Comment #1 from Derk-Jan Hartman  2010-04-07 01:47:44 
CEST ---
It seems the smallest possible thumbs with this error are 180 atm. I'm not sure
if we want to keep that, because it looks rather ugly
http://commons.wikimedia.org/wiki/Category:Animations_of_geometry


from: includes/media/MediaTransformOutput.php
max( isset( $params['width']  ) ? $params['width']  : 0, 180 )
max( isset( $params['height'] ) ? $params['height'] : 0, 180 )

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l