[Bug 23330] DatabaseBase::selectSQLText() vs EXPLAIN
https://bugzilla.wikimedia.org/show_bug.cgi?id=23330 Ryan Biesemeyer changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #5 from Ryan Biesemeyer 2010-04-26 20:33:55 UTC --- Closing and changing this to "won't fix". MaxSem's solution works well and doesn't touch as much code, so I'll implement it. Thanks. -yaauie -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23330] DatabaseBase::selectSQLText() vs EXPLAIN
https://bugzilla.wikimedia.org/show_bug.cgi?id=23330 Ryan Biesemeyer changed: What|Removed |Added Attachment #7333|0 |1 is obsolete|| --- Comment #4 from Ryan Biesemeyer 2010-04-26 19:10:01 UTC --- Created an attachment (id=7334) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7334) Move EXPLAIN functionality to child classes Also touches DatabaseOracle and DatabasePostgres, fixes syntax error. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23330] DatabaseBase::selectSQLText() vs EXPLAIN
https://bugzilla.wikimedia.org/show_bug.cgi?id=23330 --- Comment #3 from Max Semenik 2010-04-26 19:06:29 UTC --- To reduce code duplication, instead of overriding it in several classes, just rewrite it in DatabaseMssql, something like http://pastebin.com/QwrxLc3E -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23330] DatabaseBase::selectSQLText() vs EXPLAIN
https://bugzilla.wikimedia.org/show_bug.cgi?id=23330 Max Semenik changed: What|Removed |Added Keywords|reviewed| --- Comment #2 from Max Semenik 2010-04-26 18:55:11 UTC --- EXPLAIN is also used by PG and Oracle, this patch will apparently break them. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23330] DatabaseBase::selectSQLText() vs EXPLAIN
https://bugzilla.wikimedia.org/show_bug.cgi?id=23330 Roan Kattouw changed: What|Removed |Added Keywords||reviewed CC||roan.katt...@gmail.com --- Comment #1 from Roan Kattouw 2010-04-26 18:51:57 UTC --- Provided that no other DBMSes use this, feel free to go ahead and commit this. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23330] DatabaseBase::selectSQLText() vs EXPLAIN
https://bugzilla.wikimedia.org/show_bug.cgi?id=23330 Roan Kattouw changed: What|Removed |Added Attachment #7333|application/octet-stream|text/plain mime type|| Attachment #7333|0 |1 is patch|| -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
