[Bug 23733] Add IDs to messages used on css/js pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=23733 --- Comment #6 from Happy-melon happy-me...@live.com 2010-06-03 09:15:52 UTC --- (In reply to comment #5) (In reply to comment #3) IDs should be used to identify individual objects; In general yes, but how do you know what is going to appear only once in the future? By making a common-sense judgement about what type of objects they are: namely, warnings which appear in one particular situation and have absolutely no reason to appear more than once per page. In the very unlikely event it becomes multi-present in the future then it can be changed to a class; any scripts accessing it in the assumption that it's singular will need to be updated anyway. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23733] Add IDs to messages used on css/js pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=23733 Raimond Spekking raimond.spekk...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23733] Add IDs to messages used on css/js pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=23733 Niklas Laxström niklas.laxst...@gmail.com changed: What|Removed |Added CC||niklas.laxst...@gmail.com --- Comment #5 from Niklas Laxström niklas.laxst...@gmail.com 2010-06-03 05:19:58 UTC --- (In reply to comment #3) IDs should be used to identify individual objects; In general yes, but how do you know what is going to appear only once in the future? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 23733] Add IDs to messages used on css/js pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=23733 Happy-melon happy-me...@live.com changed: What|Removed |Added Summary|Add classes to messages |Add IDs to messages used on |used on css/js pages|css/js pages --- Comment #3 from Happy-melon happy-me...@live.com 2010-06-01 08:47:32 UTC --- Just because we've been doing it badly in other places doesn't mean we should continue to do so in new code. IDs should be used to identify individual objects; classes should be used where the same styles need to be applied to multiple places in a document or site. That is the paradigm around which the scripts and browsers we use are based: an individual object identified by an ID can be accessed much more efficiently by JS using getElementById(), for instance, while there is no native implementation of getElementsByClass(); we have our own inefficient implementation, but it doesn't work particularly well or have good cross-browser support. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
