[Bug 24700] Update dialog shown when clicking on the special page tab after saving preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=24700 --- Comment #6 from Fomafix 2012-09-11 09:21:46 UTC --- Ok, re-sumit the (potentially outdated) form information by refreshing the page or by browser recovery is a good argument against a simple POST. When a new submit though JavaScript with mw.notify for notification is implemented, most users with JavaScript enabled don't use the browser submit anymore. Of course, a fallback for non-JavaScript must exist. What about a page /w/index.php?title=Special:Preferences&success=1 with just a success message and without the preference settings? So the user has to load /wiki/Special:Preferences again for changing further settings. With this combination it not possible to have unsaved changed settings and a success message on the same screen, which is confusing. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24700] Update dialog shown when clicking on the special page tab after saving preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=24700 Krinkle changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #5 from Krinkle 2012-09-11 02:08:18 UTC --- (In reply to comment #4) > At the moment the form is POSTed to /wiki/Special:Preferences. The server > answers with 302 and redirects to > /wiki/index.php?title=Special:Preferences&success=1 > > The server should answer with the preferences page with success box directly > on > the POST request. No, it should not. This is PRG[1], that is by design and on purpose with a redirect at the end. The resulting page shows the preferences page, which should be a permalink to that. Refreshing manually or by a browser recovery should not re-submit the (potentially outdated) form information. What could be done instead is write a core js module (always loaded) that submits through javascript. That way the submission does not occupy the browser window and the url never has to include "success=1". Instead, the callback handler would put up that message programmatically (probably through mw.notify, while at it). As fallback for non-javascript it can stay as is (though it could be improved). [1] https://en.wikipedia.org/wiki/Post/Redirect/Get -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24700] Update dialog shown when clicking on the special page tab after saving preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=24700 MZMcBride changed: What|Removed |Added Keywords||easy -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24700] Update dialog shown when clicking on the special page tab after saving preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=24700 foma...@googlemail.com changed: What|Removed |Added CC||foma...@googlemail.com --- Comment #4 from foma...@googlemail.com 2011-12-30 20:03:09 UTC --- At the moment the form is POSTed to /wiki/Special:Preferences. The server answers with 302 and redirects to /wiki/index.php?title=Special:Preferences&success=1 The server should answer with the preferences page with success box directly on the POST request. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24700] Update dialog shown when clicking on the special page tab after saving preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=24700 Huji changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #3 from Huji 2010-08-09 06:34:31 UTC --- Reverted with r70746. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24700] Update dialog shown when clicking on the special page tab after saving preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=24700 Huji changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Huji 2010-08-06 19:08:52 UTC --- Fixed with r70585. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24700] Update dialog shown when clicking on the special page tab after saving preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=24700 Huji changed: What|Removed |Added Summary|Bad link after successfully |Update dialog shown when |updating preferences|clicking on the special ||page tab after saving ||preferences -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
