[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 Aaron Schulz jschulz_4...@msn.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #11 from Aaron Schulz jschulz_4...@msn.com 2011-06-26 04:12:59 UTC --- Largely dealt with in r90816. A few APCONDs could perhaps be moved to core though. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 --- Comment #9 from Aaron Schulz jschulz_4...@msn.com 2011-06-25 02:06:46 UTC --- This patch won't apply well at all with SVN (I can tell from the file names) :/ -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 --- Comment #10 from Aaron Schulz jschulz_4...@msn.com 2011-06-25 02:52:48 UTC --- (In reply to comment #9) This patch won't apply well at all with SVN (I can tell from the file names) :/ Nevermind, worked around it. Applied in r90749. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 Aaron Schulz jschulz_4...@msn.com changed: What|Removed |Added Priority|Lowest |Normal -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 --- Comment #8 from Aaron Schulz jschulz_4...@msn.com 2011-06-13 20:56:20 UTC --- (In reply to comment #5) Created attachment 8471 [details] MediaWiki-side patch, updated Patch updated to the latest svn revision. Do you have commit access btw? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 --- Comment #7 from Aaron Schulz jschulz_4...@msn.com 2011-05-22 22:03:18 UTC --- (In reply to comment #4) It can be, if it's needed. Besides, I'm not sure if the way of attaching an autopromotion to a hook was the best idea of mine... It can be useful to only check on certain action for performance reasons. I've looked at the patch diff above, which is fairly sane. I'm thinking this should be committed soon so that a broader audience will look at it. With the AutopromoteCondition hook, there is already a way for extensions to add conditions. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 --- Comment #4 from lampak llam...@gmail.com 2011-04-28 17:24:34 UTC --- It can be, if it's needed. Besides, I'm not sure if the way of attaching an autopromotion to a hook was the best idea of mine... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 lampak llam...@gmail.com changed: What|Removed |Added Attachment #7660|0 |1 is obsolete|| --- Comment #5 from lampak llam...@gmail.com 2011-04-28 21:00:34 UTC --- Created attachment 8471 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8471 MediaWiki-side patch, updated Patch updated to the latest svn revision. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 --- Comment #6 from Chad H. innocentkil...@gmail.com 2011-04-28 21:53:35 UTC --- Should go at the end of the update list under 1.18, not in the middle of the 1.17 list. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 --- Comment #3 from Aaron Schulz jschulz_4...@msn.com 2011-03-22 16:53:01 UTC --- Is this patch still being maintained? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 --- Comment #2 from Aaron Schulz jschulz_4...@msn.com 2010-11-23 21:59:58 UTC --- The user attributes/tally table (flaggedrevs_autopromote) should be in the core too, so that extensions are not adding new tables for every new attribute they want to check. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 lampak llam...@gmail.com changed: What|Removed |Added Blocks||25390 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 Bug 24948 depends on bug 25428, which changed state. Bug 25428 Summary: Autopromotion system should be extended to allow removal of granted groups etc. https://bugzilla.wikimedia.org/show_bug.cgi?id=25428 What|Old Value |New Value Status|NEW |RESOLVED Resolution||DUPLICATE -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 Rob Lanphier ro...@wikimedia.org changed: What|Removed |Added Blocks||25390 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 Rob Lanphier ro...@wikimedia.org changed: What|Removed |Added Keywords||need-review CC||ro...@wikimedia.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 p858snake p858sn...@gmail.com changed: What|Removed |Added Keywords||patch CC||p858sn...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 Aaron Schulz jschulz_4...@msn.com changed: What|Removed |Added Priority|Normal |Lowest -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 --- Comment #1 from lampak llam...@gmail.com 2010-08-30 10:07:57 UTC --- Created attachment 7660 -- https://bugzilla.wikimedia.org/attachment.cgi?id=7660 MediaWiki-side patch (discussion which resulted in filing the bug: http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/49447) I have written the first patch, i.e. the one on MediaWiki core side. The autopromotion can be now done like: $wgHooks['ArticleSaveComplete'][] = array ( 'Autopromote::autopromoteOnceHook', array( 'somegroup' = array(APCOND_EDITCOUNT, 100) ) ); The format of conditions is the same as $wgAutopromote. The differences are: * The group can be removed from a user via Special:UserRights. * The user is not autopromoted to the groups he/she has once belonged to. * The user won't lose the group automatically if he/she no longer meets the criteria. * The Autopromote::autopromoteOnceHook() function can be assigned to any hook so autopromotion is only checked on certain events. The function simply calls a new method User::autopromoteOnce() on $wgUser so if there's such need a custom function may be written. My autopromotion mechanism is separate from $wgAutopromote, though it uses the same format of conditions. And I had to create a new database table: user_former_groups. It's actually a clone of user_groups but stores the groups the user has once belonged to, not necessarily belongs now. I haven't tested if the table is created properly on anything different then MySQL (though it should work on sqlite and postgres because it's actually copy-pasted user_groups). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24948] FlaggedRevs should not reinvent the autopromote wheel
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948 lampak llam...@gmail.com changed: What|Removed |Added Attachment #7660|wgAutopromoteOnce.patch |AutopromoteOnce.patch filename|| -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
