[Bug 26120] CodeReview e-mails (for new comments, follow-up revisions, etc.) should include commit summary of original revision for context

2011-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26120

--- Comment #4 from Reedy s...@reedyboy.net 2011-03-05 19:37:14 UTC ---
r83315 does the followup email message ones...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26120] CodeReview e-mails (for new comments, follow-up revisions, etc.) should include commit summary of original revision for context

2011-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26120

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #5 from Reedy s...@reedyboy.net 2011-03-05 19:41:24 UTC ---
r88316 does the rest

GLHF.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26120] CodeReview e-mails (for new comments, follow-up revisions, etc.) should include commit summary of original revision for context

2011-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26120

--- Comment #6 from MZMcBride b...@mzmcbride.com 2011-03-05 20:02:43 UTC ---
(In reply to comment #5)
 r88316 does the rest
 
 GLHF.

r83316, rather. Thanks, Reedy!

Would it make sense to truncate the commit summary to a certain number of lines
or bytes?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26120] CodeReview e-mails (for new comments, follow-up revisions, etc.) should include commit summary of original revision for context

2011-02-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26120

MZMcBride b...@mzmcbride.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |
Summary|CodeReview e-mails should   |CodeReview e-mails (for new
   |include commit summary  |comments, follow-up
   ||revisions, etc.) should
   ||include commit summary of
   ||original revision for
   ||context

--- Comment #3 from MZMcBride b...@mzmcbride.com 2011-02-12 16:16:21 UTC ---
(In reply to comment #2)
 Since the emails going out now include the revision and the revision being
 followed up, I think this is fixed.

Re-opening this. I'm fairly sure this isn't fixed, but the opening comment is
kind of confusing.

When you get an e-mail about a new comment on a revision, it looks like
something like this:


User Platonides posted a comment on MediaWiki.r70270.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70270#c13834

Comment:

I don't see the need for history either. Why history and not edit, for example?
If any, I would modify whatlinkshere-links so that those links can be created
in MediaWiki namespace.


This is a problematic if you can't remember off-hand what the revision is
about. As time passes, it becomes easier and easier to forget which revisions
you've commented on and why, so the new comments make less sense and require
greater context.

The e-mails should look like something like this instead:


User Platonides posted a comment on MediaWiki.r70270.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70270#c13834
Commit summary: * (bug 24563) Entries on Special:WhatLinksHere now have a link
to their history

New comment:

I don't see the need for history either. Why history and not edit, for example?
If any, I would modify whatlinkshere-links so that those links can be created
in MediaWiki namespace.


This way, you can know what the revision was about, so the comments hopefully
make more sense.

Having commit summary context should apply to follow-up e-mails and new comment
e-mails. I've changed the bug summary to be a bit clearer about this.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l