[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #24 from Krinkle krinklem...@gmail.com 2012-01-09 08:43:30 UTC --- (In reply to comment #23) least part of the software, and fixing this in shared.css would be appropriate. No, it's not. There is no such element by the classname mw-geshi outputted by core. As such styling for those elements simply don't belong in core. Adding a css file and adding it to the top loading stack in trivial, sounds like a good thing to do. However if the font-size is too small, I wonder whether: * What is setting it that low in the first place ? Are there really no CSS rules coming from Geshi ? Perhaps the font-size was hardcoded in local wiki's Geshi.css, in which case the fix is to fix that. * Perhaps it's not specific to anything div.mw-geshi at all, and all we need is to add a rule for pre in general to the Vector skin. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #25 from Erwin Dokter er...@darcoury.nl 2012-01-09 13:30:59 UTC --- There already is a general rule or 'fix' for preformatted text, now annotated, that explains the root of the problem (it's not really a bug, just a side effect of the base font size). See r108142. The problem with GeSHi however is that it injects a Dynamically Generated Stylesheet in the head of every page that uses GeSHI, which re-declares the font for pre to plain 'monospace', negating the 'fix' in commonElements.css. Since the injected CSS loads *after* ResourceLoader has loaded the site/user CSS, the use of !important; is required in any CSS that attempts to fix GeSHI issues. It then loads Geshi.css, so putting the fixes in there is also not an option, as that would make any custamization completely impossible (as it is loaded after user CSS). Moving Geshi.css to the top loading stack would solve the problem only partly; it would still be overridden by the generated CSS, so !important is still required (as the code in common.css does now). I would also solve Geshi.css being loaded multiple times; each lang option for GeSHi generates a new CSS block in the head, including a line that loads Geshi.css. Just look at the source of [[MediaWiki talk:Common.css]] to see what I mean. A complete solution would be to move the GeSHi generated CSS to *above* the top RL modules. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #26 from Erwin Dokter er...@darcoury.nl 2012-01-09 19:46:54 UTC --- Created attachment 9827 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9827 Patch for extensions/SyntaxHighlight_GeSHi/geshi/geshi.php I did some digging through the GeSHi source, and here is a simpler solution; make the generated CSS perform the same 'trick' as core does, namely add a second value for font-family. This will eliminate the need for the current hack in MediaWiki:Common.css. I would still like the entire GeSHi block to be loaded before site/user CSS, so overriding no longer needs !important (but Geshi.css must still be loaded after the generated CSS, realised that a bit too late). So the order would become: 1) Generated GeSHi CSS, 2) MediaWiki:Geshi.css, 3) RL site/user CSS. And also, MW:Geshi.css should be loaded only once. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #27 from Happy-melon happy.melon.w...@gmail.com 2012-01-09 19:58:32 UTC --- (In reply to comment #26) Created attachment 9827 [details] Patch for extensions/SyntaxHighlight_GeSHi/geshi/geshi.php Is that one of the GeSHi files that's linked via an SVN external? That is, is it part of GeSHi core? If so we'll need to upstream it. It looks to me like that patch ought to be completely harmless for other users, is that the case? Can you summarise why it has the effect that it does? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #28 from Krinkle krinklem...@gmail.com 2012-01-09 20:09:57 UTC --- (In reply to comment #25) There already is a general rule or 'fix' for preformatted text, now annotated, that explains the root of the problem (it's not really a bug, just a side effect of the base font size). See r108142. Wrong rev link ? (In reply to comment #25) The problem with GeSHi however is that it injects a Dynamically Generated Stylesheet in the head of every page that uses GeSHI, which re-declares the font for pre to plain 'monospace', negating the 'fix' in commonElements.css. Since the injected CSS loads *after* ResourceLoader has loaded the site/user CSS, the use of !important; is required in any CSS that attempts to fix GeSHI issues. This loading order is simply wrong. We should let the output become a module and actually make it use ResourceLoader. That'll slim the page weight, be better cacheable, and solves the order problem. (In reply to comment #25) Moving Geshi.css to the top loading stack would solve the problem only partly; it would still be overridden by the generated CSS, so !important is still required (as the code in common.css does now). I didn't mean moving Geshi.css to the top. I meant, if there is no stylesheet to put this style in, we can create a _new_ module with a new stylesheet and put that in there and load it in the top. (In reply to comment #25) I would also solve Geshi.css being loaded multiple times; each lang option for GeSHi generates a new CSS block in the head, including a line that loads Geshi.css. Just look at the source of [[MediaWiki talk:Common.css]] to see what I mean. I see nothing obvious on that wiki page, can you be more specific ? (In reply to comment #25) A complete solution would be to move the GeSHi generated CSS to *above* the top RL modules. I'd recommend letting actually BE a module, give it position=top and load it as any other module. Same result. (In reply to comment #26) Created attachment 9827 [details] Patch for extensions/SyntaxHighlight_GeSHi/geshi/geshi.php Is that one of the GeSHi files that's linked via an SVN external? That is, is it part of GeSHi core? If so we'll need to upstream it. Yup. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204
Erwin Dokter er...@darcoury.nl changed:
What|Removed |Added
Keywords|need-review, patch |
--- Comment #23 from Erwin Dokter er...@darcoury.nl 2012-01-07 12:10:05 UTC
---
If I am to understand Happy-melon correctly, GeSHi is not part of core.
However, if it is part of the distribution package, I do consider it to at
least part of the software, and fixing this in shared.css would be appropriate.
As GeSHi does not have an associated CSS file, and MediaWiki:GeSHi.css loads
too late, I can't see another alternative.
Otherwise, the only alternative is to recommend each project to put the
following in their Common.css:
/* Fix so syntaxhighlight tags and .css and .js pages get normal text size */
div.mw-geshi div
div.mw-geshi div pre,
span.mw-geshi,
pre.source-css,
pre.source-javascript {
font-family: monospace, Courier !important;
}
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 p858snake p858sn...@gmail.com changed: What|Removed |Added CC||m...@rubenkrapf.de --- Comment #22 from p858snake p858sn...@gmail.com 2012-01-07 07:48:27 UTC --- *** Bug 32990 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Erwin Dokter er...@darcoury.nl changed: What|Removed |Added Attachment #8597|0 |1 is obsolete|| --- Comment #21 from Erwin Dokter er...@darcoury.nl 2012-01-03 17:33:27 UTC --- Comment on attachment 8597 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8597 Patch for shared.css Marked patch obsolete. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #17 from Erwin Dokter er...@darcoury.nl 2011-11-05 12:15:15 UTC --- What extension is that? I can't find it. If it has an associated CSS file (judging from GeShi's tendencies to throw all CSS inline, I doubt there is), it should be put in there . -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 DavidL lamb...@orange.fr changed: What|Removed |Added CC||lamb...@orange.fr --- Comment #18 from DavidL lamb...@orange.fr 2011-11-05 12:57:36 UTC --- There is MediaWiki:Geshi.css for CSS about the Geshi extension. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #19 from Erwin Dokter er...@darcoury.nl 2011-11-05 14:54:21 UTC --- That file tends to load *after* user CSS, so that is not an option. That is one of the reasons I moved the font declaration to common.css in the first place. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #20 from Erwin Dokter er...@darcoury.nl 2011-11-05 15:01:50 UTC --- The extension is called SyntaxHighlight_GeSHi. It has no CSS file, so a fix in core is out. However, if the extension can be adapted to have a CSS file, or load [[MediaWiki:Geshi.css]] ahead of site/user CSS, then that should be considered. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 mybugs.m...@gmail.com changed: What|Removed |Added CC||mybugs.m...@gmail.com --- Comment #15 from mybugs.m...@gmail.com 2011-10-19 11:52:47 UTC --- Could someone please commit this to Wikimedia wikis? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #16 from Happy-melon happy.melon.w...@gmail.com 2011-10-19 16:17:11 UTC --- (In reply to comment #14) Created attachment 8597 [details] Patch for shared.css This should not be put in shared.css, it's related to an extension which is not going to be enabled on all wikis. It might be reasonable to add it as a live-hack to the WMF cluster, though; as all WMF wikis *do* have SyntaxHighlight enabled. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Erwin Dokter er...@darcoury.nl changed: What|Removed |Added Keywords||need-review -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #14 from Erwin Dokter er...@darcoury.nl 2011-05-29 10:56:44 UTC --- Created attachment 8597 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8597 Patch for shared.css -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 mybugs.m...@gmail.com changed: What|Removed |Added Keywords||patch CC|mybugs.m...@gmail.com | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 mybugs.m...@gmail.com changed: What|Removed |Added CC||mybugs.m...@gmail.com --- Comment #13 from mybugs.m...@gmail.com 2011-05-28 20:01:20 UTC --- (In reply to comment #12) If we want to fix it for Mediawiki, then all that is needed is to add the following code to shared.css: So? Could anyone submit the fix for this bug? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204
--- Comment #12 from Erwin Dokter er...@darcoury.nl 2011-05-07 12:50:16 UTC
---
If we want to fix it for Mediawiki, then all that is needed is to add the
following code to shared.css:
/* Fix so syntaxhighlight tags and .css and .js pages get normal text size.
*/
div.mw-geshi div
div.mw-geshi div pre,
span.mw-geshi,
pre.source-css,
pre.source-javascript {
font-family: monospace, Courier New !important;
}
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #11 from Erwin Dokter er...@darcoury.nl 2011-02-08 16:38:43 UTC --- This may not have to be pushed upstream after all. After reading the GeSHi documentation, there are options to set inline CSS in the GeSHi headers, most notable 'set_header_content_style'. I don't know how this is implemented in the extension, but that seems to be the most logical place to fix. The current setup was probably done this way to avoid dependency on 'external' CSS (like common.css), but at the cost of having to use extranious code to fix issues. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Erwin Dokter er...@darcoury.nl changed: What|Removed |Added Status|NEW |RESOLVED Version|wikimedia-deployment|any Component|Page rendering |SyntaxHighlight (GeSHi) CC||er...@darcoury.nl AssignedTo|wikibugs-l@lists.wikimedia. |soxre...@gmail.com |org | Resolution||DUPLICATE Product|MediaWiki |MediaWiki extensions Severity|enhancement |normal --- Comment #1 from Erwin Dokter er...@darcoury.nl 2011-02-03 20:57:32 UTC --- *** This bug has been marked as a duplicate of bug 27145 *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Happy-melon happy.melon.w...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED CC||happy.melon.w...@gmail.com Resolution|DUPLICATE | --- Comment #2 from Happy-melon happy.melon.w...@gmail.com 2011-02-03 21:25:08 UTC --- We generally mark newer bugs as duplicates of older bugs, not the other way around. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #3 from Happy-melon happy.melon.w...@gmail.com 2011-02-03 21:25:16 UTC --- *** Bug 27145 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #4 from Krinkle krinklem...@gmail.com 2011-02-03 21:43:15 UTC --- I have to agree. Roughly since Vector came I have put a font-size:120% in my global.css for Wikimedia wikis to make them readable again. In my setup (Safari 5 / Mac) since Vector the size of code sources is now below the minimum for anti-aliasing which makes the code really pixelated and hard to read (like 8 or 10px). Noticeably smaller than normal article text. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #5 from Erwin Dokter er...@darcoury.nl 2011-02-03 22:02:37 UTC --- I opened a new bug because this one was in the wrong category (and could not be changed unless closed). But to reitterate: GeSHi is inserting redundant div style=font-family: monospace; and even less necessary pre style=font-family: monospace; into the generated HTML. Redundant because the inline generated CSS already contains the necessary font declaration, and pre is already using a monospace font. The way it is currently declared also has problems in several browsers that cause the text to be too small (see bug 20706, for which a general fix has been applied, but also needs to be applied here), and also interferes with sitewide CSS (ie. common.css). What needs to be done: * Remove the inline, hardcoded font styling from the generated HTML (as it is already present in the generated CSS) * Change the default font declaration in the generated CSS to style=font-family: monospace, 'Courier New'; (see bug 20706 for explanation; the objective is not to prefer Courier New, but to trigger the correct behaviour of those borwsers) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Happy-melon happy.melon.w...@gmail.com changed: What|Removed |Added Platform|PC |All OS/Version|Windows 7 |All --- Comment #6 from Happy-melon happy.melon.w...@gmail.com 2011-02-03 22:12:53 UTC --- Both these issues need to be pushed upstream to GeSHi. Can we just use !important keywords to fix this within MW? Is it even an issue which affects other GeSHi implementations? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #7 from Erwin Dokter er...@darcoury.nl 2011-02-03 22:22:17 UTC --- It affects MW in that sitewide CSS may be blocked, and this may be true for other websites. I just fixed the Geshi CSS mess on en.wiki, just so I could finally assign my own font ([[en:Mediawiki talk:Common.css#Pre-formatted (and GeShi) text finally fixed properly]]). But relying on !important; remains a hack. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #8 from Happy-melon happy.melon.w...@gmail.com 2011-02-03 22:27:13 UTC --- We can implement it in a RL'd CSS module included on GeSHi pages; I didn't mean we should make individual wikis fix it in site CSS. It only makes sense to push changes upstream if this is a problem which affects all uses of the GeSHi engine, not just its use in MediaWiki; if that's not the case, we should be doing whatever we need to at a MW level, which pretty much reduces us to !important, unless GeSHi has a hook API (I haven't checked). What CSS needs to be bundled in to straighten out the issues on MW? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #9 from Erwin Dokter er...@darcoury.nl 2011-02-03 23:16:55 UTC --- The necessary CSS is already in the proper place (the generated CSS), which can hopefully be changed by means of local configuration; but it needs to have it's duplica CSS removed from the inline HTML, which can probably only be fixed upstream. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] fontsize in source too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204
--- Comment #10 from Erwin Dokter er...@darcoury.nl 2011-02-03 23:24:29 UTC
---
@Krinkle,
The code to fix the fontsize for source and syntaxhightlight (as well as
.css and .js pages) is:
div.mw-geshi div pre,
span.mw-geshi,
pre.source-css,
pre.source-javascript {
font-family: monospace, Courier New !important;
}
Putting this in nl.wiki common.css (or personal CSS) will fix the problem
(until GeSHi is fixed).
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
