[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 C. Scott Ananian canan...@wikimedia.org changed: What|Removed |Added CC||canan...@wikimedia.org --- Comment #10 from C. Scott Ananian canan...@wikimedia.org --- Echoing comment 7: parser tests need to be added, so that we can ensure that the PHP parser and Parsoid have the same behavior. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Attachment #7932|0 |1 is obsolete|| --- Comment #9 from Umherirrender umherirrender_de...@web.de 2011-11-14 12:34:42 UTC --- Comment on attachment 7932 -- https://bugzilla.wikimedia.org/attachment.cgi?id=7932 change the attribs regex to handle the quoted and unquoted attributes same I am not able to provide a new patch with parser tests or which have the right regex for the specifition. Marking patch as obsolete. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Keywords|patch, reviewed | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords||reviewed CC||suma...@panix.com --- Comment #8 from Sumana Harihareswara suma...@panix.com 2011-11-09 19:09:33 UTC --- Umherirrender, I am adding the reviewed keyword to this bug since you received a review from Brion in comment 7 in February. Do you have time and interest in revising the patch in accordance with those suggestions? Thanks for the patch! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 Dan Collins en.wp.s...@gmail.com changed: What|Removed |Added Keywords||need-parsertest CC||en.wp.s...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 --- Comment #7 from Brion Vibber br...@pobox.com 2011-02-14 00:10:06 UTC --- Need to add test cases for the behavior that it's supposed to be changing, and clarify what is supposed to change and why. Patch seems to be forbidding quoted empty elements, which is definitely wrong.? Appears to also remove '' and '' from the list of accepted chars for unquoted attribs. Not sure how those chars actually interact with the rest of the sanitizer stuff, but note the HTML 5 parser rules explicitly specify that '' should close out the tag, while '' is technically bogus but should be treated as part of the attribute value for consistent fallback behavior: http://dev.w3.org/html5/spec/Overview.html#attribute-value-unquoted-state -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added CC||m...@everybody.org --- Comment #2 from Mark A. Hershberger m...@everybody.org 2011-01-29 19:16:07 UTC --- Not reading in attributes is b/c that is how the spec is written, IIRC. I don't think are allowed in attributes. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #3 from Krinkle krinklem...@gmail.com 2011-01-29 19:35:45 UTC --- elem attr= is a bit weird, not sure if that should be supported. However elem attr should render as elem attr= imho -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 --- Comment #4 from Bawolff bawolff...@gmail.com 2011-01-29 20:04:36 UTC --- I thought in html, elem attr was equivelent to elem attr=attr. It would be weird to do the opposite of html imho. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 --- Comment #5 from Mark A. Hershberger m...@everybody.org 2011-01-29 20:35:30 UTC --- (In reply to comment #4) I thought in html, elem attr was equivelent to elem attr=attr. I don't think so. But see http://www.w3.org/TR/html-markup/syntax.html#syntax-attributes for more info. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 --- Comment #6 from Bawolff bawolff...@gmail.com 2011-01-29 21:21:01 UTC --- Hmm, maybe its an xhtml thing. I was reading http://www.w3.org/TR/xhtml1/#h-4.5 html is confusing. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26441] quoted and unquoted attributes are not handled the same in Sanitizer.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=26441 Bawolff bawolff...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com --- Comment #1 from Bawolff bawolff...@gmail.com 2010-12-27 02:17:49 UTC --- presumably the not reading of in attributes of tag extensions is some sort of paranoia against XSS. It would perhaps make sense to make it not recognize tag att=foobar for consistency's sake. not recognizing tag someAttribute= Seems sane to me. I expect to be required to do tag someAttribute= if i want to pass it the empty string. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
