[Bug 26808] Run $wgSpamRegex on Account registration

2011-11-20 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=26808

Reedy s...@reedyboy.net changed:

   What|Removed |Added

   Keywords|need-review |reviewed

--- Comment #8 from Reedy s...@reedyboy.net 2011-11-20 18:20:43 UTC ---
First part of the patch is fine and applyable (looks fine).

As for the 2nd part, that's moved to the Sanitizer

As it's a function called validateEmail, I'm dubious about adding random MW
specific blocking code in there

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26808] Run $wgSpamRegex on Account registration

2011-11-09 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=26808

Sumana Harihareswara suma...@panix.com changed:

   What|Removed |Added

   Keywords||need-review
 CC||suma...@panix.com

--- Comment #7 from Sumana Harihareswara suma...@panix.com 2011-11-10 
03:03:41 UTC ---
Matěj Grabovský, thank you for the patch, and sorry for the wait.  I'm adding
the need-review keyword so that developers know to review your patch.  Thanks
again.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26808] Run $wgSpamRegex on Account registration

2011-02-05 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=26808

--- Comment #4 from Subfader subfa...@gmail.com 2011-02-05 22:37:59 UTC ---
you're right. moved it to the top of addNewAccount()

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26808] Run $wgSpamRegex on Account registration

2011-02-05 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=26808

--- Comment #5 from Subfader subfa...@gmail.com 2011-02-05 22:43:41 UTC ---
wait. I only wanted to block new spam bits with certain e-mail adresses like
da.vid.smi.th@gmail.com

if you think that's better ok, no idea.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26808] Run $wgSpamRegex on Account registration

2011-01-31 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=26808

--- Comment #3 from Matěj Grabovský mgrabov...@yahoo.com 2011-01-31 12:32:37 
UTC ---
Created attachment 8072
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=8072
Spam check in user name and email validity checks

Wouldn't it be better to check for spam right in User's checks validity of
username and email?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26808] Run $wgSpamRegex on Account registration

2011-01-30 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=26808

--- Comment #1 from Subfader subfa...@gmail.com 2011-01-30 22:45:53 UTC ---
inside function addNewAccountInternal():

# spam check
global $wgSpamRegex;
if ($wgSpamRegex) {
  if ( preg_match( $wgSpamRegex, $this-mEmail ) ) {
$this-mainLoginForm( wfMsg( 'detectedSpam' ) );
return false;
  }
}

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26808] Run $wgSpamRegex on Account registration

2011-01-30 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=26808

--- Comment #2 from Subfader subfa...@gmail.com 2011-01-30 22:48:04 UTC ---
^^ This only checks the email address tho

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l