[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Svick gsv...@gmail.com changed: What|Removed |Added CC||gsv...@gmail.com --- Comment #17 from Svick gsv...@gmail.com 2012-04-30 11:09:22 UTC --- *** Bug 36343 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #16 from Umherirrender umherirrender_de...@web.de 2012-04-21 09:19:19 UTC --- successfully merged -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added CC||umherirrender_de...@web.de --- Comment #15 from Umherirrender umherirrender_de...@web.de 2012-03-30 21:24:59 UTC --- commited the second patch with gerrit 4028 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Sam Reed (reedy) s...@reedyboy.net changed: What|Removed |Added Target Milestone|1.19.0 release |1.20.0 release -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 --- Comment #14 from Umherirrender umherirrender_de...@web.de 2012-01-04 18:51:22 UTC --- (In reply to comment #13) Roan already committed r102947. Is this bug fixed ? Or is this new patch a follow-up that fixes something ? It is a follow up, which fix the navigation with 'dir' and 'continue'. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 --- Comment #13 from Krinkle krinklem...@gmail.com 2012-01-02 15:59:30 UTC --- Roan already committed r102947. Is this bug fixed ? Or is this new patch a follow-up that fixes something ? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Krinkle krinklem...@gmail.com changed: What|Removed |Added AssignedTo|wikibugs-l@lists.wikimedia. |roan.katt...@gmail.com |org | Target Milestone|--- |1.19.0 release -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Krinkle krinklem...@gmail.com changed: What|Removed |Added Status|REOPENED|ASSIGNED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 --- Comment #12 from Umherirrender umherirrender_de...@web.de 2011-12-17 14:22:42 UTC --- Created attachment 9730 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9730 fix for the dir param in prop=links|templates|categories|iwlinks|langlinks|images|duplicatefiles Now you cannot continue with dir=descending, because you get the same result. I have create a patch, to fix that problem in each prop module. Thanks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #8 from Roan Kattouw roan.katt...@gmail.com 2011-11-14 08:26:52 UTC --- (In reply to comment #7) Created attachment 9435 [details] add dir param for prop=links|templates|categories|extlinks|iwlinks|langlinks|images|duplicatefiles Thanks for the patch. Modified patch committed in r102947. It also changed the handling of ORDER BY in ApiQueryBase::addWhereRange. This is needed, because the order by can given as array and that was not handled there. Good catch. I cleaned up the ApiQueryBase changes a bit before committing. It looked like it would've generated a notice because the access to $this-options['ORDER BY'] wasn't protected with isset() (there was an isset call nearby, but 1) the array access was done unconditionally anyway and 2) isset was called on a variable that was set unconditionally, which means it was used to check for null, which is evil) and the logic with wrapping a non-array value in an array could be replaced with an (array) cast. I ended up using: $optionOrderBy = isset( $this-options['ORDER BY'] ) ? (array)$this-options['ORDER BY'] : array(); $optionOrderBy[] = $order; Feel free to modify the patch. The only other modification I made was to drop the ApiQueryExternalLinks.php changes. They added an ORDER BY on el_to which is a partially-indexed blob field, so that would filesort. The query isn't very nice as it is, but this would make it worse. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Keywords|need-review |reviewed --- Comment #9 from Umherirrender umherirrender_de...@web.de 2011-11-14 11:01:17 UTC --- Thank you for review and commit. (In reply to comment #8) (In reply to comment #7) Feel free to modify the patch. The only other modification I made was to drop the ApiQueryExternalLinks.php changes. They added an ORDER BY on el_to which is a partially-indexed blob field, so that would filesort. The query isn't very nice as it is, but this would make it worse. It there a way to get the dir param also for ApiQueryExternalLinks.php? Should I create a new bug to track this (and which gets maybe LATER or WONTFIX)? Thanks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 --- Comment #10 from Roan Kattouw roan.katt...@gmail.com 2011-11-14 11:05:27 UTC --- (In reply to comment #9) It there a way to get the dir param also for ApiQueryExternalLinks.php? Should I create a new bug to track this (and which gets maybe LATER or WONTFIX)? Thanks. You should submit a new patch, either on this bug or on a new one (I don't really care) that doesn't add the order by on el_to. I realize this may mean the result set isn't completely reversed, but that's unavoidable; it's either that or no dir param at all. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 --- Comment #11 from Umherirrender umherirrender_de...@web.de 2011-11-14 12:21:22 UTC --- backed out to bug 32401 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 --- Comment #7 from Umherirrender umherirrender_de...@web.de 2011-11-13 12:17:04 UTC --- Created attachment 9435 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9435 add dir param for prop=links|templates|categories|extlinks|iwlinks|langlinks|images|duplicatefiles The attached patch adds a dir param to prop=links|templates|categories|extlinks|iwlinks|langlinks|images|duplicatefiles The other modules have a dir param (revisions) or in my opinion it makes no sense (info|categoriyinfo|pageprops|stashimageinfo|imageinfo). It also changed the handling of ORDER BY in ApiQueryBase::addWhereRange. This is needed, because the order by can given as array and that was not handled there. Feel free to modify the patch. Thanks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Keywords||need-review, patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added AssignedTo|roan.katt...@gmail.com |wikibugs-l@lists.wikimedia. ||org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Reedy s...@reedyboy.net changed: What|Removed |Added Severity|normal |enhancement -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Krinkle krinklem...@gmail.com changed: What|Removed |Added Summary|Implement query-back or |Implement 'dir' for query |query-until to page back|properties. |like paging forward with| |query-continue. | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26909] Implement 'dir' for query properties.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26909 Krinkle krinklem...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX | --- Comment #6 from Krinkle krinklem...@gmail.com 2011-01-25 18:53:59 UTC --- Re-opened with adjusted summary. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
