[Bug 27046] JS minification regression in ResourceLoader: comment+linebreak as implied semicolon lost

2011-01-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27046

Roan Kattouw roan.katt...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Roan Kattouw roan.katt...@gmail.com 2011-01-31 12:48:56 
UTC ---
(In reply to comment #0)
 The combination of these two seems to confuse the new minifier, and it ends up
 slapping them together with neither a semicolon nor any whitespace at all!
 
The real bug here is that the newline after a C++-style // comment is stripped
unconditionally, even though the minifier keeps each statement on its own line
unless $wgResourceLoaderMinifyJSVerticalSpace is set to true. I have changed it
to unconditionally *preserve* such newlines in r81246, and confirmed that this
fixes your test case.

 Adding to MW 1.17 blockers (unless we won't be shipping this version of the
 minifier -- the old code did fine)
The fix has been tagged for 1.17 merging.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27046] JS minification regression in ResourceLoader: comment+linebreak as implied semicolon lost

2011-01-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27046

Platonides platoni...@gmail.com changed:

   What|Removed |Added

 CC||platoni...@gmail.com

--- Comment #1 from Platonides platoni...@gmail.com 2011-01-30 22:09:22 UTC 
---
We need minimifier tests.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l