[Bug 27375] Whitespace changes should be identifiable in CR diffs
https://bugzilla.wikimedia.org/show_bug.cgi?id=27375 Krinkle changed: What|Removed |Added Target Milestone|1.20.0 release |1.20 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27375] Whitespace changes should be identifiable in CR diffs
https://bugzilla.wikimedia.org/show_bug.cgi?id=27375 Krinkle changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED Target Milestone|--- |1.20.0 release --- Comment #12 from Krinkle 2012-02-27 20:38:55 UTC --- Bug fixed in r112511. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27375] Whitespace changes should be identifiable in CR diffs
https://bugzilla.wikimedia.org/show_bug.cgi?id=27375 Antoine "hashar" Musso changed: What|Removed |Added CC||has...@free.fr --- Comment #11 from Antoine "hashar" Musso 2012-02-27 20:24:37 UTC --- In previous fix HTML entities where showing. Fixed by r112460 Both revisions merged to 1.19wmf1 with r112464 and r112459 have been applied on live site. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27375] Whitespace changes should be identifiable in CR diffs
https://bugzilla.wikimedia.org/show_bug.cgi?id=27375 --- Comment #10 from Krinkle 2012-02-27 00:12:10 UTC --- Done in r112458. After it gets reviewed and deployed we can test the styling on mw.org and then I'll commit them. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27375] Whitespace changes should be identifiable in CR diffs
https://bugzilla.wikimedia.org/show_bug.cgi?id=27375 --- Comment #9 from Krinkle 2012-02-26 23:58:37 UTC --- (In reply to comment #8) > (In reply to comment #7) > > The latest changes in the extension (which, among other things, changed the > > diff presentation into a *cough* table), have made it impossible to > > highlight > > trailing whitespace because the parent elements of the text are no longer > > inline elements and styling their background has no effect. > > The latest changes make the diffs look like crap, IMHO. I'll see if I can change the diffHighlighter to maintain a inline-level element wrapper around the diff text so that background colors can still be applied without highlighting the entire horizontal line but just the text width. WIll probably change .. to be .. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27375] Whitespace changes should be identifiable in CR diffs
https://bugzilla.wikimedia.org/show_bug.cgi?id=27375 --- Comment #8 from Chad H. 2012-02-26 23:56:38 UTC --- (In reply to comment #7) > The latest changes in the extension (which, among other things, changed the > diff presentation into a *cough* table), have made it impossible to highlight > trailing whitespace because the parent elements of the text are no longer > inline elements and styling their background has no effect. The latest changes make the diffs look like crap, IMHO. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27375] Whitespace changes should be identifiable in CR diffs
https://bugzilla.wikimedia.org/show_bug.cgi?id=27375 --- Comment #7 from Krinkle 2012-02-26 20:42:37 UTC --- The latest changes in the extension (which, among other things, changed the diff presentation into a *cough* table), have made it impossible to highlight trailing whitespace because the parent elements of the text are no longer inline elements and styling their background has no effect. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27375] Whitespace changes should be identifiable in CR diffs
https://bugzilla.wikimedia.org/show_bug.cgi?id=27375 --- Comment #6 from Krinkle 2011-06-26 02:24:34 UTC --- Not the exact bits (colors are slightly changed) but the bits in the linked diff on mediawiki.org [1]. Also this depends on r89697 which fixed bug 29307. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27375] Whitespace changes should be identifiable in CR diffs
https://bugzilla.wikimedia.org/show_bug.cgi?id=27375 --- Comment #5 from Reedy 2011-06-26 02:19:57 UTC --- (In reply to comment #4) > This can be re-done. > > With bug 29307 fixed, bug 27416 will not occur anymore when background styling > is added. > I've added it to MediaWiki.org earlier this month: > > http://www.mediawiki.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=408365 So it was you :P I did notice it seemed to change back again, but wasn't overly sure why Is it those bits just need re-adding? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27375] Whitespace changes should be identifiable in CR diffs
https://bugzilla.wikimedia.org/show_bug.cgi?id=27375 Krinkle changed: What|Removed |Added Status|REOPENED|ASSIGNED AssignedTo|wikibugs-l@lists.wikimedia. |krinklem...@gmail.com |org | Summary|Do the diff colouring in CR |Whitespace changes should ||be identifiable in CR diffs -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
