[Bug 27935] Redirect to canonicalize URLs (aka squid cache of [[foo_(bar%29]] not purged)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27935 --- Comment #30 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 96941 merged by Tim Starling: Normalise the path part of URLs in the text frontend https://gerrit.wikimedia.org/r/96941 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27935] Redirect to canonicalize URLs (aka squid cache of [[foo_(bar%29]] not purged)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27935 Tim Starling tstarl...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #31 from Tim Starling tstarl...@wikimedia.org --- Actually, this was probably fixed in May 2012, Ie38ae198b. Testing I did during the deployment of the above change supports this. But, the current patch was worth doing anyway, since after Ie38ae198b, all requests for non-canonical encodings were cache misses due to MW serving them with CC: private (this was confirmed in my testing today). The current patch makes them cache hits instead. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27935] Redirect to canonicalize URLs (aka squid cache of [[foo_(bar%29]] not purged)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27935 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27935] Redirect to canonicalize URLs (aka squid cache of [[foo_(bar%29]] not purged)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27935 --- Comment #29 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 96941 had a related patch set uploaded by Tim Starling: Normalise the path part of URLs in the text frontend https://gerrit.wikimedia.org/r/96941 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27935] Redirect to canonicalize URLs (aka squid cache of [[foo_(bar%29]] not purged)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27935 Rob Lanphier ro...@wikimedia.org changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |tstarl...@wikimedia.org |org | --- Comment #28 from Rob Lanphier ro...@wikimedia.org --- Tim, is this something you can handle while you're looking at bug 31369? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27935] Redirect to canonicalize URLs (aka squid cache of [[foo_(bar%29]] not purged)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27935 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added CC||bjor...@wikimedia.org --- Comment #25 from Brad Jorsch bjor...@wikimedia.org --- (In reply to comment #17) We should redirect, like we do for initial lower-case letters. Can we safely do that, though? A path /wiki/foo_(bar) is not equivalent to /wiki/Foo_(bar), but /wiki/Foo_(bar) and /wiki/Foo_%28bar%29 are supposed to be considered equivalent according to RFC 2616 section 3.2.3. Some client or proxy somewhere might decide to always transform the former into the latter, and then MediaWiki serving a redirect back to the former would result in a loop. Or the client might decide that the redirect to an equivalent title is a loop and show an error to the user.[1] [1]: e.g. http://webmasters.stackexchange.com/questions/2770 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27935] Redirect to canonicalize URLs (aka squid cache of [[foo_(bar%29]] not purged)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27935 --- Comment #26 from Brad Jorsch bjor...@wikimedia.org --- I suppose another question to ask is whether Varnish is any better at this than Squid. If Varnish can easily handle knowing that /wiki/Foo_(bar) and /wiki/Foo_%28bar%29 are equivalent, might this soon be irrelevant? Unless we still want to support third parties using Squid instead of Varnish, I suppose. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27935] Redirect to canonicalize URLs (aka squid cache of [[foo_(bar%29]] not purged)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27935 --- Comment #27 from Tim Starling tstarl...@wikimedia.org --- (In reply to comment #25) (In reply to comment #17) We should redirect, like we do for initial lower-case letters. Can we safely do that, though? A path /wiki/foo_(bar) is not equivalent to /wiki/Foo_(bar), but /wiki/Foo_(bar) and /wiki/Foo_%28bar%29 are supposed to be considered equivalent according to RFC 2616 section 3.2.3. Some client or proxy somewhere might decide to always transform the former into the latter, and then MediaWiki serving a redirect back to the former would result in a loop. Or the client might decide that the redirect to an equivalent title is a loop and show an error to the user.[1] Yes, you're probably right. There is a risk of redirect loops. (In reply to comment #26) I suppose another question to ask is whether Varnish is any better at this than Squid. If Varnish can easily handle knowing that /wiki/Foo_(bar) and /wiki/Foo_%28bar%29 are equivalent, might this soon be irrelevant? Unless we still want to support third parties using Squid instead of Varnish, I suppose. Well, it would be nice to fix this bug in MediaWiki so that any frontend would be supported, but doing it in Varnish would be the next best solution if it is not possible to avoid redirect loops in MediaWiki. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27935] Redirect to canonicalize URLs (aka squid cache of [[foo_(bar%29]] not purged)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27935 Tim Starling tstarl...@wikimedia.org changed: What|Removed |Added Keywords||platformeng -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27935] Redirect to canonicalize URLs (aka squid cache of [[foo_(bar%29)]] not purged)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27935 Krinkle krinklem...@gmail.com changed: What|Removed |Added Summary|Redirect to canonicalize|Redirect to canonicalize |URLs|URLs (aka squid cache of ||[[foo_(bar%29)]] not ||purged) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27935] Redirect to canonicalize URLs (aka squid cache of [[foo_(bar%29]] not purged)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27935 Krinkle krinklem...@gmail.com changed: What|Removed |Added Summary|Redirect to canonicalize|Redirect to canonicalize |URLs (aka squid cache of |URLs (aka squid cache of |[[foo_(bar%29)]] not|[[foo_(bar%29]] not |purged)|purged) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l