[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 Jesús Martínez Novo (Ciencia Al Poder) changed: What|Removed |Added Keywords|patch-need-review | Assignee|wikibugs-l@lists.wikimedia. |en.wp.s...@gmail.com |org | Target Milestone|--- |1.21.0 release -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 Bartosz Dziewoński changed: What|Removed |Added Status|NEW |RESOLVED CC||matma@gmail.com Resolution|--- |FIXED --- Comment #15 from Bartosz Dziewoński --- Merged -> marking as fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 Sumana Harihareswara changed: What|Removed |Added Keywords||patch-in-gerrit -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 --- Comment #14 from Dan Collins 2012-05-23 19:30:08 UTC --- See gerrit #8511 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 Sumana Harihareswara changed: What|Removed |Added Keywords||need-review, patch --- Comment #13 from Sumana Harihareswara 2011-11-25 19:20:39 UTC --- Dan, I am basically taking the long weekend off, but I find that gardening Bugzilla is a little bit calming, like how some people pop the bubbles in bubble wrap. :-) Added the "patch" and "need-review" keywords to signal that there's a patch here that awaits review. Please do feel free to add them the next time you attach a new patch that another developer should review. Thanks for the update. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 --- Comment #12 from Dan Collins 2011-11-24 20:55:04 UTC --- Created attachment 9549 --> https://bugzilla.wikimedia.org/attachment.cgi?id=9549 Updated patch against r104190 What's this, Sumana, you're working on thanksgiving? Per manual testing, the only failing hunk from the original patch had the effect of removing a single line, which by the way was already commented out. Here is the updated patch. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 Sumana Harihareswara changed: What|Removed |Added Attachment #8859|0 |1 is obsolete|| --- Comment #11 from Sumana Harihareswara 2011-11-24 19:39:46 UTC --- Comment on attachment 8859 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8859 Single unified patch against phase3 with code changes and (passing!) parser test Per automated testing http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html patch no longer applies to MediaWiki trunk in Subversion. Requesting update. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 Sumana Harihareswara changed: What|Removed |Added Keywords|need-review, patch | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 Sumana Harihareswara changed: What|Removed |Added Keywords||newparser, parsertest CC||b...@wikidev.net, ||en.wp.s...@gmail.com, ||suma...@panix.com --- Comment #10 from Sumana Harihareswara 2011-11-24 19:38:46 UTC --- Dan, thank you for the patch and the parser test! They are very much appreciated. I'm notifying Gabriel Wicke, who is working on rewriting the parser. In the few months since you made attachment 8859, the trunk has changed a little; would you mind updating it to work against MediaWiki as it is in Subversion now? We'd appreciate that. Thank you. I'm sorry for the delay and the inconvenience. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 Dan Collins changed: What|Removed |Added Attachment #8273|0 |1 is obsolete|| Attachment #8274|0 |1 is obsolete|| Attachment #8275|0 |1 is obsolete|| --- Comment #9 from Dan Collins 2011-07-31 23:42:23 UTC --- Created attachment 8859 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8859 Single unified patch against phase3 with code changes and (passing!) parser test I just took the patch and the proposed test, fixed a few whitespace issues with the test, applied the patch, set up the test, and the test is passing. This patch incorporates the three initial attachments. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936
--- Comment #8 from Bergi 2011-04-21 12:54:50 UTC ---
I'm sorry, I don't understand the syntax of these parser tests, and
http://www.mediawiki.org/wiki/Parser_tests is still a redlink.
It should be a preprocessor test, like those in
phase3/tests/parser/preprocess/.
The problem is, when there are lots of opening braces, their closing does not
work for more than two stack elements. You can see this at "{{ }} }} }}",
which renders to "{{ }}".
My test is just like a cartesian product of possibilities of open and close
pairs/triples, I may should shorten it.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 DieBuche changed: What|Removed |Added CC||diebu...@gmail.com --- Comment #7 from DieBuche 2011-04-15 09:55:44 UTC --- Could you maybe write a parserTest (phase3/tests/parser/parserTests.txt); I can't seem to understand the testcase (what is the input, what is result, what is the expected result) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 ✓ changed: What|Removed |Added Keywords|need-parsertest | CC||andbe...@web.de --- Comment #6 from ✓ 2011-03-09 10:28:35 UTC --- Sorry, I didn't want to comment the patch, I tried to edit it. Forget comment 2 :-) preprocessor-prasertests uploaded. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 ✓ changed: What|Removed |Added Attachment #8264|0 |1 is obsolete|| --- Comment #5 from ✓ 2011-03-09 10:25:18 UTC --- Created attachment 8275 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8275 proposed patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 ✓ changed: What|Removed |Added Attachment #8274|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 --- Comment #4 from ✓ 2011-03-09 10:23:43 UTC --- Created attachment 8274 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8274 expected testresult -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 --- Comment #3 from ✓ 2011-03-09 10:23:07 UTC --- Created attachment 8273 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8273 testcase -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936
✓ changed:
What|Removed |Added
Attachment #8264|bug1.patch |bug27936.patch
filename||
--- Comment #2 from ✓ 2011-03-09 10:20:11 UTC ---
Comment on attachment 8264
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8264
proposed patch
>Index: Preprocessor_DOM.php
>===
>--- Preprocessor_DOM.php (Revision 83528)
>+++ Preprocessor_DOM.php (Arbeitskopie)
>@@ -611,18 +611,12 @@
> $piece->count -= $matchingCount;
> # do we still qualify for any callback
> with remaining count?
>- $names = $rules[$piece->open]['names'];
>- $skippedBraces = 0;
>- $enclosingAccum =& $accum;
>- while ( $piece->count ) {
>- if ( array_key_exists(
>$piece->count, $names ) ) {
>- $stack->push( $piece );
>- $accum =&
>$stack->getAccum();
>- break;
>- }
>- --$piece->count;
>- $skippedBraces ++;
>- }
>- $enclosingAccum .= str_repeat(
>$piece->open, $skippedBraces );
>+ $min = $rules[$piece->open]['min'];
>+ if ( $piece->count >= $names->min ) {
>+ $stack->push( $piece );
>+ $accum =& $stack->getAccum();
>+ } else {
>+ $accum .= str_repeat(
>$piece->open, $piece->count );
>+ }
> }
> $flags = $stack->getFlags();
> extract( $flags );
>Index: Preprocessor_Hash.php
>===
>--- Preprocessor_Hash.php (Revision 83528)
>+++ Preprocessor_Hash.php (Arbeitskopie)
>@@ -624,18 +624,12 @@
> $piece->count -= $matchingCount;
> # do we still qualify for any callback
> with remaining count?
>- $names = $rules[$piece->open]['names'];
>- $skippedBraces = 0;
>- $enclosingAccum =& $accum;
>- while ( $piece->count ) {
>- if ( array_key_exists(
>$piece->count, $names ) ) {
>- $stack->push( $piece );
>- $accum =&
>$stack->getAccum();
>- break;
>- }
>- --$piece->count;
>- $skippedBraces ++;
>- }
>- $enclosingAccum->addLiteral(
>str_repeat( $piece->open, $skippedBraces ) );
>+ $min = $rules[$piece->open]['min'];
>+ if ( $piece->count >= $min ) {
>+ $stack->push( $piece );
>+ $accum =& $stack->getAccum();
>+ } else {
>+ $accum .= str_repeat(
>$piece->open, $piece->count );
>+ }
> }
>
> extract( $stack->getFlags() );
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27936] preprocessor fail at parsing more than two back-to-back nested elements
https://bugzilla.wikimedia.org/show_bug.cgi?id=27936 Ashar Voultoiz changed: What|Removed |Added Keywords||need-parsertest, ||need-review, patch CC||has...@free.fr --- Comment #1 from Ashar Voultoiz 2011-03-08 16:32:28 UTC --- adding some keywords -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
