[Bug 28354] Edit tab is shown as view source for blocked users, which breaks squid caching
https://bugzilla.wikimedia.org/show_bug.cgi?id=28354 --- Comment #5 from Brion Vibber br...@wikimedia.org 2011-06-07 18:27:30 UTC --- Please see code review comment on r87326; the $short parameter on Title::checkUserBlock is no longer used. Is this deliberate? Does that need to be fixed, or removed, or changed? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28354] Edit tab is shown as view source for blocked users, which breaks squid caching
https://bugzilla.wikimedia.org/show_bug.cgi?id=28354 P.Copp paul.copper...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #4 from P.Copp paul.copper...@gmail.com 2011-05-03 13:20:50 UTC --- Fixed in r87326. Note there's also bug5106 for the issue of showing the view source tab to blocked users. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28354] Edit tab is shown as view source for blocked users, which breaks squid caching
https://bugzilla.wikimedia.org/show_bug.cgi?id=28354 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Keywords|triage | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28354] Edit tab is shown as view source for blocked users, which breaks squid caching
https://bugzilla.wikimedia.org/show_bug.cgi?id=28354 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #3 from Roan Kattouw roan.katt...@gmail.com 2011-04-26 15:30:10 UTC --- (In reply to comment #2) Comment from triage: should be fixed if it is breaking caching, but the right thing may be to disable general caching if we find that you (user) are blocked? And how would we do that? The caching happens on the Squid level and only looks at login cookies to let stuff through. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28354] Edit tab is shown as view source for blocked users, which breaks squid caching
https://bugzilla.wikimedia.org/show_bug.cgi?id=28354 --- Comment #2 from Mark A. Hershberger m...@everybody.org 2011-04-26 03:38:31 UTC --- Comment from triage: should be fixed if it is breaking caching, but the right thing may be to disable general caching if we find that you (user) are blocked? Could you apply your fix so we can test it? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28354] Edit tab is shown as view source for blocked users, which breaks squid caching
https://bugzilla.wikimedia.org/show_bug.cgi?id=28354 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Keywords||triage -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28354] Edit tab is shown as view source for blocked users, which breaks squid caching
https://bugzilla.wikimedia.org/show_bug.cgi?id=28354 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added AssignedTo|wikibugs-l@lists.wikimedia. |ro...@wikimedia.org |org | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28354] Edit tab is shown as view source for blocked users, which breaks squid caching
https://bugzilla.wikimedia.org/show_bug.cgi?id=28354 p858snake p858sn...@gmail.com changed: What|Removed |Added Keywords||need-review, patch CC||p858sn...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28354] Edit tab is shown as view source for blocked users, which breaks squid caching
https://bugzilla.wikimedia.org/show_bug.cgi?id=28354 --- Comment #1 from P.Copp paul.copper...@gmail.com 2011-04-01 00:20:43 UTC --- Created attachment 8356 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8356 Test addition for TitlePermissionTest.php A small unit test to check that quickUserCan() ignores blocks. I had to make some unrelated tweaks to Title.php to make the test work again, as it is currently broken on trunk. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28354] Edit tab is shown as view source for blocked users, which breaks squid caching
https://bugzilla.wikimedia.org/show_bug.cgi?id=28354 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Normal |High CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
