[Bug 28485] Block::purgeExpired Database returned error 1205: Lock wait timeout exceeded;

2011-04-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28485

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Keywords||triage
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28485] Block::purgeExpired Database returned error 1205: Lock wait timeout exceeded;

2011-04-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28485

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #6 from Reedy s...@reedyboy.net 2011-04-12 20:28:37 UTC ---
Reverted in r85916, pending a better solution

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28485] Block::purgeExpired Database returned error 1205: Lock wait timeout exceeded;

2011-04-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28485

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 Blocks||28499

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28485] Block::purgeExpired. Database returned error 1205: Lock wait timeout exceeded;

2011-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28485

--- Comment #1 from Reedy s...@reedyboy.net 2011-04-10 23:52:39 UTC ---
Created attachment 8390
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=8390
Patch...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28485] Block::purgeExpired. Database returned error 1205: Lock wait timeout exceeded;

2011-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28485

Reedy s...@reedyboy.net changed:

   What|Removed |Added

   Keywords||need-review, patch
 CC||tstarl...@wikimedia.org

--- Comment #2 from Reedy s...@reedyboy.net 2011-04-10 23:53:38 UTC ---
Tim, is this simply what is needed to fix this issue?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28485] Block::purgeExpired. Database returned error 1205: Lock wait timeout exceeded;

2011-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28485

--- Comment #3 from Tim Starling tstarl...@wikimedia.org 2011-04-11 00:24:46 
UTC ---
No, wfGetLB() does not create a new load balancer, it gets a cached one. You
want:

$lb = wfGetLBFactory()-newMainLB();
$db = $lb-getConnection( DB_MASTER );
...
$lb-commitMasterChanges();
$lb-closeAll();

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28485] Block::purgeExpired Database returned error 1205: Lock wait timeout exceeded;

2011-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28485

Reedy s...@reedyboy.net changed:

   What|Removed |Added

   Keywords|need-review |reviewed
 Status|NEW |RESOLVED
 Resolution||FIXED
Summary|Block::purgeExpired.   |Block::purgeExpired
   |Database returned error |Database returned error
   |1205: Lock wait timeout|1205: Lock wait timeout
   |exceeded;   |exceeded;

--- Comment #4 from Reedy s...@reedyboy.net 2011-04-11 00:29:52 UTC ---
r85776

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28485] Block::purgeExpired Database returned error 1205: Lock wait timeout exceeded;

2011-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28485

Reedy s...@reedyboy.net changed:

   What|Removed |Added

   Attachment #8390|0   |1
is obsolete||

--- Comment #5 from Reedy s...@reedyboy.net 2011-04-11 00:30:00 UTC ---
Comment on attachment 8390
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=8390
Patch...

Index: Block.php
===
--- Block.php  (revision 85768)
+++ Block.php  (working copy)
@@ -889,7 +889,9 @@
* Purge expired blocks from the ipblocks table
*/
   public static function purgeExpired() {
-  $dbw = wfGetDB( DB_MASTER );
+  global $wgDbBname;
+  $lb = wfGetLb( $wgDbBname );
+  $dbw = $lb-getConnection( DB_MASTER, array(), $wgDbBname );
   $dbw-delete( 'ipblocks', array( 'ipb_expiry  ' . 
 $dbw-addQuotes( $dbw-timestamp() ) ), __METHOD__ );
   }


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l