[Bug 28574] Proofread doesn't add buttons to wikiEditor toolbar, only to legacy one.
https://bugzilla.wikimedia.org/show_bug.cgi?id=28574 --- Comment #11 from mybugs.m...@gmail.com 2011-07-20 19:24:48 UTC --- Brion, I'm not sure this is was caused by the recent changes, but a user reported the following on English Wikisource: I may be wrong, but I assume that it is this fix that may have introduced a minor glitch into Proofread Page: until a few days ago, when in zoom mode, the mouse cursor changed to crosshairs, while scroll mode was the normal arrow. Now it is the arrow in both modes, which is an inconvenience. https://secure.wikimedia.org/wikisource/en/w/index.php?title=Wikisource%3AScriptoriumaction=historysubmitdiff=3176709oldid=3176578 And when I go to the page http://de.wikisource.org/w/index.php?title=Seite:Arthur_Schnitzler_%E2%80%93_Flucht_in_die_Finsternis_%E2%80%93_141.jpgaction=editdebug=1 using Chromium 12.0.742.112 (90304) Ubuntu 11.04, and click on the image, I get the following error: Uncaught TypeError: Cannot set property 'cssText' of undefined pr_dropproofread.js:435 On Firefox 5.0 the error is pr_rect.style is undefined http://bits.wikimedia.org/w/extensions-1.17/ProofreadPage/proofread.js Line 435 pr_rect.style.cssText = display:none; -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28574] Proofread doesn't add buttons to wikiEditor toolbar, only to legacy one.
https://bugzilla.wikimedia.org/show_bug.cgi?id=28574 Brion Vibber br...@wikimedia.org changed: What|Removed |Added AssignedTo|thoma...@gmx.de |br...@wikimedia.org --- Comment #6 from Brion Vibber br...@wikimedia.org 2011-07-15 20:44:05 UTC --- Assigning to myself, doing some related cleanup. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28574] Proofread doesn't add buttons to wikiEditor toolbar, only to legacy one.
https://bugzilla.wikimedia.org/show_bug.cgi?id=28574 --- Comment #7 from Brion Vibber br...@wikimedia.org 2011-07-15 21:49:55 UTC --- r92311 r92314 fix up ProofreadPage on trunk to do the toolbar buttons in a WikiEditor-compatible way (based on the script patch above), also switching the classic-toolbar path to use the labels/icons/actions as already made from the structure for that, so we don't have to define them twice. The separate OCR button script I think shouldn't actually depend on anything else internally (?) but I'm not totally sure. Haven't attempted anything with that. Revs above need merge to 1.18 and 1.17/1.17wmf1; I'll take a peek and make sure it's not a tricky merge. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28574] Proofread doesn't add buttons to wikiEditor toolbar, only to legacy one.
https://bugzilla.wikimedia.org/show_bug.cgi?id=28574 Brion Vibber br...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #8 from Brion Vibber br...@wikimedia.org 2011-07-15 22:06:51 UTC --- Merged to REL1_17 r92319 - tested locally. Merged to 1.17wmf1 r92321. Merged to REL1_18 r92323. Fix should go live shortly. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28574] Proofread doesn't add buttons to wikiEditor toolbar, only to legacy one.
https://bugzilla.wikimedia.org/show_bug.cgi?id=28574 --- Comment #9 from Brion Vibber br...@wikimedia.org 2011-07-15 22:14:21 UTC --- Confirmed fix live at http://de.wikisource.org/w/index.php?title=Seite:Arthur_Schnitzler_%E2%80%93_Flucht_in_die_Finsternis_%E2%80%93_141.jpgaction=edit -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28574] Proofread doesn't add buttons to wikiEditor toolbar, only to legacy one.
https://bugzilla.wikimedia.org/show_bug.cgi?id=28574 --- Comment #10 from mybugs.m...@gmail.com 2011-07-15 22:51:48 UTC --- Thank you very much! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28574] Proofread doesn't add buttons to wikiEditor toolbar, only to legacy one.
https://bugzilla.wikimedia.org/show_bug.cgi?id=28574 --- Comment #3 from mybugs.m...@gmail.com 2011-07-13 19:12:48 UTC --- Created attachment 8778 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8778 Code of a user script to add the buttons (In reply to comment #2) (In reply to comment #1) See http://www.mediawiki.org/wiki/Extension:WikiEditor/Toolbar_customization for a guide how to add stuff to the toolbar You can use that guide to fix OCR locally. ProofreadPage needs to be fixed in SVN. Not really. Although we can add the buttons to the toolbar using a code like the one attached to this bug, the functions pr_toggle_visibility and pr_toggle_layout are not available for use on gadgets and user scripts, raising errors on error console. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28574] Proofread doesn't add buttons to wikiEditor toolbar, only to legacy one.
https://bugzilla.wikimedia.org/show_bug.cgi?id=28574 --- Comment #4 from mybugs.m...@gmail.com 2011-07-13 19:15:48 UTC --- Created attachment 8779 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8779 Screenshot of error console on Google Chrome (In reply to comment #3) Not really. Although we can add the buttons to the toolbar using a code like the one attached to this bug, the functions pr_toggle_visibility and pr_toggle_layout are not available for use on gadgets and user scripts, raising errors on error console. See the screenshot. I think if you define those functions by means of e.g. self.pr_toggle_visibility = function() instead of function pr_toggle_visibility() then users could fix the bug locally without having to copy the whole proofread.js file. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28574] Proofread doesn't add buttons to wikiEditor toolbar, only to legacy one.
https://bugzilla.wikimedia.org/show_bug.cgi?id=28574 mybugs.m...@gmail.com changed: What|Removed |Added Priority|Low |Normal CC||mybugs.m...@gmail.com Severity|normal |major --- Comment #5 from mybugs.m...@gmail.com 2011-07-13 19:29:21 UTC --- Changing importance because this affects all users of all Wikisources since the enhanced toolbar is the default on all projects. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28574] Proofread doesn't add buttons to wikiEditor toolbar, only to legacy one.
https://bugzilla.wikimedia.org/show_bug.cgi?id=28574 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #2 from Roan Kattouw roan.katt...@gmail.com 2011-04-17 08:29:37 UTC --- (In reply to comment #1) See http://www.mediawiki.org/wiki/Extension:WikiEditor/Toolbar_customization for a guide how to add stuff to the toolbar You can use that guide to fix OCR locally. ProofreadPage needs to be fixed in SVN. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 28574] Proofread doesn't add buttons to wikiEditor toolbar, only to legacy one.
https://bugzilla.wikimedia.org/show_bug.cgi?id=28574 DieBuche diebu...@gmail.com changed: What|Removed |Added CC||diebu...@gmail.com Component|Page editing|ProofreadPage Version|unspecified |any AssignedTo|wikibugs-l@lists.wikimedia. |thoma...@gmx.de |org | Product|MediaWiki |MediaWiki extensions Summary|Enhanced toolbar as |Proofread doesn't add |default, not sufficiently |buttons to wikiEditor |functional for Wikisource; |toolbar, only to legacy |buttons from standard |one. |toolbar are missing | --- Comment #1 from DieBuche diebu...@gmail.com 2011-04-16 14:12:24 UTC --- See http://www.mediawiki.org/wiki/Extension:WikiEditor/Toolbar_customization for a guide how to add stuff to the toolbar -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
