[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-12-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

--- Comment #10 from Brion Vibber br...@wikimedia.org 2011-12-20 21:21:48 UTC 
---
Reverted r106523 in r106862; this is a strange abstraction violation and looks
pretty weird to me.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-12-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

--- Comment #9 from duplicate...@googlemail.com 2011-12-17 18:27:34 UTC ---
r105831

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-12-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

Aaron Schulz schulzaaro...@yahoo.de changed:

   What|Removed |Added

 CC||schulzaaro...@yahoo.de

--- Comment #9 from Aaron Schulz schulzaaro...@yahoo.de 2011-12-06 01:28:24 
UTC ---
Fixed in r54567.

Please update and add explained comment.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

--- Comment #6 from Mark A. Hershberger m...@everybody.org 2011-05-20 
16:03:44 UTC ---
I'm assuming that all those not good ones need similar fixes, right?  Would it
be possible to do one and point to it here as documentation so I can add this
bug to [[mw:Annoying Little Bug]]?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

--- Comment #7 from Mark A. Hershberger m...@everybody.org 2011-05-20 
16:29:50 UTC ---
Ugh, that is a page on Mediawiki.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

--- Comment #8 from Reedy s...@reedyboy.net 2011-05-20 17:15:38 UTC ---
(In reply to comment #5)
 ApiQuery gets its titles from ApiPageSet; need to check that.

$pageFlds = array(
'page_namespace' = null,
'page_title' = null,
'page_id' = null,
);

Looks good to me

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-05-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

--- Comment #3 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-05-14 
08:56:27 UTC ---
Ok, so that is easy.

We should first check though if all usages of addTitleInfo() use a Title that
was constructed with a row that contains page_id so as to avoid running a new
query for every title.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-05-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

--- Comment #4 from Reedy s...@reedyboy.net 2011-05-14 09:06:45 UTC ---
Indeed. May have to change things to use a faux Row object to get the
information, but whatever

I was going to do that as part of the cleanup, at worst, in most cases, it'll
be just pulling an extra column out of the database if it's not already done

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-05-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

--- Comment #5 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-05-14 
09:18:22 UTC ---
ApiImport is good
ApiPatrol is good
ApiPurge is not good, and is presumably already doing a query for every title
because it is doing (new Title)-exists() in a loop.
ApiQuery gets its titles from ApiPageSet; need to check that.
ApiQueryAllimages is not good
ApiQueryAlllinks is not good
ApiQueryBacklinks is not good
... and many others are not good either. So somebody should take some time to
fix all of them.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-05-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

duplicate...@googlemail.com changed:

   What|Removed |Added

 CC||duplicate...@googlemail.com

--- Comment #2 from duplicate...@googlemail.com 2011-05-13 14:30:28 UTC ---
(In reply to comment #1)
 Is there a way to store the page id in the Title object?

Looks like $mArticleID (set by Title::newFromRow)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-05-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28901] Make ApiQueryBase::addTitleInfo optionally able to add the page id

2011-05-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28901

--- Comment #1 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-05-10 
09:07:32 UTC ---
Is there a way to store the page id in the Title object?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l