[Bug 29070] [ApiWatch] Add token to action=watch

2011-05-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29070

Krinkle  changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #2 from Krinkle  2011-05-21 14:38:34 UTC ---
markpatrolled requires a POST. I think it would make sense to require this for
watching as well.

On the other hand, with markpatrolled we ended up with a token that is not
compatible between index.php and api.php (presumably becuase index.php should
not be POST for common actions and thus got an extra salt layer). Gadgets that
attempted to use the API to mark stuff as patrolled first have to make an API
request to get the token, the one already on the page was not compatible.

If we could it would be great if the tokens would be the same to avoid doing
the same as we did with markpatrolled. However this may have been done on
purpose. I guess once bug 29067 is fixed, we don't have to worry about that
anymore since gadgets could just get their tokens from there.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29070] [ApiWatch] Add token to action=watch

2011-05-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29070

--- Comment #1 from Bryan Tong Minh  2011-05-21 
13:48:07 UTC ---
Please note that the token should be salted to prevent edit token leakage.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29070] [ApiWatch] Add token to action=watch

2011-05-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29070

Mark A. Hershberger  changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l