[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP in Windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Michelle Lee Kosik kosi...@mail.com changed: What|Removed |Added CC||kosi...@mail.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP in Windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Mark A. Hershberger john.n...@gmx.com changed: What|Removed |Added Status|NEW |RESOLVED CC||john.n...@gmx.com Resolution||FIXED --- Comment #17 from Mark A. Hershberger john.n...@gmx.com 2012-02-28 20:47:42 UTC --- Fixed in 105432. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP in Windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Bryan Tong Minh bryan.tongm...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP in Windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 --- Comment #16 from Platonides platoni...@gmail.com 2011-08-05 19:42:58 UTC --- It is unlikely to occur with cgi/fastcgi, since in that case it uses the stack set in php binary. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP in Windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Bryan Tong Minh bryan.tongm...@gmail.com changed: What|Removed |Added CC||bryan.tongm...@gmail.com --- Comment #15 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-06-02 21:51:33 UTC --- Does not occur on IIS with PHP 5.3.4 (cgi-fcgi). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP in Windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|High|Normal -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 --- Comment #11 from Platonides platoni...@gmail.com 2011-05-31 19:41:30 UTC --- The point where it errors for me with a 64bit php (and a test script) is with ulimit -s515 at doMagicLinks (the preg_split passes), where as with the old regex, it worked up to ulimit -s42. With the modification proposed at comment 10, it runs again until -s44. Note that these tests are specific to the provided url testcase, and that with the same borderline settings, it may sometimes works and sometimes fails. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 --- Comment #12 from Happy-melon happy.melon.w...@gmail.com 2011-05-31 19:56:39 UTC --- That's still pretty close to recovering the original performance (-s isn't logarithmic or anything, is it?) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP in Windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Summary|Long external link (which |Long external link (which |exceeds 313 characters) |exceeds 313 characters) |crashes PHP |crashes PHP in Windows -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP in Windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 --- Comment #13 from Platonides platoni...@gmail.com 2011-05-31 20:45:41 UTC --- ulimit -s sets the stack size in kb. The problem was in the regex which we made mucho more complex, and is itself included into another big regex. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP in Windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 --- Comment #14 from Happy-melon happy.melon.w...@gmail.com 2011-05-31 22:50:30 UTC --- Indeed; but you seem to have found an optimisation which produces the same functionality for ony a 5% memory footprint penalty, as opposed to the 1125% penalty in the original version. Is that good enough performance to put it back in? Does this mean it's possible to crash *any* server with a long enough URL? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added CC||m...@everybody.org --- Comment #8 from Mark A. Hershberger m...@everybody.org 2011-05-30 22:36:20 UTC --- (In reply to comment #7) Should we add a test case for long external link string to prevent this issue from regression? I'm not sure a test case would help since this appears to be a problem that should be reported to PHP developers. In fact, I wonder if this might be caused by XAMMP instead of PHP since I'm running PHP 5.3.5-1ubuntu7.2 at MW r89000 and it works. Also, trying with PHP 5.3.6 under Fedora with MW 89000 shows no problems. Will now try WAMP and XAMP. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Platonides platoni...@gmail.com changed: What|Removed |Added CC||platoni...@gmail.com --- Comment #9 from Platonides platoni...@gmail.com 2011-05-30 22:40:37 UTC --- I don't think we can add a test case for it. It will probably pass in command line. These errors depend on the stack size of httpd.exe. bugs.php.net would tell you to run link.exe to modify its header or to decrease pcre.backtrack_limit and pcre.recursion_limit. Mark, to make that fail in Linux you would need to restrict the stack size with ulimit. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 --- Comment #10 from Platonides platoni...@gmail.com 2011-05-30 22:46:05 UTC --- Using (?:[^\]\[\x00-\x20\x7F]+|\[\])+) instead of (?:[^\]\[\x00-\x20\x7F]|\[\])+) is probably cheaper. Can you test? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |High -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Pei-Tang Huang b...@cht.com.tw changed: What|Removed |Added Summary|Long external link (which |Long external link (which |exceeds 313 characters) |exceeds 313 characters) |crashes PHP module |crashes PHP -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Max Semenik maxsem.w...@gmail.com changed: What|Removed |Added CC||maxsem.w...@gmail.com --- Comment #1 from Max Semenik maxsem.w...@gmail.com 2011-05-29 07:49:48 UTC --- Confirmed on my Win7/x64 box with PHP 5.3.5 (XAMPP). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Niklas Laxström niklas.laxst...@gmail.com changed: What|Removed |Added CC||niklas.laxst...@gmail.com --- Comment #2 from Niklas Laxström niklas.laxst...@gmail.com 2011-05-29 07:53:11 UTC --- So this is a PHP bug? What can we do about it? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 --- Comment #3 from Pei-Tang Huang b...@cht.com.tw 2011-05-29 08:02:08 UTC --- My another Windows Server 2008 R2 with PHP 5.3.2 and older version of MediaWiki (r70253) is OK for long external link. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 --- Comment #4 from Max Semenik maxsem.w...@gmail.com 2011-05-29 08:04:01 UTC --- We certainly can do something about this, since we introduced it in r84022. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 Happy-melon happy.melon.w...@gmail.com changed: What|Removed |Added CC||happy.melon.w...@gmail.com --- Comment #5 from Happy-melon happy.melon.w...@gmail.com 2011-05-29 08:16:07 UTC --- Is 313 characters a hard limit, or does it depend on the resources available to PHP? This rev should probably be reverted until it's fixed, as it's a trivial DOS vector. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 --- Comment #6 from Pei-Tang Huang b...@cht.com.tw 2011-05-29 08:21:47 UTC --- The magic number 313 is what I observed from my Windows Server 2008 R2 + PHP 5.3.6 + MW 1.19alpha (r89086), Maybe Max Semenik can prove or disprove this on his environment :) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29197] Long external link (which exceeds 313 characters) crashes PHP
https://bugzilla.wikimedia.org/show_bug.cgi?id=29197 --- Comment #7 from Pei-Tang Huang b...@cht.com.tw 2011-05-30 00:05:25 UTC --- Thanks for your quick response in r89088. Should we add a test case for long external link string to prevent this issue from regression? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
