[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review and multiple template-loops by altering the configuration of Upload Wizard
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 Neil Kandalgaonkar ne...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #27 from Neil Kandalgaonkar ne...@wikimedia.org 2011-10-27 00:43:47 UTC --- after the deploy on 2011-10-26 this should be fixed again. Tested and cannot make it happen. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review and multiple template-loops by altering the configuration of Upload Wizard
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Status|REOPENED|ASSIGNED CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review and multiple template-loops by altering the configuration of Upload Wizard
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 --- Comment #26 from Mark A. Hershberger m...@everybody.org 2011-10-26 00:00:25 UTC --- (In reply to comment #25) We are deploying again Monday, hopefully. This time I will rebranch from trunk which ought to cure all regressions. Did it? Please close this bug if they are cured. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review and multiple template-loops by altering the configuration of Upload Wizard
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 rai...@rillke.eu rainerril...@hotmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE | --- Comment #24 from rai...@rillke.eu rainerril...@hotmail.com 2011-10-14 11:43:32 UTC --- Sorry, I am not (from the future). And someone seem to forgot to deploy this to MW1.18. Ouch! Just try upload wizard on commons. It produces the same mistakes again: *self-loop: 1) upload multiple files and select the license for each file in the next step, then select cc0 2) cancel the upload declaring it is not your own work and then selecting a file and uploading this * flickrreview: 1) at us-gov-source not from flickr Someone from the past could be upset now. ;-) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review and multiple template-loops by altering the configuration of Upload Wizard
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 --- Comment #25 from Neil Kandalgaonkar ne...@wikimedia.org 2011-10-14 12:01:08 UTC --- Rainer: I feel your pain. After we deployed I saw that again and was hoping it was some kind of optical illusion. We are deploying again Monday, hopefully. This time I will rebranch from trunk which ought to cure all regressions. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review and multiple template-loops by altering the configuration of Upload Wizard
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 rai...@rillke.eu rainerril...@hotmail.com changed: What|Removed |Added Keywords|need-review, patch | Summary|Inaccurately tagging some |Inaccurately tagging some |images as being from Flickr |images as being from Flickr |and requiring review|and requiring review and ||multiple template-loops by ||altering the configuration ||of Upload Wizard --- Comment #22 from rai...@rillke.eu rainerril...@hotmail.com 2011-09-22 13:59:17 UTC --- Is it common practise to mark older bugs as dupes of newer ones, Neil? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review and multiple template-loops by altering the configuration of Upload Wizard
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 --- Comment #23 from Neil Kandalgaonkar ne...@wikimedia.org 2011-09-22 17:26:10 UTC --- (In reply to comment #22) Is it common practise to mark older bugs as dupes of newer ones, Neil? I am from the future. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346
--- Comment #20 from Brion Vibber br...@wikimedia.org 2011-09-22 01:01:12 UTC
---
Is this still an issue? I can't reproduce it locally on trunk; if I check
Original work of the US Federal Government, I only get a {{PD-USGov}}, not a
flickr-review tag.
... I can however reproduce it on Commons, doing the same thing:
http://commons.wikimedia.org/wiki/File:Test_file_for_bug_29346.png
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 Neil Kandalgaonkar ne...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #21 from Neil Kandalgaonkar ne...@wikimedia.org 2011-09-22 01:28:33 UTC --- The author of the bug report wanted to fix multiple issues. The one that's more of a policy change was split off into #29994, which is good. The rest is the same underlying issue as #30237, which I just fixed. In retrospect, now I understand what Rainier was talking about. *** This bug has been marked as a duplicate of bug 30237 *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 Neil Kandalgaonkar ne...@wikimedia.org changed: What|Removed |Added Priority|Normal |Highest -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 Ryan Kaldari rkald...@wikimedia.org changed: What|Removed |Added CC||rkald...@wikimedia.org --- Comment #19 from Ryan Kaldari rkald...@wikimedia.org 2011-08-18 23:50:29 UTC --- This could also be fixed by integrating the mw.FlickrChecker.js functionality into UploadWizard, so that Flickr licenses are handled automatically. The code that interfaces with Flickr is already written, but I never actually integrated it into UW. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346
rai...@rillke.eu rainerril...@hotmail.com changed:
What|Removed |Added
Attachment #8677|0 |1
is obsolete||
--- Comment #18 from rai...@rillke.eu rainerril...@hotmail.com 2011-07-31
09:38:47 UTC ---
Created attachment 8855
-- https://bugzilla.wikimedia.org/attachment.cgi?id=8855
patch in unified diff - format as requested
This patch should resolve the following symptoms:
* Inaccurately adding License-Review templates if user selected PD-US-Gov
* Prevent Template-Loop like {{self|self|self|cc-0}}
This is done by cloning the object instead of passing a reference.
Q: Why do you use a deep-copy?
A: We do not know what follows in future so a deep copy is much saver.
WARNING: There is no warranty of merchantability nor of fitness for a
particular purpose.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 --- Comment #17 from rai...@rillke.eu rainerril...@hotmail.com 2011-07-21 09:01:39 UTC --- And now we have a new Bug 29994 . With some additions. But the license templates are just a configuration issue. You just have to change licensesThirdParty of comment #4 from and to or . That's all. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346
--- Comment #13 from rai...@rillke.eu rainerril...@hotmail.com 2011-06-19
09:04:41 UTC ---
there's no patch but see comment #6
Now, there is a patch, feel free to remove the comments in ll. 59, 61, 65
$.extend( {}, foo );
Please do not use this. Instead use $.extend( [], foo ); Otherwise it is not an
array, only an object (without length property and join-function, ...)
But you can just use my proposed fix in comment #11
Thanks for working on this subject. Sincerely Rillke
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 p858snake p858sn...@gmail.com changed: What|Removed |Added Keywords||need-review, patch CC||p858sn...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 --- Comment #16 from Roan Kattouw roan.katt...@gmail.com 2011-06-19 19:23:51 UTC --- (In reply to comment #15) unified diff format -- is this something I can do? Help says: If the patch is not in a format that you like, you can turn it into a unified diff format by clicking the Raw Unified link at the top of the page. Should I have submitted the original file first and then the changes? (Sorry I'm new to bugzilla.) I have no idea how that works. I just make my patches on the command line. Is there another way to speed-up fixing? It's a one-line fix so this is fine. For now you'll just have to wait until Monday or later for Neil to see this and have time for this. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346
rai...@rillke.eu rainerril...@hotmail.com changed:
What|Removed |Added
Attachment #8637|0 |1
is obsolete||
--- Comment #11 from rai...@rillke.eu rainerril...@hotmail.com 2011-06-18
13:43:29 UTC ---
Created attachment 8677
-- https://bugzilla.wikimedia.org/attachment.cgi?id=8677
requested bugfix
The change of the bug-title was wrong. This is only the symptom.
I now submit a fix that should work.
Again: The script changed the media-wiki-config, set with
(mediaWiki.config.set({UploadWizardConfig: {) (see previous attachment). This
is now prevented by cloning the array. Don't presume I am talking about ghosts
again. That's something I really dislike. If you would have taken the time to
read my comments in the resubmitted source-file, you would know what I am
talking about. Gr ;-)
With best regards Rainer Rillke (RE)
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346
--- Comment #12 from Roan Kattouw roan.katt...@gmail.com 2011-06-18 20:23:47
UTC ---
(In reply to comment #9)
Marking as enhancement unless / until this patch is shown to fix an existing
bug, or explained in some way.
Neil, this looks legit to me. Apparently some config var is assigned to another
var somewhere and manipulated later, but because of the by-reference nature of
array assignments in JS, this ends up manipulating the config itself, which is
kind of evil and apparently leads to pollution. The proposed fix (there's no
patch but see comment #6) is to clone the array with something like var bar =
$.extend( {}, foo ); instead of var bar = foo;
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29346] Inaccurately tagging some images as being from Flickr and requiring review
https://bugzilla.wikimedia.org/show_bug.cgi?id=29346 Neil Kandalgaonkar ne...@wikimedia.org changed: What|Removed |Added Summary|mw.UploadWizardLicenseInput |Inaccurately tagging some |.js ll. 59, 61, 65: |images as being from Flickr |Changing MediaWiki Config |and requiring review Severity|enhancement |normal -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
