[Bug 29693] Resource Loader loads CSS multiple times
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 Rainer Rillke @commons.wikimedia.org (user of a WMF wiki); Using latest Firefox release if not otherwise noted. changed: What|Removed |Added CC||rainerril...@hotmail.com --- Comment #9 from Rainer Rillke @commons.wikimedia.org (user of a WMF wiki); Using latest Firefox release if not otherwise noted. 2012-09-13 15:57:26 UTC --- Why does RL load gadget's CSS twice? One time it ships CSS with JavaScript and writing this into the DOM and one time CSS is delivered in a separate CSS file duplicating the style definitions. You can easily see it opening Firebug on Wikimedia Commons and inspecting an element that was created by one of our Gadgets that both consist of a JavaScript and CSS (e.g. the slideshow start button) * Is this intended behaviour? * Is this documented (except in your source files that I can't search any more since Krinkle's SVN search is down)? * Are there intentions to optimise this issue? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] Resource Loader loads CSS multiple times
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 --- Comment #10 from Roan Kattouw 2012-09-24 16:58:52 UTC --- (In reply to comment #9) > Why does RL load gadget's CSS twice? One time it ships CSS with JavaScript and > writing this into the DOM and one time CSS is delivered in a separate CSS file > duplicating the style definitions. You can easily see it opening Firebug on > Wikimedia Commons and inspecting an element that was created by one of our > Gadgets that both consist of a JavaScript and CSS (e.g. the slideshow start > button) > This behavior was apparently introduced in November 2011 to make Gadget CSS load on time. > * Is this intended behaviour? Ideally the CSS wouldn't be loaded twice, no. The reason it's currently done is to work around the fact that you can't currently set the position=top property on a Gadget to make it load before the page renders. > * Is this documented (except in your source files that I can't search any more > since Krinkle's SVN search is down)? No. > * Are there intentions to optimise this issue? The rewrite of the Gadgets extension in the RL2 branch fixes this by only bundling the CSS with the JS, rather than loading it separately. This does mean that, unless position=top is set in the Gadget properties, the CSS will load after the page renders, right before the JS executes. This is fine if you're only styling things that your JS creates, but it's ugly if you're styling things that MediaWiki puts on the page. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] Resource Loader loads CSS multiple times
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 --- Comment #11 from Roan Kattouw 2012-09-24 17:01:52 UTC --- (In reply to comment #10) > (In reply to comment #9) > > Why does RL load gadget's CSS twice? One time it ships CSS with JavaScript > > and > > writing this into the DOM and one time CSS is delivered in a separate CSS > > file > > duplicating the style definitions. You can easily see it opening Firebug on > > Wikimedia Commons and inspecting an element that was created by one of our > > Gadgets that both consist of a JavaScript and CSS (e.g. the slideshow start > > button) > > > This behavior was apparently introduced in November 2011 to make Gadget CSS > load on time. > bug 40284 has been filed for this, linking this response from there. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] Resource Loader loads CSS multiple times
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 Reedy changed: What|Removed |Added Summary|Resource Loader loads CSS |Resource Loader loads CSS |multiplie times |multiple times -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] Resource Loader loads CSS multiple times
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 Mark A. Hershberger changed: What|Removed |Added Priority|Unprioritized |Normal CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] Resource Loader loads CSS multiple times
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 Subfader changed: What|Removed |Added Severity|normal |major --- Comment #6 from Subfader 2011-07-18 16:03:29 UTC --- It's so buggy MW 1.17.0 is NOT stable! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] Resource Loader loads CSS multiple times
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693
Michael Plasmeier (ThePlaz) changed:
What|Removed |Added
CC||p...@theplaz.com
--- Comment #7 from Michael Plasmeier (ThePlaz) 2011-07-20
04:53:22 UTC ---
I had the same issue on my heavily customized wiki with my custom skin.
(http://theplaz.com)
I hacked a fix by commenting out the loop in OutputPage::buildCssLinks
//foreach ( array( 'site', 'private', 'user' ) as $group ) {
$ret .= $this->makeResourceLoaderLink($sk, array_merge( $styles['site'],
$styles['user'] ), 'styles');
//}
The sites and users scripts are all loaded at once, so commenting out the
foreach does not remove functionality.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29693] Resource Loader loads CSS multiple times
https://bugzilla.wikimedia.org/show_bug.cgi?id=29693 --- Comment #8 from Subfader 2011-07-20 16:15:45 UTC --- Thanks, that works. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
