[Bug 30294] CSS @import should support relative urls on secure server

2011-10-06 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

darklama darkl...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #20 from darklama darkl...@gmail.com 2011-10-06 16:22:35 UTC ---
This now appears to be working for mediawiki 1.18 when using
https://en.wikibooks.org as was described in comment #2

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-15 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

duplicate...@googlemail.com changed:

   What|Removed |Added

 CC||duplicate...@googlemail.com

--- Comment #19 from duplicate...@googlemail.com 2011-08-15 19:04:12 UTC ---
This is a problem due to the configuration.

You have the same problem with javascript, but when loading javascript you can
use $wgScript, which has the right value in case of the secure server. When
using $wgScript you avoid the hardcoded /w/index.php.

But in style sheets you cannot use $wgScript, you have no change to make a
different import statement for http/https with the current configuration of WMF
wikis. You can load the style sheets per javascript.

It is not a bug, because under https://secure.wikimedia.org/w/index.php are
nothing (that is the 404), because you find the content under
https://secure.wikimedia.org/wikipedia/commons/w/index.php.

You want an enhancement for the ResourceLoader: Supporting a simple syntax for
$wgScript in import statements of style sheets.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-14 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #16 from Krinkle krinklem...@gmail.com 2011-08-14 12:56:31 UTC ---
Did a little research on commonswiki:

1) When loaded through http://commons.wikimedia.org

- The site-css module is loaded through the following url:
http://bits.wikimedia.org/commons.wikimedia.org/load.php?debug=falselang=enmodules=siteonly=stylesskin=vector

- @import url(/w/index.php
  was expanded to 
  @import url(http://commons.wikimedia.org/w/index.php

2) When loaded through https://secure.wikimedia.org/wikipedia/commons/wiki

- The site-css module is loaded through the following url:
https://secure.wikimedia.org/wikipedia/commons/w/load.php?debug=falselang=enmodules=siteonly=stylesskin=vector

- @import url(/w/index.php
  was expanded to
  @import url(https://secure.wikimedia.org/w/index.php

3) When loaded through the experimental https://commons.wikimedia.org it's the
same as 1)
- site-css from bits
- expanded to http (not https)://commons.wikimedia.org/w/index.php

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-14 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #17 from Roan Kattouw roan.katt...@gmail.com 2011-08-14 12:58:47 
UTC ---
(In reply to comment #16)
 3) When loaded through the experimental https://commons.wikimedia.org it's the
 same as 1)
 - site-css from bits
 - expanded to http (not https)://commons.wikimedia.org/w/index.php
That's a bug, but it's probably due to commonswiki not having a
protocol-relative $wgServer. Could you try this one on wikimania2005wiki and
see what you get there?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-14 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #18 from Krinkle krinklem...@gmail.com 2011-08-14 13:24:20 UTC ---
(In reply to comment #17)
 That's a bug, but it's probably due to commonswiki not having a
 protocol-relative $wgServer. Could you try this one on wikimania2005wiki and
 see what you get there?

3) When loaded through the experimental https://test.wikipedia.org:
- site-css from https://bits
- expanded to https://test.wikipedia.org/w/index.php
- wgServer: //test.wikipedia.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-13 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

Roan Kattouw roan.katt...@gmail.com changed:

   What|Removed |Added

 CC||aschulz4...@gmail.com

--- Comment #14 from Roan Kattouw roan.katt...@gmail.com 2011-08-13 11:24:48 
UTC ---
CC Aaron Schulz, who's doing the het deploy stuff.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-13 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #15 from mybugs.m...@gmail.com 2011-08-13 11:50:45 UTC ---
FYI: The problem is also happening on Wikimedia Commons, since
[[commons:MediaWiki:Common.css]] has the following:

@import
url(/w/index.php?title=MediaWiki:Common.css/Mboxes.cssaction=rawctype=text/css)
screen;


This causes Chromium 12.0.742.112 (90304) Ubuntu 11.04 to display in the error
console:

Failed to load resource: the server responded with a status of 404 (Not Found)


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #8 from darklama darkl...@gmail.com 2011-08-12 17:34:53 UTC ---
(In reply to comment #7)
 So I guess what happened is that it was using relative URLs before, which RL
 broke, then people switched to using path-absolute URLs (like
 /w/index.php?...), which broke on secure?

What happened as I understand is all the skin related stuff in
/skins-1.5/ that use to be duplicated for each wiki was centralized
to bits.wikimedia.org and a load.php script was introduced to
bits.wikimedia.org that also loaded the site wide and skin specific
CSS and JavaScript for the target wiki and user. Relative URLs like
/w/index.php in MediaWiki:Common.css and in other places began to
point to bits.wikimedia.org/w/index.php instead which broke Relative
URLs completely. URL rewriting of relative URLs like /w/index.php
into absolute URLs like http://en.wikibooks.org/w/index.php and
http://secure.wikimedia.org/wikibooks/en/w/index.php fixed this.

Now for some reason relative URL rewriting has /w/index.php
pointing to http://secure.wikimedia.org/w/index.php when
using secure.wikimedia.org to browse a wiki. This broke
relative URL rewriting on secure.

I hope this answers that question.

 How recently did this start breaking?

AFAIK it broke August 9th 2011, the same day it was first reported
at Wikibooks and to Bugzilla. However due to browser caching
could maybe have been as long as July 9th 2011.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #9 from darklama darkl...@gmail.com 2011-08-12 17:37:25 UTC ---
(In reply to comment #7)
 then people switched to using path-absolute URLs (like
 /w/index.php?...), which broke on secure?

In case I misunderstood this part. We didn't do anything
at Wikibooks, /w/index.php just stopped working on secure.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #10 from Krinkle krinklem...@gmail.com 2011-08-12 17:39:43 UTC ---
 URL rewriting of relative URLs like /w/index.php
 into absolute URLs like http://en.wikibooks.org/w/index.php and
 http://secure.wikimedia.org/wikibooks/en/w/index.php fixed this.

Afaik, such rewriting has never and does not exist in ResourceLoader for
@import.

I know that for a certain amount of time wikibooks switched to using _absolute_
urls in their @imports, they probably switched away from it since it would
generate http requests on httpS pages, which then broke it again (but only on
secure, so perhaps nobody noticed until recently).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #11 from darklama darkl...@gmail.com 2011-08-12 18:10:59 UTC ---
(In reply to comment #10)
 Afaik, such rewriting has never and does not exist in ResourceLoader for
 @import.

Maybe /includes/libs/CSSMin.php isn't considered part of ResourceLoader
any more. I know it was originally part of the ResourceLoader branch
though as the SVN revision history shows. [1]

 I know that for a certain amount of time wikibooks switched to using 
 _absolute_
 urls in their @imports, they probably switched away from it since it would
 generate http requests on httpS pages, which then broke it again (but only on
 secure, so perhaps nobody noticed until recently).

Yes Wikibooks switched from relative to absolute URLs for a short while back in 
February 2011 when bug 27328 was first noticed. Wikibooks switched back when
the fix was introduced. I made sure the fix actually worked myself both
for http and for https secure by deleting my browser cache and checking
where firebug was looking for the @import requests. This isn't a case
of not noticing it was broke for 6 months. That much I am sure about.

[1]
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/libs/CSSMin.php?view=logpathrev=82457

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #12 from Roan Kattouw roan.katt...@gmail.com 2011-08-12 18:55:33 
UTC ---
Hmm, I'm wondering whether it's possible that the recent het deploy changes
changed what $wgServer is on secure?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #13 from darklama darkl...@gmail.com 2011-08-12 19:53:13 UTC ---
(In reply to comment #12)
 Hmm, I'm wondering whether it's possible that the recent het deploy changes
 changed what $wgServer is on secure?

That sounds like a plausible explanation to me. I haven't been able to find
another explanation yet by looking through code revisions.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-10 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-10 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #7 from Roan Kattouw roan.katt...@gmail.com 2011-08-10 16:18:21 
UTC ---
(In reply to comment #6)
 Well perhaps this wasn't fully understood by the
 report for bug 27328, but relative URLs did work
 just fine for secure.wikimedia.org prior to 1.17,
 ResourceLoader, and load.php as well. The fix
 that was introduced by bug 27328 had made
 relative URLs for secure.wikimedia.org work as
 well again.
 
So I guess what happened is that it was using relative URLs before, which RL
broke, then people switched to using path-absolute URLs (like
/w/index.php?...), which broke on secure?

 This wasn't broken the whole time. Something
 recent caused it to stop working just for
 secure.wikimedia.org.
By 'the whole time' I meant 'since bug 27328 was fixed'. How recently did this
start breaking?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-09 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

darklama darkl...@gmail.com changed:

   What|Removed |Added

Summary|CSS @import should support  |CSS @import should support
   |relative urls   |relative urls on secure
   ||server

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-09 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

Roan Kattouw roan.katt...@gmail.com changed:

   What|Removed |Added

 Depends on||27946

--- Comment #4 from Roan Kattouw roan.katt...@gmail.com 2011-08-09 16:44:01 
UTC ---
(In reply to comment #3)
 See bug 27328 which had previously addressed and fixed this issue when
 ResourceLoader and load.php were first introduced. Could be considered a
 regression.
It's not a regression, it's a different case (secure.wm.o-specific) that was
probably broken the whole time. The two bugs appear related, but they're not
related in the way you think they are.

I'm leaving this open because it is a legitimate bug (something is broken), but
making it a dependency of the HTTPS tracking bug. Once proper HTTPS is set up
and secure dies, this'll be fixed.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-09 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 Depends on|27946   |

--- Comment #5 from Krinkle krinklem...@gmail.com 2011-08-09 16:45:29 UTC ---
No bug 27328 not related at all.

'/' means the root of a domain.

Loading @import('/w/index.php ...'); works just fine.

When you're on en.wikibooks.org, it loads: en.wikibooks.org/w/index.php.

The problem is that, when you're on secure.wikimedia.org/wikibooks/en/, since /
refers to the root of the domain (this is a general HTML/CSS rule, not related
to ResourceLoaderor @import specifically), it loads:

secure.wikimedia.org/w/index.php (which doesn't exist).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-09 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 Blocks||27946

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30294] CSS @import should support relative urls on secure server

2011-08-09 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=30294

--- Comment #6 from darklama darkl...@gmail.com 2011-08-09 17:26:47 UTC ---
(In reply to comment #4)
 It's not a regression, it's a different case (secure.wm.o-specific) that was
 probably broken the whole time. The two bugs appear related, but they're not
 related in the way you think they are.

(In reply to comment #5)
 No bug 27328 not related at all.
 
 '/' means the root of a domain.
 
 Loading @import('/w/index.php ...'); works just fine.
 
 When you're on en.wikibooks.org, it loads: en.wikibooks.org/w/index.php.
 
 The problem is that, when you're on secure.wikimedia.org/wikibooks/en/, since 
 /
 refers to the root of the domain (this is a general HTML/CSS rule, not related
 to ResourceLoaderor @import specifically), it loads:
 
 secure.wikimedia.org/w/index.php (which doesn't exist).

Well perhaps this wasn't fully understood by the
report for bug 27328, but relative URLs did work
just fine for secure.wikimedia.org prior to 1.17,
ResourceLoader, and load.php as well. The fix
that was introduced by bug 27328 had made
relative URLs for secure.wikimedia.org work as
well again.

This wasn't broken the whole time. Something
recent caused it to stop working just for
secure.wikimedia.org.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l