[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #19 from Jon jrob...@wikimedia.org 2012-04-02 20:03:45 UTC --- Okay thanks MZMcBride - this makes a ***lot*** more sense when looking at Wikipedia with the monobook theme thanks for clearing that up for me. Much appreciated. I believe I have a better fix for this - see https://gerrit.wikimedia.org/r/4122 which feels like a much cleaner solution to the problem and is documented and at least cleans up the problem MFE side (imo). I would suggest that Wikipedia.org should add a footer link to its configuration via a method outside the MediaWiki:Wikimedia-copyright page - am not sure if this can be done already - Daniel Friesen suggests that it might be but if not could someone who understands this more than me open a new bug? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #20 from MZMcBride b...@mzmcbride.com 2012-04-03 03:38:10 UTC --- A bit strange to use an HTML comment instead of a PHP comment (the former now displays in the HTML source), but other than that, this seems to be acceptable. Thanks for your work on this! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #17 from Jon jrob...@wikimedia.org 2012-03-30 09:15:11 UTC --- Why cannot Wikipedia Admins fix this? I don't know why on this page it needs to use a new list item when instead it could use other html markup in this instance. My suggestion in the talk page was: Please could we change /lili class=noprinta class='internal' href=//en.wikipedia.org/wiki/Wikipedia:Contact_usContact us/a We cannot assume that the copyright will always be printed in a list element - in the mobile site for instance it isn't and leads to invalid html (see https://bugzilla.wikimedia.org/show_bug.cgi?id=30406) I believe this has the following line has the same stylistic effect without leading to bad HTML elsewhere: p class=noprinta class=internal href=//en.wikipedia.org/wiki/Wikipedia:Contact_usContact us/a/p Is this not possible? We certainly don't want the undocumented hack above. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #18 from MZMcBride b...@mzmcbride.com 2012-03-30 13:31:36 UTC --- (In reply to comment #17) Why cannot Wikipedia Admins fix this? I don't know why on this page it needs to use a new list item when instead it could use other html markup in this instance. My suggestion in the talk page was: Please could we change /lili class=noprinta class='internal' href=//en.wikipedia.org/wiki/Wikipedia:Contact_usContact us/a We cannot assume that the copyright will always be printed in a list element - in the mobile site for instance it isn't and leads to invalid html (see https://bugzilla.wikimedia.org/show_bug.cgi?id=30406) I believe this has the following line has the same stylistic effect without leading to bad HTML elsewhere: p class=noprinta class=internal href=//en.wikipedia.org/wiki/Wikipedia:Contact_usContact us/a/p Is this not possible? Look at the page in Monobook, silly. (And re-read some of the previous comments on this bug regarding why it's using an li. It's fully explained.) We certainly don't want the undocumented hack above. Sure, so remove it. That has nothing to do with English Wikipedia administrators, though. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED CC||jrob...@wikimedia.org Resolution||WONTFIX --- Comment #13 from Jon jrob...@wikimedia.org 2012-03-29 10:49:31 UTC --- So as I understand it the problem lies outside MobileFrontend. The issue is that the copyright text is printed inside a li element (#footer-info-copyright) The page does a html hack to create another list item containing a contact link (http://en.wikipedia.org/wiki/MediaWiki:Wikimedia-copyright) This is becoming less important with the footer redesign and also I see this as an issue that Wikipedia admins must address (I've said so on the talk page - http://en.wikipedia.org/wiki/MediaWiki_talk:Wikimedia-copyright#Footer_invalid_html) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #14 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com 2012-03-29 19:02:26 UTC --- (In reply to comment #13) So as I understand it the problem lies outside MobileFrontend. The issue is that the copyright text is printed inside a li element (#footer-info-copyright) The page does a html hack to create another list item containing a contact link (http://en.wikipedia.org/wiki/MediaWiki:Wikimedia-copyright) This is becoming less important with the footer redesign and also I see this as an issue that Wikipedia admins must address (I've said so on the talk page - http://en.wikipedia.org/wiki/MediaWiki_talk:Wikimedia-copyright#Footer_invalid_html) Wikipedia admins cannot fix this issue. They don't have the ability to add new list items. Someone needs to make a configuration change to Wikimedia's setup to allow them to have a separate list item for that. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 MZMcBride b...@mzmcbride.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX | --- Comment #15 from MZMcBride b...@mzmcbride.com 2012-03-29 23:17:18 UTC --- (In reply to comment #13) So as I understand it the problem lies outside MobileFrontend. The issue is that the copyright text is printed inside a li element (#footer-info-copyright) The page does a html hack to create another list item containing a contact link (http://en.wikipedia.org/wiki/MediaWiki:Wikimedia-copyright) This is becoming less important with the footer redesign and also I see this as an issue that Wikipedia admins must address (I've said so on the talk page - http://en.wikipedia.org/wiki/MediaWiki_talk:Wikimedia-copyright#Footer_invalid_html) Re-opening this for now. At the http://en.m.wikipedia.org, we now see the following code: --- div id='copyright'ul id=footer-infoliText is available under the a rel=license href=//en.wikipedia.org/wiki/Wikipedia:Text_of_Creative_Commons_Attribution-ShareAlike_3.0_Unported_LicenseCreative Commons Attribution-ShareAlike License/aa rel=license href=//creativecommons.org/licenses/by-sa/3.0/ style=display:none;/a; additional terms may apply. See a href=//wikimediafoundation.org/wiki/Terms_of_useTerms of use/a for details.br/ Wikipediareg; is a registered trademark of the a href=//www.wikimediafoundation.org/Wikimedia Foundation, Inc./a, a non-profit organization.br //lili class=noprinta class='internal' href=//en.wikipedia.org/wiki/Wikipedia:Contact_usContact us/a/li/ul/div /div --- This looks better. There's now a closing /li and a closing /ul However, https://en.wikipedia.org/wiki/MediaWiki:Wikimedia-copyright hasn't been changed, so the question becomes: where did these tags come from? I haven't had a chance to investigate this. I have suspicions about the current behavior, but I'm re-opening the bug for now. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406
--- Comment #16 from MZMcBride b...@mzmcbride.com 2012-03-29 23:37:30 UTC ---
(In reply to comment #15)
This looks better. There's now a closing /li and a closing /ul However,
https://en.wikipedia.org/wiki/MediaWiki:Wikimedia-copyright hasn't been
changed, so the question becomes: where did these tags come from?
I haven't had a chance to investigate this. I have suspicions about the
current
behavior, but I'm re-opening the bug for now.
Uhh, right. So there's this lovely bit of code from r100057, r100059, and
r102441:
---
$copyright = $skin-getCopyright();
if ( stristr( $copyright, 'li class=noprint' ) !== false ) {
$copyright = 'ul id=footer-infoli' . $copyright .
'/li/ul';
}
---
This is a hack (and an undocumented one at that). This should be properly
addressed in the MobileFrontend extension.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed: What|Removed |Added CC||mediawiki-bugs@nadir-seen-f ||ire.com --- Comment #12 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com 2011-08-25 00:22:01 UTC --- I should mention that it is possible to change the footerlinks list: Use the SkinTemplateOutputPageBeforeExec to modify either the info or places array of the footerlinks $tpl key adding a new tpl key to it. And $tpl-set the key you added. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 Tomasz Finc tf...@wikimedia.org changed: What|Removed |Added Blocks||30512 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #1 from Patrick Reilly prei...@wikimedia.org 2011-08-22 21:54:54 UTC --- This content comes from the following call: $skin = $wgUser-getSkin(); $copyright = $skin-getCopyright(); So, it's not directly from the Mobile Frontend extension. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #2 from Reedy s...@reedyboy.net 2011-08-22 22:43:05 UTC --- I only get div id=copyrightText is available under the a href=http://creativecommons.org/licenses/by-sa/3.0/;Creative Commons Attribution/Share-Alike License/a; additional terms may apply. See a href=http://wikimediafoundation.org/wiki/Terms_of_Use;Terms of Use/a for details./div http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Skin.php?view=annotate#l721 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #3 from Patrick Reilly prei...@wikimedia.org 2011-08-22 22:53:47 UTC --- I see the following on en.wikipedia.org: div id=copyrightText is available under the a rel=license href=http://en.wikipedia.org/wiki/Wikipedia:Text_of_Creative_Commons_Attribution-ShareAlike_3.0_Unported_License;Creative Commons Attribution-ShareAlike License/aa rel=license href=http://creativecommons.org/licenses/by-sa/3.0/; style=display:none;/a; additional terms may apply. See a href=http://wikimediafoundation.org/wiki/Terms_of_use;Terms of use/a for details.br Wikipedia® is a registered trademark of the a href=http://www.wikimediafoundation.org/;Wikimedia Foundation, Inc./a, a non-profit organization.brli class=noprinta class=internal href=http://en.wikipedia.org/wiki/Wikipedia:Contact_us;Contact us/a/li/div -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #4 from Reedy s...@reedyboy.net 2011-08-22 22:55:47 UTC --- Ah, ok. So that's logged out, when you're logged in, you get what I pasted -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #5 from Patrick Reilly prei...@wikimedia.org 2011-08-22 22:59:11 UTC --- This content appears to come from the following page: http://en.wikipedia.org/wiki/MediaWiki:Wikimedia-copyright -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #6 from Reedy s...@reedyboy.net 2011-08-22 23:05:07 UTC --- So why do I get different? I'm using Vector, which is the site default skin, no custom JS or CSS, but I get a different copyright... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #7 from Patrick Reilly prei...@wikimedia.org 2011-08-22 23:13:03 UTC --- I've got no idea. I'm trying to figure that out right now. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #8 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com 2011-08-22 23:17:13 UTC --- This looks like a bug with Wikipedia config, nothing to do with core or extensions. https://secure.wikimedia.org/wikipedia/en/w/index.php?title=MediaWiki:Wikimedia-copyrightaction=edit It also appears to be a raw html outputting message, so I can't even argue that invalid li's like that should be wrapped automatically in a ul by the parser. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 Tomasz Finc tf...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|wikibugs-l@lists.wikimedia. |jalexan...@wikimedia.org |org | --- Comment #9 from Tomasz Finc tf...@wikimedia.org 2011-08-22 23:19:41 UTC --- Assigning to James Alexander who'll coordinate with the EN Admins about this change. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #10 from MZMcBride b...@mzmcbride.com 2011-08-23 03:24:07 UTC --- (In reply to comment #9) Assigning to James Alexander who'll coordinate with the EN Admins about this change. I talked to James tonight and poked at this bug briefly. Basically the English Wikipedia is using a hack to insert an extra list item element (li) into the footer, because they want a Contact us link down there, but there's no native support for adding a list item element to ul id=f-list. It looks like completely broken code, but in context, it makes much more sense: From http://en.wikipedia.org/wiki/Main_Page: ul id=f-list li id=lastmod This page was last modified on 26 July 2011 at 09:03.br //li li id=copyrightText is available under the a rel=license href=http://en.wikipedia.org/wiki/Wikipedia:Text_of_Creative_Commons_Attribution-ShareAlike_3.0_Unported_License;Creative Commons Attribution-ShareAlike License/aa rel=license href=http://creativecommons.org/licenses/by-sa/3.0/; style=display:none;/a; additional terms may apply. See a href=http://wikimediafoundation.org/wiki/Terms_of_use;Terms of use/a for details.br/ Wikipediareg; is a registered trademark of the a href=http://www.wikimediafoundation.org/;Wikimedia Foundation, Inc./a, a non-profit organization.br //lili class=noprinta class='internal' href=http://en.wikipedia.org/wiki/Wikipedia:Contact_us;Contact us/a/li li id=privacya href=http://wikimediafoundation.org/wiki/Privacy_policy; title=wikimedia:Privacy policyPrivacy policy/a/li li id=abouta href=/wiki/Wikipedia:About title=Wikipedia:AboutAbout Wikipedia/a/li li id=disclaimera href=/wiki/Wikipedia:General_disclaimer title=Wikipedia:General disclaimerDisclaimers/a/li li id=mobileviewa href='/w/index.php?title=Main_Pageamp;useformat=mobile'Mobile view/a/li /ul In context, it gets wrapped properly with ul, it ends the copyright's li, and then inserts a Contact us li. I don't know if a bug already exists, but there should be native support for adding a list item to the footer list items. Then this horrible hack can be killed properly. MobileFrontend doesn't really need to be changed here (and shouldn't be!) and isn't really to blame, this is simply a lack of functionality in MediaWiki core that the English Wikipedia is trying to work around (by abusing raw HTML...). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 --- Comment #11 from MZMcBride b...@mzmcbride.com 2011-08-23 03:26:03 UTC --- (In reply to comment #2) I only get div id=copyrightText is available under the a href=http://creativecommons.org/licenses/by-sa/3.0/;Creative Commons Attribution/Share-Alike License/a; additional terms may apply. See a href=http://wikimediafoundation.org/wiki/Terms_of_Use;Terms of Use/a for details./div http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Skin.php?view=annotate#l721 Logged in while visiting what URL? In what browser? And have you opted in to anything mobile-related? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30406] MobileFrontend extension outputting invalid HTML in footer
https://bugzilla.wikimedia.org/show_bug.cgi?id=30406 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |Low CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
