[Bug 30709] Pass error info to error callbacks in mw.loader
https://bugzilla.wikimedia.org/show_bug.cgi?id=30709 Krinkle changed: What|Removed |Added Keywords|need-review |reviewed Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #7 from Krinkle 2011-12-27 02:44:36 UTC --- Patch applied in r107358. Also fixed it for another usage of error() that didn't pass any info. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30709] Pass error info to error callbacks in mw.loader
https://bugzilla.wikimedia.org/show_bug.cgi?id=30709 Sumana Harihareswara changed: What|Removed |Added Keywords||need-review, patch --- Comment #6 from Sumana Harihareswara 2011-12-23 19:21:36 UTC --- Adding back the patch & need-review keywords since the patch still awaits review -- Timo, will you be getting to this in the next few months, or should we unassign it from you? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30709] Pass error info to error callbacks in mw.loader
https://bugzilla.wikimedia.org/show_bug.cgi?id=30709 Krinkle changed: What|Removed |Added Keywords|need-review, patch | Status|NEW |ASSIGNED CC|krinklem...@gmail.com | AssignedTo|wikibugs-l@lists.wikimedia. |krinklem...@gmail.com |org | --- Comment #5 from Krinkle 2011-10-02 17:12:47 UTC --- OK. Assigning to self. Will do early next week. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30709] Pass error info to error callbacks in mw.loader
https://bugzilla.wikimedia.org/show_bug.cgi?id=30709 --- Comment #4 from Michael Dale 2011-09-30 17:33:27 UTC --- Krinkle should just directly commit some variation that handles the use cases discussed on IRC and this bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30709] Pass error info to error callbacks in mw.loader
https://bugzilla.wikimedia.org/show_bug.cgi?id=30709 Sumana Harihareswara changed: What|Removed |Added Keywords||need-review, patch CC||suma...@panix.com --- Comment #3 from Sumana Harihareswara 2011-09-30 16:00:45 UTC --- Added the "patch" and "need-review" keywords; Mark hopes to get someone to review the patch soon. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30709] Pass error info to error callbacks in mw.loader
https://bugzilla.wikimedia.org/show_bug.cgi?id=30709 Krinkle changed: What|Removed |Added Severity|normal |enhancement -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30709] Pass error info to error callbacks in mw.loader
https://bugzilla.wikimedia.org/show_bug.cgi?id=30709 Krinkle changed: What|Removed |Added Blocks||29097 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30709] Pass error info to error callbacks in mw.loader
https://bugzilla.wikimedia.org/show_bug.cgi?id=30709 Mark A. Hershberger changed: What|Removed |Added Priority|Unprioritized |Normal CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30709] Pass error info to error callbacks in mw.loader
https://bugzilla.wikimedia.org/show_bug.cgi?id=30709 --- Comment #2 from Michael Dale 2011-09-02 22:22:50 UTC --- Yes we should fix both. Also note that passing in module name is not so useful since the closure scope just gives you the last instance of module when the error is called ( rather than the module in which the error occurred ) ... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30709] Pass error info to error callbacks in mw.loader
https://bugzilla.wikimedia.org/show_bug.cgi?id=30709
Krinkle changed:
What|Removed |Added
CC||krinklem...@gmail.com
Summary|pass error info to loading |Pass error info to error
|decency error handlers |callbacks in mw.loader
--- Comment #1 from Krinkle 2011-09-02 20:58:32 UTC ---
There is another call to error in mw.loader.using,
// If any dependencies have errors execute error immediately
else if ( filter( ['error'], dependencies ).length ) {
if ( $.isFunction( error ) ) {
error();
}
}
Perhaps fix that one too.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
