[Bug 30914] user.tokens and user.options are implemented too late, modules can't depend on them
https://bugzilla.wikimedia.org/show_bug.cgi?id=30914 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC|krinklem...@gmail.com | Version|1.19-svn|1.17.0 AssignedTo|roan.katt...@gmail.com |krinklem...@gmail.com Target Milestone|--- |1.19.0 release --- Comment #3 from Krinkle krinklem...@gmail.com 2011-12-28 21:47:54 UTC --- Okay, so no issues left to resolve. Looks like first usage has come along. mw.Api module is using this as of r107350. I'll go ahead and move those to the head and see what happens. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30914] user.tokens and user.options are implemented too late, modules can't depend on them
https://bugzilla.wikimedia.org/show_bug.cgi?id=30914
--- Comment #2 from Roan Kattouw roan.katt...@gmail.com 2011-09-20 10:24:23
UTC ---
(In reply to comment #1)
yeah, that goes for any embedded module for that matter. Anything embedded in
the html cannot be removed from the 'load queue' since it's stuck in the HTML,
so it needs to be in the top of the document before the first loader.load.
Yup, that's right.
One thing to keep in mind though is that user.tokens depends on
'mediawiki.user' (obviously).
That's not a problem. If we load it inside an implement() call, normal
dependency resolution will take care of this.
We just need to verify that mw.loader.implement('user.tokens') doesn't do
anything (i.e. it should not trigger an ajax request to get 'mediawiki.user',
because 1) nobody asked for 'user.tokens', so no need to resolve dependencies,
2) because 'mediawiki.user' is expected to be in the next loader.load call
I'm not at all worried about that, that's fundamentally not what implement()
does. implement() means look here's the code for this new module, you may or
may not be able to run it now depending on the status of its dependencies.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30914] user.tokens and user.options are implemented too late, modules can't depend on them
https://bugzilla.wikimedia.org/show_bug.cgi?id=30914 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |Normal CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30914] user.tokens and user.options are implemented too late, modules can't depend on them
https://bugzilla.wikimedia.org/show_bug.cgi?id=30914
--- Comment #1 from Krinkle krinklem...@gmail.com 2011-09-17 01:49:52 UTC ---
yeah, that goes for any embedded module for that matter. Anything embedded in
the html cannot be removed from the 'load queue' since it's stuck in the HTML,
so it needs to be in the top of the document before the first loader.load.
One thing to keep in mind though is that user.tokens depends on
'mediawiki.user' (obviously).
We just need to verify that mw.loader.implement('user.tokens') doesn't do
anything (i.e. it should not trigger an ajax request to get 'mediawiki.user',
because 1) nobody asked for 'user.tokens', so no need to resolve dependencies,
2) because 'mediawiki.user' is expected to be in the next loader.load call
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30914] user.tokens and user.options are implemented too late, modules can't depend on them
https://bugzilla.wikimedia.org/show_bug.cgi?id=30914 Krinkle krinklem...@gmail.com changed: What|Removed |Added Blocks||29272 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
