[Bug 31176] {{SERVERNAME}} variable does not strip // for protocol relative urls
https://bugzilla.wikimedia.org/show_bug.cgi?id=31176 Ashar Voultoiz has...@free.fr changed: What|Removed |Added CC||has...@free.fr --- Comment #8 from Ashar Voultoiz has...@free.fr 2011-10-24 09:33:43 UTC --- Test added with r100592. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31176] {{SERVERNAME}} variable does not strip // for protocol relative urls
https://bugzilla.wikimedia.org/show_bug.cgi?id=31176
--- Comment #7 from Roan Kattouw roan.katt...@gmail.com 2011-09-27 09:55:57
UTC ---
(In reply to comment #6)
Thanks Roan. The buggy version is now live on Wikimedia servers. I hope your
fix will get through as fast as possible.
I helps if I run svn up before scapping :D
So I accidentally did not deploy this last night, but I did just now.
{{SERVERNAME}} now really works correctly on WMF wikis and the phishing site
messages are gone.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31176] {{SERVERNAME}} variable does not strip // for protocol relative urls
https://bugzilla.wikimedia.org/show_bug.cgi?id=31176 --- Comment #2 from Brion Vibber br...@wikimedia.org 2011-09-26 23:12:23 UTC --- Switching from parse_url() to wfParseUrl() should fix this, as it has workarounds specifically for those urls. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31176] {{SERVERNAME}} variable does not strip // for protocol relative urls
https://bugzilla.wikimedia.org/show_bug.cgi?id=31176 --- Comment #1 from Brion Vibber br...@wikimedia.org 2011-09-26 23:11:31 UTC --- Looks like parse_url sees the whole lot as just a path '//foobar', so the fallback behavior returns $wgServer as a whole. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31176] {{SERVERNAME}} variable does not strip // for protocol relative urls
https://bugzilla.wikimedia.org/show_bug.cgi?id=31176 --- Comment #3 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com 2011-09-26 23:12:56 UTC --- Just did a check. This would be a bug in parse_url, it doesn't understand protocol-relative urls, however wfParseUrl does understand protocol relatives. So the fix would be to use wfParseUrl instead of parse_url. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31176] {{SERVERNAME}} variable does not strip // for protocol relative urls
https://bugzilla.wikimedia.org/show_bug.cgi?id=31176 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #4 from Roan Kattouw roan.katt...@gmail.com 2011-09-26 23:13:35 UTC --- I have a fix, committing and deploying. It's long known to me that parse_url() is a piece of garbage and does not understand protocol-relative URLs. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31176] {{SERVERNAME}} variable does not strip // for protocol relative urls
https://bugzilla.wikimedia.org/show_bug.cgi?id=31176 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #5 from Roan Kattouw roan.katt...@gmail.com 2011-09-26 23:15:43 UTC --- Fixed in r98193, deploying. Needs a parser test or something, too, but it's past 1am so I'm not doing that now. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31176] {{SERVERNAME}} variable does not strip // for protocol relative urls
https://bugzilla.wikimedia.org/show_bug.cgi?id=31176 Huji huji.h...@gmail.com changed: What|Removed |Added CC||huji.h...@gmail.com --- Comment #6 from Huji huji.h...@gmail.com 2011-09-27 03:01:37 UTC --- Thanks Roan. The buggy version is now live on Wikimedia servers. I hope your fix will get through as fast as possible. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
