[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

Derk-Jan Hartman hart...@videolan.org changed:

   What|Removed |Added

 CC||hart...@videolan.org

--- Comment #8 from Derk-Jan Hartman hart...@videolan.org 2012-07-30 12:47:05 
UTC ---
I propose we implement the alternative Krinkle suggested in comment 5. Might be
most disruptive, but I think it will fit our future usecases better. It's more
likely we want to identify  the entire block of a heading, then a specific
heading elements inside the heading block.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

--- Comment #9 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com 
2012-07-30 12:57:37 UTC ---
(In reply to comment #8)
 I propose we implement the alternative Krinkle suggested in comment 5. Might 
 be
 most disruptive, but I think it will fit our future usecases better. It's more
 likely we want to identify  the entire block of a heading, then a specific
 heading elements inside the heading block.

Perhaps... though I should say. Semantically what we really want when we think
of an id is not the header but the whole section it encompass. ie: If it
weren't for the issues with doing so we should have a section element with
the id on it instead.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-06-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

Gabriel Wicke wi...@wikidev.net changed:

   What|Removed |Added

 CC||wi...@wikidev.net
   Target Milestone|--- |Future release

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-06-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com
   Target Milestone|Future release  |---

--- Comment #5 from Krinkle krinklem...@gmail.com 2012-06-03 14:57:28 UTC ---
Tim, Danny and I discussed this today at the Berlin Hackathon:

- Current HTML:

h#(wikitext attribs)
  (edit section link)
  span class=mw-headline id=(anchor based on heading title)(heading
title)/span
/h#


- Use cases:

1) Ability to jump to the headline from the hashtag. When the skin has a large
edit section link or positioned it as a block
2) Ability to style the currently hash-targetted heading with CSS :target
3) For screen readers and semantics, the edit section link should not be part
of the h#.


- Conclusions:

* We can't put the ID on the h#, because wikitext pages can (and do!) contain
html tags with an ID already (e.g. h3 id=awesomeThe Awesome Delivery of
Resources/h3). See Linker::makeHeadline

* We shouldn't put an empty span id=../span (or div) _before_ the h#.
Although that solves the jump issue, it still doesn't allow to easily select
the header from the :target selector.

* We can't put a span around the h#. Block element should not be in an inline
element.

* We *can* put an unstyled div around (not before) the h#. That solves all
three use cases. CSS styling is possible with :target h# { .. };. Also we
should then add the mw-headline class to the h#. Potentially it can have a
class already, but an element can have multiple classes. Note that in this case
the attributes have to be merged. With code 'class=y title=z  class=x'
the last one overrides the earlier.

- Proposed HTML:

div id=(anchor based on heading title)
  (edit section link)
h#(wikitext attribs) class=mw-headline
  (heading title)
/h#
/div

- Proposed HTML (alternative):

div class=mw-headline id=(anchor based on heading title)
  (edit section link)
h#(wikitext attribs)
  (heading title)
/h#
/div

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-06-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

--- Comment #6 from Tim Starling tstarl...@wikimedia.org 2012-06-03 14:59:51 
UTC ---
The motivating application for this request is to support a template on
cs.wikibooks.org which will be styled differently depending on whether it is
immediately after a heading. There is a proposal for the typical placement to
be changed, but they don't want to use a different template name, rather they
want to use some sort of sibling selector in site CSS to detect which placement
policy is in use in a given instance.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-06-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

--- Comment #7 from Krinkle krinklem...@gmail.com 2012-06-03 15:44:13 UTC ---
(In reply to comment #5)
 [..]
 3) For screen readers and semantics, the edit section link should not be part
 of the h#.
 [..]

case 3 is also reported as bug 11555.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-01-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

   Keywords|accessibility   |
   Priority|Normal  |Low
   Target Milestone|1.19wmf deployment  |Mysterious future

--- Comment #4 from Krinkle krinklem...@gmail.com 2012-01-24 03:20:55 UTC ---
Removing 1.19wmf1 milestone blocker. Not a high priority for 1.19 completion

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-01-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

   Priority|Low |Normal
   Severity|normal  |enhancement

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-01-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

Danny B. dann...@email.cz changed:

   What|Removed |Added

 CC||subfa...@gmail.com

--- Comment #2 from Danny B. dann...@email.cz 2012-01-02 15:32:04 UTC ---
*** Bug 33415 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-01-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

Danny B. dann...@email.cz changed:

   What|Removed |Added

 AssignedTo|wikibugs-l@lists.wikimedia. |krinklem...@gmail.com
   |org |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-01-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

--- Comment #3 from Subfader subfa...@gmail.com 2012-01-02 15:38:46 UTC ---
Not sure if this is proper HTML:

h2span class=editsection.../span span id=License
class=mw-headlineLicense/span/h2

Correct would be to add the id to the h2-tga instead:
h2 id=Licensespan class=editsection.../span span
class=mw-headlineLicense/span/h2

It becomes a problem when you use the CSS3 pseudo selector :target to style the
background:

*:target  { background-color:#fffddf !important }

http://i.imgur.com/I7uwr.png

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2012-01-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

Danny B. dann...@email.cz changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2011-11-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

--- Comment #1 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com 
2011-11-07 17:58:23 UTC ---
Why is this tagged accessibility?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 31932] The headline id should belong to h# tag and not to inner span

2011-10-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=31932

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
   Target Milestone|1.18 tarball release|1.19 deployment
   Severity|normal  |enhancement

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l