[Bug 32751] Special:ListGroupRights says sysops can add Autochecked users even when $wgFlaggedRevsAutoconfirm is false

2011-12-10 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=32751

Aaron Schulz aschulz4...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Aaron Schulz aschulz4...@gmail.com 2011-12-11 04:35:57 
UTC ---
Fixed in r105872. The group now exists by default. If wikis don't want it to
even be addable/removable, then the add/remove rights config can be set
accordingly.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 32751] Special:ListGroupRights says sysops can add Autochecked users even when $wgFlaggedRevsAutoconfirm is false

2011-12-05 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=32751

--- Comment #1 from Aaron Schulz aschulz4...@gmail.com 2011-12-06 05:00:21 
UTC ---
(In reply to comment #0)
 The group 'autoreview' is only created when $wgFlaggedRevsAutoconfirm is an
 array; the default is false. But since r100327 (fixing bug 31441), the
 'autoreview' group is unconditionally added to $wgAddGroups['sysop'] and
 $wgRemoveGroups['sysop'], leading to this nonexistent group being listed on
 Special:ListGroupRights.
 
 IMO, the best fix would be to make the $wgAddGroups['sysop'] and
 $wgRemoveGroups['sysop'] entries conditional on $wgFlaggedRevsAutoconfirm.

That would then override any LocalSettings changes to the contrary, which is
worse.

I might makes sense to always define the group, regardless of
$wgFlaggedRevsAutoconfirm.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l