[Bug 32792] Proofread Page extension inconsistently expects escaped spaces in namespaces
https://bugzilla.wikimedia.org/show_bug.cgi?id=32792 --- Comment #5 from Mark A. Hershberger m...@everybody.org 2011-12-13 13:57:08 UTC --- I would like to apply this patch. When I ran the parser and unit tests, it didn't cause a problem. However, I would like to have some tests to add for this new functionality. Would you write some? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32792] Proofread Page extension inconsistently expects escaped spaces in namespaces
https://bugzilla.wikimedia.org/show_bug.cgi?id=32792 --- Comment #6 from Mark A. Hershberger m...@everybody.org 2011-12-13 14:11:50 UTC --- (In reply to comment #5) I would like to apply this patch. When I ran the parser and unit tests, it didn't cause a problem. However, I would like to have some tests to add for this new functionality. Would you write some? Just realized ProofReadPage doesn't have any tests currently. Doh! Applied in r106021 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32792] Proofread Page extension inconsistently expects escaped spaces in namespaces
https://bugzilla.wikimedia.org/show_bug.cgi?id=32792 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32792] Proofread Page extension inconsistently expects escaped spaces in namespaces
https://bugzilla.wikimedia.org/show_bug.cgi?id=32792 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords||i18n CC||suma...@panix.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32792] Proofread Page extension inconsistently expects escaped spaces in namespaces
https://bugzilla.wikimedia.org/show_bug.cgi?id=32792 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords||need-unittest -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32792] Proofread Page extension inconsistently expects escaped spaces in namespaces
https://bugzilla.wikimedia.org/show_bug.cgi?id=32792 --- Comment #2 from Minh Nguyễn m...@1ec5.org 2011-12-06 19:21:19 UTC --- Some of the shared Wikisource scripts, such as [[OldWikisource:PageNumbers.js]], depend on the Proofread Page extension loading the ext.proofreadpage.article module. In case anyone uses the Vietnamese Wikisource to investigate this issue, please note that we've added a hacky JavaScript workaround to load the module and add the Source tab ourselves, but the quality bar and index pages are actually still broken. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32792] Proofread Page extension inconsistently expects escaped spaces in namespaces
https://bugzilla.wikimedia.org/show_bug.cgi?id=32792 --- Comment #3 from Minh Nguyễn m...@1ec5.org 2011-12-06 23:29:58 UTC --- Created attachment 9626 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9626 Patch for calls to MWNamespace::getCanonicalIndex() This patch modifies all calls to MWNamespace::getCanonicalIndex() to not only lowercase the namespace name but also replace spaces with underscores. getCanonicalIndex() appears to be the only problematic API used by this extension. This is my first patch; please be gentle. :-) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32792] Proofread Page extension inconsistently expects escaped spaces in namespaces
https://bugzilla.wikimedia.org/show_bug.cgi?id=32792 Minh Nguyễn m...@1ec5.org changed: What|Removed |Added Keywords||need-review, patch --- Comment #4 from Minh Nguyễn m...@1ec5.org 2011-12-06 23:37:01 UTC --- Adding the patch and need-review keywords so a developer can take a look. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32792] Proofread Page extension inconsistently expects escaped spaces in namespaces
https://bugzilla.wikimedia.org/show_bug.cgi?id=32792 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Normal |High -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32792] Proofread Page extension inconsistently expects escaped spaces in namespaces
https://bugzilla.wikimedia.org/show_bug.cgi?id=32792 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |Normal CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 32792] Proofread Page extension inconsistently expects escaped spaces in namespaces
https://bugzilla.wikimedia.org/show_bug.cgi?id=32792 Minh Nguyễn m...@1ec5.org changed: What|Removed |Added Severity|normal |major --- Comment #1 from Minh Nguyễn m...@1ec5.org 2011-12-05 20:28:48 UTC --- It's worse than that, actually: if the namespace messages use underscores, index pages like [[s:vi:Mục lục:Viet Nam Su Luoc 1.djvu]] no longer turn pagelist into a color-coded sea of Page: links, because renderPageList()'s call to getPageAndIndexNamespace() comes back empty-handed. As a result, prepareArticle() fails to add a Source tab to articles, because prepareArticle() can't find the Index: page that links to the same Page: as the article. The Source tab was previously working at the Vietnamese Wikisource because the Index: pages hadn't been purged following our switch to underscores. The outdated pagelinks table happened to contain entries for Mục lục: So Vietnamese-language wikis are left with two choices: either use spaces and get working Index: pages, or use underscores and get the quality bar on articles. Either way, we can't get a Source tab. Raising the severity to major because this breaks Wikisource's workflow. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
