[Bug 33052] Escape wikitext tags written by hand in VisualEditor interface

2012-06-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

--- Comment #14 from Liangent liang...@gmail.com 2012-06-23 09:25:38 UTC ---
(In reply to comment #9)
 The Parsoid serializer tokenizes all text content from the DOM and wraps all
 non-text tokens (any wiki or html syntax) into nowiki blocks.

One more thing is ampersands: nowiki doesn't work on them.

http://www.mediawiki.org/w/index.php?title=Project:Sandboxdiff=554116oldid=553897
This is rendered as 

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand in VisualEditor interface

2012-06-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

Gabriel Wicke wi...@wikidev.net changed:

   What|Removed |Added

 CC||ssas...@wikimedia.org
  Component|Data Model  |Parser/Parsoid
 AssignedTo|roan.katt...@gmail.com  |b...@wikidev.net

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand in VisualEditor interface

2012-06-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

--- Comment #15 from Gabriel Wicke gwi...@wikimedia.org 2012-06-23 18:30:47 
UTC ---
(In reply to comment #14)
 (In reply to comment #9)
  The Parsoid serializer tokenizes all text content from the DOM and wraps all
  non-text tokens (any wiki or html syntax) into nowiki blocks.
 
 One more thing is ampersands: nowiki doesn't work on them.
 
 http://www.mediawiki.org/w/index.php?title=Project:Sandboxdiff=554116oldid=553897
 This is rendered as 

This should be fixed with https://gerrit.wikimedia.org/r/#/c/12722/ once it is
deployed. There are also a few other fixes to the wikitext escape algorithm in
Parsoid that are now waiting for deployment.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand in VisualEditor interface

2012-06-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

--- Comment #16 from Liangent liang...@gmail.com 2012-06-23 18:42:12 UTC ---
(In reply to comment #15)
 This should be fixed with https://gerrit.wikimedia.org/r/#/c/12722/ once it is
 deployed. There are also a few other fixes to the wikitext escape algorithm in
 Parsoid that are now waiting for deployment.

Is it really helpful? It seems to handle ,  only, without .

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand in VisualEditor interface

2012-06-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

--- Comment #17 from Gabriel Wicke gwi...@wikimedia.org 2012-06-23 18:59:05 
UTC ---
For now it only handles those two special cases since they are the most urgent.

As described in the commit summary, the real fix will be to remove entity
decoding in the tokenizer, and move it to a token stream transformer instead.
This will give us 'html_entity' tokens which we can escape properly without
having to escape all '' characters that are not part of html entities.

Until then it makes little sense to escape ampersands on plain text content
since those ampersands that are actually part of entities are already decoded
by the tokenizer at that stage, so would not be matched. We could instead
pre-escape the input to the tokenizer, but that would then produce ugly
wikitext for non-entity '' characters.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand

2012-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

Gabriel Wicke wi...@wikidev.net changed:

   What|Removed |Added

 CC||wi...@wikidev.net

--- Comment #9 from Gabriel Wicke wi...@wikidev.net 2012-06-22 08:25:05 UTC 
---
The Parsoid serializer tokenizes all text content from the DOM and wraps all
non-text tokens (any wiki or html syntax) into nowiki blocks.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand in VisualEditor interface

2012-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

MZMcBride b...@mzmcbride.com changed:

   What|Removed |Added

 CC||b...@mzmcbride.com
Summary|Escape wikitext tags|Escape wikitext tags
   |written by hand |written by hand in
   ||VisualEditor interface

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand in VisualEditor interface

2012-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

--- Comment #10 from Liangent liang...@gmail.com 2012-06-22 20:41:17 UTC ---
@MZMcBride: Are we expected to repeat the component field in bug subject?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand in VisualEditor interface

2012-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

--- Comment #11 from MZMcBride b...@mzmcbride.com 2012-06-22 21:28:41 UTC ---
(In reply to comment #10)
 @MZMcBride: Are we expected to repeat the component field in bug subject?

Yes. The bug summary should be a short and succinct snippet that describes the
bug. It may be a bit redundant, but including the component name (whether
that's an extension, MediaWiki core or something else entirely) makes the bug
summary vastly more informative and useful.

In this case, Escape wikitext tags written by hand doesn't tell me what this
bug is about. Escape wikitext tags written by hand in VisualEditor interface
does tell me what this bug is about.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand in VisualEditor interface

2012-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|wikibugs-l@lists.wikimedia. |roan.katt...@gmail.com
   |org |
   Severity|normal  |major

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand in VisualEditor interface

2012-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

  Component|VisualEditor|General
Product|MediaWiki extensions|VisualEditor

--- Comment #12 from James Forrester jforres...@wikimedia.org 2012-06-22 
22:05:22 UTC ---
Mass-moving items into VisualEditor product

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand in VisualEditor interface

2012-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

  Component|General |Data Model

--- Comment #13 from James Forrester jforres...@wikimedia.org 2012-06-23 
01:33:57 UTC ---
Mass-move out of General to Data Model.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand

2012-06-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

 CC||jforres...@wikimedia.org

--- Comment #8 from James Forrester jforres...@wikimedia.org 2012-06-22 
01:07:32 UTC ---
Triage: I believe that currently entering wikitext will trigger it to be
converted into the HTML equivalents and displayed appropriately on round-trip,
but shouldn't.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand

2011-12-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

Liangent liang...@gmail.com changed:

   What|Removed |Added

Summary|Escape preprocessor tags|Escape wikitext tags
   |(especially pre)  |written by hand

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand

2011-12-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

--- Comment #6 from Bergi a.d.be...@web.de 2011-12-28 11:53:26 UTC ---
I think we should distinguish between preprocessor syntax escaping (this
bug), and wikisyntax escaping (Bug 33090).
Of course we could escape everything that looks the least bit of a parser
instruction, but the output wouldn't be readable. But the conditions of what to
escape when differ a lot between preprocessor and wiki syntax, especially as we
already have a DOM of the latter.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33052] Escape wikitext tags written by hand

2011-12-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33052

--- Comment #7 from Liangent liang...@gmail.com 2011-12-28 14:43:52 UTC ---
(In reply to comment #6)
 I think we should distinguish between preprocessor syntax escaping (this
 bug), and wikisyntax escaping (Bug 33090).
 Of course we could escape everything that looks the least bit of a parser
 instruction, but the output wouldn't be readable. But the conditions of what 
 to
 escape when differ a lot between preprocessor and wiki syntax, especially as 
 we
 already have a DOM of the latter.

Yeah but I don't really know how VisualEditor works... However if bug 33090 is
resolved I guess this bug is resolved automatically. Maybe bug dependency?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l