[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 This, that and the other at.li...@live.com.au changed: What|Removed |Added CC||at.li...@live.com.au --- Comment #19 from This, that and the other at.li...@live.com.au 2011-12-17 10:26:38 UTC --- (In reply to comment #14) I'll report this upstream as well as Twinkle should not be messing with native prototypes. Sorry about that. I had feared something like this might happen... I'll make an effort to remove these hackish prototype modifications. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 Derk-Jan Hartman hart...@videolan.org changed: What|Removed |Added CC||hart...@videolan.org --- Comment #20 from Derk-Jan Hartman hart...@videolan.org 2011-12-17 10:40:11 UTC --- I believe i pointed out this issue before: https://bugzilla.wikimedia.org/show_bug.cgi?id=33024#c8 don't for-in loop over arrays -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #18 from Siebrand s.mazel...@xs4all.nl 2011-12-16 08:07:42 UTC --- Was just deployed. Might have a 15 min. or so lag before the JavaScript is rebuilt. We're looking into Narayam and other extensions deployed on Wikimedia if it may cause similar issues. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 --- Comment #1 from Siebrand s.mazel...@xs4all.nl 2011-12-15 08:07:29 UTC --- Can you please provide steps to reproduce? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 --- Comment #2 from Mayur mayur...@gmail.com 2011-12-15 08:13:10 UTC --- I don't know what are the steps but TW is not working in Hindi and Sanskrit Wikipedia from the instant these web fonts were installed.I have tried en wiki script too but it is not working. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 Siddhartha Ghai siddhartha.g...@gmail.com changed: What|Removed |Added CC||siddhartha.g...@gmail.com --- Comment #3 from Siddhartha Ghai siddhartha.g...@gmail.com 2011-12-15 11:39:59 UTC --- I can say the following for hindi wikipedia. When I'm logged out, I see the webfonts' choose font option. But after logging in, I get TW and the other gadgets I'm using, but the webfonts' option is missing.(using chrome 15.0.874.121 m on windows 7 home basic X64). Gadgets I'm using: Twinkle, HotCat, HotInterwiki, Commentsinlocaltime, and a personal simple script to add a portlet menu in p-cactions. Will get back after trying different browser gadget combinations. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 --- Comment #4 from Siddhartha Ghai siddhartha.g...@gmail.com 2011-12-15 14:58:55 UTC --- Hindi wikipedia OS: Windows 7 X64 home basic Browser: Google Chrome 15.0.874.121 m, Firefox 8.0, Safari 5.0.3(7533.19.4), Opera 11.51(build 1087) Gadgets: HotCat, Hotinterwiki, Commentsinlocaltime, edittop, personal script for extra options in the p-variants(not p-cactions as earlier said), purge option in p-cactions, Twinkle. Pages checked: One each in main, category, template, project(wikipedia), portal, mediawiki namespaces. One file page for file on commons, one file page for local file. Twinkle disabled: Google chrome, firefox, safari, opera: Webfonts' change font option visible. All other gadgets seem to work. Twinkle enabled: Google chrome, firefox, safari: Twinkle visible, webfonts' choose font option not visible except pages where Twinkle is inactive. Google Chrome error: Uncaught Error: HIERARCHY_REQUEST_ERR: DOM Exception 3 line 84 http://bits.wikimedia.org/hi.wikipedia.org/load.php?debug=falselang=himodules=jquery%2Cmediawikionly=scriptsskin=vectorversion=20111213T185322Z Firebug error: Node cannot be inserted at the specified point in the hierarchy line 85 http://bits.wikimedia.org/hi.wikipedia.org/load.php?debug=falselang=himodules=jquery%2Cmediawikionly=scriptsskin=vectorversion=20111213T185322Z Safari: Couldn't check for js errors. Opera(Twinkle enabled): Neither twinkle nor webfonts visible. Couldn't check for js errors. Other stuff: HotCat not working in opera no matter twinkle is on or off. There is also a possibility that webfonts might be interfering with article feedback and reftoolbar, but not sure about these yet. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added Priority|Unprioritized |Normal -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added Summary|Twinkle, transwiki |Twinkle broken by webfonts |translation broken by |in sa and hi wikipedias |webfonts in sa and hi | |wikipedias | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154
--- Comment #11 from Siebrand s.mazel...@xs4all.nl 2011-12-15 20:50:11 UTC ---
I was able to reproduce it. I used Firefox 8.0.1 on OSX 10.7.2.
1. Log on to https://hi.wikipedia.org
2. Go to https://hi.wikipedia.org/wiki/Special:Preferences?uselang=en
3. Click tab Gadgets
4. Enable only Twinkle in the section सम्पादन उपकरण and click Save at the
bottom of the page.
5. Goto
https://hi.wikipedia.org/wiki/%E0%A4%AE%E0%A5%81%E0%A4%96%E0%A4%AA%E0%A5%83%E0%A4%B7%E0%A5%8D%E0%A4%A0?debug=true
Adding ?debug=true causes the JavaScript to not be minified, allowing proper
analysis. I do not know how to continue from here...
Observed: JavaScript error Node cannot be inserted at the specified point in
the hierarchy as mentioned in comment 4.
This is the piece of code that the error originates from (line number may
differ):
append: function() {
return this.domManip(arguments, true, function( elem ) {
if ( this.nodeType === 1 ) {
line 5644 - this.appendChild( elem );
}
});
},
With web fonts disabled (preference in tab Appearance) the error does not
occur. With Twinkle disabled, the error also does not occur.
The web developer debugger also states that the use of getAttributeNode() is
discourages and that getAttribute() should be used. Probably not related.
I'm adding a ZIP file with the 10k lines of script in case it helps...
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 --- Comment #12 from Siebrand s.mazel...@xs4all.nl 2011-12-15 20:51:29 UTC --- Created attachment 9714 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9714 JS from comment 10 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
Priority|Normal |Highest
CC||krinklem...@gmail.com
AssignedTo|wikibugs-l@lists.wikimedia. |krinklem...@gmail.com
|org |
Severity|normal |blocker
--- Comment #13 from Krinkle krinklem...@gmail.com 2011-12-16 00:01:29 UTC ---
I've confirmed that the following exception is the cause for everything to
fail.
Uncaught Error: HIERARCHY_REQUEST_ERR: DOM Exception 3
load.php:5644| jQuery.fn.extend.append
load.php:5846| jQuery.fn.extend.domManip
load.php:5819| jQuery.fn.extend.domManip.parent
load.php:660| jQuery.extend.each
load.php:274| jQuery.fn.jQuery.each
load.php:5816| jQuery.fn.extend.domManip
load.php:5642| jQuery.fn.extend.append
ext.webfonts.js:288| mw.webfonts.buildMenuItems
(Using debug=true to get ext.webfonts.js to load unminified/uncombined, and
WebKit Web Inspector to get full trace)
Directly speaking, the bug is due to a bad loop in the WebFonts module.
Indirectly speaking it's caused by Twinkle modifying the browsers' native
constructors prototypes, which is kind a against our conventions, but shouldn't
break anything like this.
Code from WebFonts:
for ( var scheme in config ) {
var $fontLink = $( 'input type=radio name=font /' )
.attr( 'id', fontID( config[scheme] ) )
.val( config[scheme] );
var $fontLabel = $( 'label' )
.attr( 'for',fontID(config[scheme] ) )
.append( $fontLink )
.append( config[scheme] );
config here is an object created as an Array literal, and as such has the
following prototypes injected by Twinke:
* Array.prototype. uniq
* Array.prototype.dups
* Array.prototype.chunk
This loop is attempting to insert a function (!) into the DOM which obviously
will fail terribly.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 --- Comment #14 from Krinkle krinklem...@gmail.com 2011-12-16 00:04:42 UTC --- Should be fixed by r106398. I'll report this upstream as well as Twinkle should not be messing with native prototypes. To be confirmed after deployment. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added AssignedTo|krinklem...@gmail.com |niklas.laxst...@gmail.com --- Comment #16 from Siebrand s.mazel...@xs4all.nl 2011-12-16 00:14:59 UTC --- Fixed in r106398. Niklas will deploy in about 4-5 hours. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 --- Comment #15 from Krinkle krinklem...@gmail.com 2011-12-16 00:07:51 UTC --- The content of attachment 9714 has been deleted by Krinkle krinklem...@gmail.com who provided the following reason: Contains all of jQuery, that's not the cause. Just the utility function being called indirectly. The token used to delete this attachment was generated at 2011-12-16 00:07:29 UTC. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33154] Twinkle broken by webfonts in sa and hi wikipedias
https://bugzilla.wikimedia.org/show_bug.cgi?id=33154 --- Comment #17 from Mayur mayur...@gmail.com 2011-12-16 05:08:07 UTC --- Yes TW is working in normal if i disable webfont in my preferences. (In reply to comment #7) Comment 5 will be ignored in the context of this issue. Please do not create catchall bugs. That is unworkable for developers. The issue mentioned is already known in this tracker for a few weeks and should be fixed right now. Ok, it was observed these day so webfont cold be a probable reason for that.But its ok if it is different bug.TW is working if i disable webfont in my preferences. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
