[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 Helder changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=52729 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 Helder changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=41276 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 Legoktm changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 --- Comment #13 from Gerrit Notification Bot --- Change 83409 merged by jenkins-bot: Create new LQT thread if possible https://gerrit.wikimedia.org/r/83409 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 Legoktm changed: What|Removed |Added CC||legoktm.wikipe...@gmail.com Depends on|26312 | Assignee|wikibugs-l@lists.wikimedia. |legoktm.wikipe...@gmail.com |org | --- Comment #12 from Legoktm --- (In reply to comment #6) > Looks like Krinkle beat me to it and filed the bug last year: > https://bugzilla.wikimedia.org/show_bug.cgi?id=26312 > > I'll mark it as a dependency. > What does this have to do with LiquidThreads at all? I've removed it as a dependency. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 --- Comment #11 from Gerrit Notification Bot --- Change 83409 had a related patch set uploaded by Legoktm: Create new LQT thread if possible https://gerrit.wikimedia.org/r/83409 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 --- Comment #10 from Thorncrag 2012-05-31 18:08:16 UTC --- Just as a side note, MZMcBride directed me toward this bug, because I found that a side-affect of this bug is that users who receive WikiLove when their user talk page has LQT enabled do not receive a new message notification. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 --- Comment #9 from MZMcBride 2012-05-31 18:05:36 UTC --- I believe Werdna was rather adamant about &action=edit§ion=new not being equivalent to posting a LiquidThreads thread. He sees the actions as distinct (cf. bug 21256 comment 3). I thought WikiLove was using the MediaWiki API internally, so I was going to suggest simply checking the target talk page for LiquidThreads and then using the LiquidThreads action instead of &action=edit§ion=new, however it looks like WikiLove isn't using the MediaWiki API (for whatever reason). I glanced at r106754 and it feels very hackish and bad. Particularly these two lines: $this->sectiontitle = $wgLang->truncate( $request->getText( 'wpSectionTitle' ), 250 ); $this->sectiontitle = preg_replace( '/^\s*=+\s*(.*?)\s*=+\s*$/', '$1', $this->sectiontitle ); -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 Mark A. Hershberger changed: What|Removed |Added Priority|Unprioritized |Normal CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 --- Comment #8 from Roan Kattouw 2011-12-20 14:34:12 UTC --- (In reply to comment #2) > Instead of appendtext, it should probably use text=...§ion=new, like the > front-end. That would be closer to something that canonically means wanting to > open a new discussion when used on a talk page. > I think that LQT actually hijacks section=new for adding a new thread, but I'm not sure. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 --- Comment #7 from Ryan Kaldari 2011-12-20 04:26:09 UTC --- I've tried to implement a workaround in r106754. I'll leave this open until the rev is approved. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 Ryan Kaldari changed: What|Removed |Added Depends on||26312 --- Comment #6 from Ryan Kaldari 2011-12-19 23:34:53 UTC --- Looks like Krinkle beat me to it and filed the bug last year: https://bugzilla.wikimedia.org/show_bug.cgi?id=26312 I'll mark it as a dependency. It looks like the essential problem is that action=edit relies on EditPage.php, which for some reason reuses the wpSummary input for both the edit summary and the section title, even though these should be separate inputs. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 --- Comment #5 from Ryan Kaldari 2011-12-19 23:06:04 UTC --- I'm going to file a new bug explaining that magically morphing the summary from an edit summary into a section title and then auto-generating an edit summary that is different than the summary makes no sense. I bet you a dollar it will be closed within 24 hours as WONTFIX since it is written into the 10 Commandments "Thou shalt not change the MediaWiki API" :P -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 --- Comment #4 from Ryan Kaldari 2011-12-19 22:53:45 UTC --- Actually that's only half true. You can specify an edit summary, but it doesn't respect what you specify. Instead it forces it into a "new section" message. We just need a way to override this. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 Ryan Kaldari changed: What|Removed |Added Component|API |WikiLove Version|unspecified |any Product|MediaWiki |MediaWiki extensions -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 --- Comment #3 from Ryan Kaldari 2011-12-19 22:40:58 UTC --- We can't use section=new since that method doesn't allow us to specify the edit summary. If someone fixes that, I'll gladly re-implement it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 Krinkle changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #2 from Krinkle 2011-12-19 22:20:55 UTC --- Hm.. it would be an API bug if it the canonical goal behind appending text to a page is to create a new thread, or even to participate in discussion at all. However, for one, the header of an LQT-enabled page should be editable as well. And secondly, how can we distinguish from appending something to the last section and appending a new section ? Instead of appendtext, it should probably use text=...§ion=new, like the front-end. That would be closer to something that canonically means wanting to open a new discussion when used on a talk page. Theoratically a bot could be using text=..§ion=new to create a new section in the header of an LQT-enabled page, so we'd have to find a way to do that still. Perhaps MediaWiki should get an additional parameter (or different action/module alltogether) for participating in discussions and letting extensions override this ? By default it would implement a 'raw wikitext' discussion thread, which is just sections on a talk page. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33260] WikiLove posts above LiquidThreads rather than within a thread
https://bugzilla.wikimedia.org/show_bug.cgi?id=33260 Ryan Kaldari changed: What|Removed |Added CC||bryan.tongm...@gmail.com, ||roan.katt...@gmail.com, ||s...@reedyboy.net, ||soxre...@gmail.com Component|WikiLove|API Version|any |unspecified Product|MediaWiki extensions|MediaWiki --- Comment #1 from Ryan Kaldari 2011-12-19 22:14:42 UTC --- WikiLove just uses the MediaWiki API to post the message (via the appendtext parameter using action=edit). So this is actually an API bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
