[Bug 33287] Get rid of svn keywords in API files

2013-03-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

--- Comment #20 from Yuri Astrakhan yu...@wikimedia.org ---
Updated docs. The extensions might need to be updated later, as they sometimes
get deployed before the new core.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2013-03-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

Niklas Laxström niklas.laxst...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #19 from Niklas Laxström niklas.laxst...@gmail.com ---
These are still present in many extensions and in
http://www.mediawiki.org/wiki/API:Extensions

At least the documentation must be updated to reflect the current practice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2013-03-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #18 from Antoine hashar Musso has...@free.fr ---
I guess :-]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2013-03-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

Yuri Astrakhan yuriastrak...@gmail.com changed:

   What|Removed |Added

 CC||yuriastrak...@gmail.com

--- Comment #17 from Yuri Astrakhan yuriastrak...@gmail.com ---
Now that SVN Id keywords has been removed by
I910ca1448ed2ed697ac19b17c486d130aa1d7e03 - should I close this bug too?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-07-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

--- Comment #15 from Krinkle krinklem...@gmail.com 2012-07-12 13:55:05 UTC ---
Lets start by making the abstract method implemented, so new Api modules people
create don't need this method. Just ran into this during a tutorial.

Mr. Krinkle, what's the $Id:$ line for? :-)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-07-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

--- Comment #16 from Sam Reed (reedy) s...@reedyboy.net 2012-07-12 15:46:31 
UTC ---
(In reply to comment #15)
 Lets start by making the abstract method implemented, so new Api modules 
 people
 create don't need this method. Just ran into this during a tutorial.
 
 Mr. Krinkle, what's the $Id:$ line for? :-)

Need to make it return something... $wgVersion

Oh, and remove Usually done with SVN's Id keyword at the same time xD

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

 CC||bugrepor...@to.mabomuja.de

--- Comment #14 from Antoine hashar Musso has...@free.fr 2012-07-11 
09:38:56 UTC ---
*** Bug 38301 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-06-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

Niklas Laxström niklas.laxst...@gmail.com changed:

   What|Removed |Added

 CC||niklas.laxst...@gmail.com

--- Comment #10 from Niklas Laxström niklas.laxst...@gmail.com 2012-06-20 
10:23:44 UTC ---
Are you going to do something about this?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-06-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

 CC||has...@free.fr

--- Comment #11 from Antoine hashar Musso has...@free.fr 2012-06-20 
11:49:06 UTC ---
Gerrit change https://gerrit.wikimedia.org/r/#/c/12155/

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-06-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

--- Comment #12 from Chad H. innocentkil...@gmail.com 2012-06-20 11:55:26 UTC 
---
(In reply to comment #11)
 Gerrit change https://gerrit.wikimedia.org/r/#/c/12155/

There are dozens of core API files that need changing too. Plus all other
extensions using this.

Like I suggested before, I think we should change this to return an integer,
and increment it by 1 anytime a module changes in an incompatible way.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-06-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

--- Comment #13 from Antoine hashar Musso has...@free.fr 2012-06-20 
13:18:55 UTC ---
Go ahead Chad. I will be glad to +2 / merges such a change.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-05-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

Iaroslav Vassiliev codem...@yandex.ru changed:

   What|Removed |Added

 CC||codem...@yandex.ru

--- Comment #9 from Iaroslav Vassiliev codem...@yandex.ru 2012-05-02 20:36:01 
UTC ---
Some kind of versioning is definitely required.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-04-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

--- Comment #6 from Antoine hashar Musso has...@free.fr 2012-04-16 14:26:41 
UTC ---
git has the ability to fill in keywords when checking out files. Have a look at
Keyword Expansion on http://progit.org/book/ch7-2.html .

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-04-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

--- Comment #7 from Max Semenik maxsem.w...@gmail.com 2012-04-16 14:30:51 UTC 
---
Solutions that require local configuration changes will not work as nobody will
use them.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-04-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

--- Comment #8 from Chad H. innocentkil...@gmail.com 2012-04-16 14:52:00 UTC 
---
(In reply to comment #6)
 git has the ability to fill in keywords when checking out files. Have a look 
 at
 Keyword Expansion on http://progit.org/book/ch7-2.html .

Just because the functionality exists doesn't mean we should use it. There's
lots of bad ideas out there ;-)

(In reply to comment #7)
 Solutions that require local configuration changes will not work as nobody 
 will
 use them.

This.

(In reply to comment #5)
 (In reply to comment #2)
  It would be nice to have some kind of versioning on our public API so people
  can detect incompatibilities when they exist.
 
 Although the previous svn:keywords did not provide that information, that was
 just a simple last rev modified number. Right now this bug is just to remove
 them. We could open a feature enhancement ticket for that other, although I
 personally never found that needed and release notes seem to be more useful 
 for
 breaking changes. If we create an API module to programmatically be able to
 export the version of an Api module, the it could be useful to an Api client 
 to
 see if it considers itself compatible, that'd be a nice feature.

I'm in favor of simple integer increments. When a module changes in an
incompatible way, bump v1 - v2 (which doesn't happen *often*). But you're
right, let's spin that off to another bug and just remove the existing keywords
while we bikeshed over that.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-04-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #5 from Krinkle krinklem...@gmail.com 2012-04-14 04:18:26 UTC ---
(In reply to comment #2)
 It would be nice to have some kind of versioning on our public API so people
 can detect incompatibilities when they exist.

Although the previous svn:keywords did not provide that information, that was
just a simple last rev modified number. Right now this bug is just to remove
them. We could open a feature enhancement ticket for that other, although I
personally never found that needed and release notes seem to be more useful for
breaking changes. If we create an API module to programmatically be able to
export the version of an Api module, the it could be useful to an Api client to
see if it considers itself compatible, that'd be a nice feature.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-04-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

Sam Reed (reedy) s...@reedyboy.net changed:

   What|Removed |Added

 Blocks||35885

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-02-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

 CC||has...@free.fr

--- Comment #3 from Antoine hashar Musso has...@free.fr 2012-02-17 08:48:32 
UTC ---
We could do that using a global array just like we did to track stylesheet
version. Or define a constant for each API class much like Parser::VERSION or
Parser_LinkHooks::VERSION.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2012-02-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

--- Comment #4 from Chad H. innocentkil...@gmail.com 2012-02-17 12:56:50 UTC 
---
(In reply to comment #3)
 We could do that using a global array just like we did to track stylesheet
 version. Or define a constant for each API class much like Parser::VERSION or
 Parser_LinkHooks::VERSION.

I'd much prefer the latter. As long as we can define a clear policy for how
often and when the version numbers should be bumped.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2011-12-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

--- Comment #1 from Reedy s...@reedyboy.net 2011-12-21 01:04:18 UTC ---
(In reply to comment #0)
 They're going to be useless in Git. Need to come up with a new versioning
 scheme.

Or do we really need to keep them at all?

They have some use, but I can't really say I've ever used [1] for anything
specifically, and similarly for [2]

[1] http://en.wikipedia.org/w/api.php?version
[2] http://en.wikipedia.org/w/api.php?action=paraminfomodules=parse

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2011-12-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

--- Comment #2 from Chad H. innocentkil...@gmail.com 2011-12-21 01:44:18 UTC 
---
It would be nice to have some kind of versioning on our public API so people
can detect incompatibilities when they exist.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33287] Get rid of svn keywords in API files

2011-12-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33287

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l