[Bug 33614] $wgUseCategoryBrowser generates many dupes

2013-10-23 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

Chad H. innocentkil...@gmail.com changed:

   What|Removed |Added

Version|1.18.2  |1.18.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2013-06-26 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

Version|1.17.1  |1.18.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-06-20 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

bal...@iupui.edu changed:

   What|Removed |Added

 CC||bal...@iupui.edu

--- Comment #13 from bal...@iupui.edu 2012-06-20 19:24:35 UTC ---
I was also seeing duplicates in my small (1000 non-stubs) MW 1.18.2. I believe
at least some of the duplicates are coming because the category browser drops
the bottom level category off some entries. I've documented this behavior at 

http://www.mediawiki.org/w/index.php?title=Help:Categoriesstable=0shownotice=1fromsection=Adding_a_page_to_a_category#Adding_a_page_to_a_category

and I repeat it here:

(At least in MediaWiki 1.18.2) if a category is a subcategory of more than one
parent, both hierarchies will be listed, but the tagged category will be
stripped off all but one of these. This creates the potential for what appear
to be duplicate entries if a category with multiple parents and one of its
parents are both tagged on a page. For example suppose Maryanne is a
subcategory of both Mary and Anne. If a page tags categories Maryanne and Anne
then the Category breadcrumbs will show

Anne 
Anne
Mary - Maryanne

Anne appears to be duplicated, but what is meant is

Anne 
Anne - Maryanne
Mary - Maryanne

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-03-14 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

--- Comment #10 from Mark A. Hershberger m...@everybody.org 2012-03-14 
17:50:21 UTC ---
$tempout = preg_grep( /MediaWiki:Hidden-categories/,

can't be used:

 We can't directly incorporate your code into core MediaWiki
 since there is no guarantee that the hidden category's name is
 actually Hidden categories (with i18n and all).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-03-14 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

--- Comment #11 from Bawolff bawolff...@gmail.com 2012-03-14 18:00:00 UTC ---
preg_grep( / . preg_quote( wfMsgForContent( MediaWiki:Hidden-categories ),
/ ) ./, ...

Would work, which is what I believe you were trying to get at (In theory
anyways, I haven't tested it). However, I think it would be preferable to look
for the cat_hidden prop in page_props table when doing the actual db query.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-03-14 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

--- Comment #12 from Technical_13 technical...@yahoo.com 2012-03-14 18:12:54 
UTC ---
(In reply to comment #11)
 preg_grep( / . preg_quote( wfMsgForContent( MediaWiki:Hidden-categories ),
 / ) ./, ...
 
 Would work, which is what I believe you were trying to get at (In theory
 anyways, I haven't tested it). However, I think it would be preferable to look
 for the cat_hidden prop in page_props table when doing the actual db query.

That was what I was trying to get at..  That way, it wouldn't matter what the
hiddencat name actually was, as it would be defined correctly in all instance
on that page anyways.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-03-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

Bawolff bawolff...@gmail.com changed:

   What|Removed |Added

   Keywords|need-review |reviewed

--- Comment #8 from Bawolff bawolff...@gmail.com 2012-03-12 14:10:18 UTC ---
(In reply to comment #6)
 Thanks for this bug report! I thought for sure I had something in my wiki
 configured incorrectly.
 
 I ended up hacking my 1.17 wiki to fix this. I replaced this line from
 includes/Skin.php:

Glad to hear you got this working on your wiki.

(In response more to the patch keyword added by others then to your comment) We
can't directly incorporate your code into core MediaWiki since there is no
guarantee that the hidden category's name is actually Hidden categories (with
i18n and all).

Ideally this filtering would be done when querying the db/building the list of
categories, as opposed to after the fact.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-03-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

--- Comment #9 from Technical_13 technical...@yahoo.com 2012-03-12 14:35:38 
UTC ---
Correct me if I am wrong, but wouldn't it be feasible to replace:

$tempout = explode( \n, $this-drawCategoryBrowser( $parenttree, $this ) );

With this:

if ($wgUser-getBoolOption( 'showhiddencats' )) {
$tempout = array_unique(explode( \n, $this-drawCategoryBrowser(
$parenttree, $this ) ));
}
else {  
$tempout = preg_grep( /MediaWiki:Hidden-categories/,
array_unique(explode( \n,
$this-drawCategoryBrowser( $parenttree, $this ) )), PREG_GREP_INVERT );
}

So that instead of specifically specifying it as the hidden category's name as
Hidden categories you have it refer to the MediaWiki page that the name is
actually set on?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-03-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

Technical_13 technical...@yahoo.com changed:

   What|Removed |Added

 CC||technical...@yahoo.com

--- Comment #5 from Technical_13 technical...@yahoo.com 2012-03-12 02:26:55 
UTC ---
I've also noticed that the hiddencats display regardless of the status of the
Show Hidden Categories checkbox in user preferences.  Need a way to actually
hide the hidden cats..

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-03-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

Ken k...@xev.net changed:

   What|Removed |Added

 CC||k...@xev.net

--- Comment #6 from Ken k...@xev.net 2012-03-12 02:43:18 UTC ---
Thanks for this bug report! I thought for sure I had something in my wiki
configured incorrectly.

I ended up hacking my 1.17 wiki to fix this. I replaced this line from
includes/Skin.php:

$tempout = array_unique(explode( \n, $this-drawCategoryBrowser( $parenttree,
$this ) ));

with this:

if ($wgUser-getBoolOption( 'showhiddencats' )) {
$tempout = array_unique(explode( \n, $this-drawCategoryBrowser(
$parenttree, $this ) ));
}
else {  
$tempout = preg_grep( /Hidden categories/, array_unique(explode( \n,
$this-drawCategoryBrowser( $parenttree, $this ) )), PREG_GREP_INVERT );
}

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-03-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

--- Comment #7 from Ken k...@xev.net 2012-03-12 02:49:35 UTC ---
sorry, I pasted the wrong line for the original line. The original line is
this (it does not have array_unique in it):

$tempout = explode( \n, $this-drawCategoryBrowser( $parenttree, $this ) );

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-01-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

 CC||has...@free.fr

--- Comment #4 from Antoine hashar Musso has...@free.fr 2012-01-12 22:38:39 
UTC ---
 If the page is in:

 A  B  C  D

Well the whole idea of category browser is to put the article in D category and
skipping A,B,C :-b

array_unique() works there. But it is on display. We should be able to filter
before rendering, I E when building the category tree.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-01-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Keywords||need-review, patch
 CC||m...@everybody.org

--- Comment #3 from Mark A. Hershberger m...@everybody.org 2012-01-11 
17:37:15 UTC ---
Adding patch keyword for solution in comment #1

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-01-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-01-09 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

--- Comment #1 from steevithak srainwa...@ncc.com 2012-01-09 21:08:19 UTC ---
Found a fairly trivial fix for this. In Skin.php, I added an array_unique() to
the explode(). the line was:

$tempout = explode( \n, $this-drawCategoryBrowser( $parenttree, $this ) );

I changed it to:

$tempout = array_unique( explode( \n, $this-drawCategoryBrowser(
$parenttree, $this ) ) );


The only drawback now is that it still displays hidden categories, which
doesn't seem right. Probably a separate bug however.

Here's the current output from the same page as show in initial comment:

Root category
Root category  Cameras
Root category  Cameras  Cameras by first letter  B
Root category  Cameras  Cameras by first letter  C
Root category  Cameras  Medium format  127 film
Root category  Companies  Camera makers
Root category  Countries  Italy
Root category  Countries  Italy  Bencini
Root category  Imaging media  Film  Film formats
Root category  Special categories
Root category  Templates  Wiki  Flickr image
Root category  Templates  Wiki  Hidden categories  Image by AWCam
Root category  Templates  Wiki  Hidden categories  Image by Dirk HR
Spennemann
Root category  Templates  Wiki  Hidden categories  Image by Rick Soloway
Root category  Templates  Wiki  Hidden categories  Image by jgs4309976

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 33614] $wgUseCategoryBrowser generates many dupes

2012-01-09 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=33614

--- Comment #2 from steevithak srainwa...@ncc.com 2012-01-09 22:24:30 UTC ---
Upon further thought, there's still redundancy here. For example:

If the page is in:

A  B  C  D

There's really no point in also displaying these lines:

A
A  B
A  B  C

As they're all included in D. They're not really paths to the given page
anyway. Really what's wanted is a list of unique paths through the hierarchy to
the given page. There's no need to provide additional paths to each point along
the way. If that makes sense.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l